You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cloudstack.apache.org by GitBox <gi...@apache.org> on 2021/09/15 15:54:44 UTC
[GitHub] [cloudstack] SadiJr opened a new pull request #5455: Improve Veeam Plugin logs
SadiJr opened a new pull request #5455:
URL: https://github.com/apache/cloudstack/pull/5455
### Description
This PR intends to improve logs in Veeam Backup Plugin, to help troubleshooting. Also, I removed some duplicated code.
### Types of changes
- [ ] Breaking change (fix or feature that would cause existing functionality to change)
- [ ] New feature (non-breaking change which adds functionality)
- [ ] Bug fix (non-breaking change which fixes an issue)
- [x] Enhancement (improves an existing feature and functionality)
- [ ] Cleanup (Code refactoring and cleanup, that may add test cases)
### Feature/Enhancement Scale or Bug Severity
#### Feature/Enhancement Scale
- [ ] Major
- [x] Minor
### How Has This Been Tested?
- I maked a new build with this alterations and test in a local lab;
- I run some tests, like import a backup offering, assign VM to backup offering, try listing backups, etc;
- And I readed the logs to verify if the new informations appears.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] nvazquez commented on pull request #5455: Improve Veeam Plugin logs
Posted by GitBox <gi...@apache.org>.
nvazquez commented on pull request #5455:
URL: https://github.com/apache/cloudstack/pull/5455#issuecomment-925486254
@blueorangutan package
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] sureshanaparti commented on a change in pull request #5455: Improve Veeam Plugin logs
Posted by GitBox <gi...@apache.org>.
sureshanaparti commented on a change in pull request #5455:
URL: https://github.com/apache/cloudstack/pull/5455#discussion_r712854118
##########
File path: plugins/backup/veeam/src/main/java/org/apache/cloudstack/backup/veeam/VeeamClient.java
##########
@@ -616,18 +633,20 @@ public boolean deleteJobAndBackup(final String jobName) {
public List<Backup.RestorePoint> listRestorePoints(String backupName, String vmInternalName) {
final List<String> cmds = Arrays.asList(
String.format("$backup = Get-VBRBackup -Name \"%s\"", backupName),
- String.format("if ($backup) { (Get-VBRRestorePoint -Backup:$backup -Name \"%s\" ^| Where-Object {$_.IsConsistent -eq $true}) }", vmInternalName)
+ String.format("if ($backup) { $restore = (Get-VBRRestorePoint -Backup:$backup -Name \"%s\" ^| Where-Object {$_.IsConsistent -eq $true})", vmInternalName),
+ "if ($restore) { $restore ^| Format-List } }"
Review comment:
@SadiJr Is this cmd change tested?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #5455: Improve Veeam Plugin logs
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5455:
URL: https://github.com/apache/cloudstack/pull/5455#issuecomment-925236621
@rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] DaanHoogland commented on a change in pull request #5455: Improve Veeam Plugin logs
Posted by GitBox <gi...@apache.org>.
DaanHoogland commented on a change in pull request #5455:
URL: https://github.com/apache/cloudstack/pull/5455#discussion_r709829822
##########
File path: plugins/backup/veeam/src/main/java/org/apache/cloudstack/backup/VeeamBackupProvider.java
##########
@@ -149,7 +152,7 @@ public boolean assignVMToBackupOffering(final VirtualMachine vm, final BackupOff
for (final BackupOffering job : client.listJobs()) {
if (job.getName().equals(clonedJobName)) {
final Job clonedJob = client.listJob(job.getExternalId());
- if (clonedJob.getScheduleConfigured() && !clonedJob.getScheduleEnabled()) {
+ if (BooleanUtils.isTrue(clonedJob.getScheduleConfigured()) && !clonedJob.getScheduleEnabled()) {
Review comment:
why is `BooleanUtils` needed?
##########
File path: server/src/main/java/org/apache/cloudstack/backup/BackupManagerImpl.java
##########
@@ -1012,6 +1006,7 @@ protected void runInContext() {
}
for (final DataCenter dataCenter : dataCenterDao.listAllZones()) {
if (dataCenter == null || isDisabled(dataCenter.getId())) {
+ LOG.warn(String.format("Backup Sync Task is not enabled in zone [%s]. Skipping this zone!", dataCenter == null ? "NULL Zone!" : dataCenter.getId()));
Review comment:
why an `error` message for every zone, if its not there? we are looking for only one, so `info` er even `debug` should be enough.
##########
File path: server/src/main/java/org/apache/cloudstack/backup/BackupManagerImpl.java
##########
@@ -1023,6 +1018,7 @@ protected void runInContext() {
List<VMInstanceVO> vms = vmInstanceDao.listByZoneWithBackups(dataCenter.getId(), null);
if (vms == null || vms.isEmpty()) {
+ LOG.warn(String.format("Can't find any VM to sync backups in zone [id: %s].", dataCenter.getId()));
Review comment:
`debug` should be enough
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #5455: Improve Veeam Plugin logs
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5455:
URL: https://github.com/apache/cloudstack/pull/5455#issuecomment-925496749
Packaging result: :heavy_check_mark: el7 :heavy_check_mark: el8 :heavy_check_mark: debian :heavy_check_mark: suse15. SL-JID 1367
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] SadiJr commented on a change in pull request #5455: Improve Veeam Plugin logs
Posted by GitBox <gi...@apache.org>.
SadiJr commented on a change in pull request #5455:
URL: https://github.com/apache/cloudstack/pull/5455#discussion_r713863393
##########
File path: plugins/backup/veeam/src/main/java/org/apache/cloudstack/backup/veeam/VeeamClient.java
##########
@@ -616,18 +633,20 @@ public boolean deleteJobAndBackup(final String jobName) {
public List<Backup.RestorePoint> listRestorePoints(String backupName, String vmInternalName) {
final List<String> cmds = Arrays.asList(
String.format("$backup = Get-VBRBackup -Name \"%s\"", backupName),
- String.format("if ($backup) { (Get-VBRRestorePoint -Backup:$backup -Name \"%s\" ^| Where-Object {$_.IsConsistent -eq $true}) }", vmInternalName)
+ String.format("if ($backup) { $restore = (Get-VBRRestorePoint -Backup:$backup -Name \"%s\" ^| Where-Object {$_.IsConsistent -eq $true})", vmInternalName),
+ "if ($restore) { $restore ^| Format-List } }"
);
Pair<Boolean, String> response = executePowerShellCommands(cmds);
final List<Backup.RestorePoint> restorePoints = new ArrayList<>();
if (response == null || !response.first()) {
- LOG.debug("Veeam restore point listing failed due to: " + (response != null ? response.second() : "no powershell output returned"));
return restorePoints;
}
+
for (final String block : response.second().split("\r\n\r\n")) {
if (block.isEmpty()) {
continue;
}
+ LOG.debug(String.format("Found restore points from [backupName: %s, vmInternalName: %s] with is: [%s].", backupName, vmInternalName, block));
Review comment:
Done, thanks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] rhtyd commented on pull request #5455: Improve Veeam Plugin logs
Posted by GitBox <gi...@apache.org>.
rhtyd commented on pull request #5455:
URL: https://github.com/apache/cloudstack/pull/5455#issuecomment-926566776
I checked the code and I think it should work on Veeam 9.x as well, the change introduces using a powershell utility to format the list than introduce change in veeam cmds themselves. Merging this based on review, smoketests and @SadiJr 's confirmation of some manual tests against Veeam.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] nvazquez commented on pull request #5455: Improve Veeam Plugin logs
Posted by GitBox <gi...@apache.org>.
nvazquez commented on pull request #5455:
URL: https://github.com/apache/cloudstack/pull/5455#issuecomment-925895747
@rhtyd @DaanHoogland this looks ready to merge, however, I am concerned about the Veeam version 9.x which is not tested and was previously supported
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #5455: Improve Veeam Plugin logs
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5455:
URL: https://github.com/apache/cloudstack/pull/5455#issuecomment-925858145
<b>Trillian test result (tid-2172)</b>
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 33996 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr5455-t2172-kvm-centos7.zip
Smoke tests completed. 89 look OK, 0 have errors
Only failed tests results shown below:
Test | Result | Time (s) | Test File
--- | --- | --- | ---
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] rhtyd commented on pull request #5455: Improve Veeam Plugin logs
Posted by GitBox <gi...@apache.org>.
rhtyd commented on pull request #5455:
URL: https://github.com/apache/cloudstack/pull/5455#issuecomment-925235540
@blueorangutan package
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] SadiJr commented on a change in pull request #5455: Improve Veeam Plugin logs
Posted by GitBox <gi...@apache.org>.
SadiJr commented on a change in pull request #5455:
URL: https://github.com/apache/cloudstack/pull/5455#discussion_r711294499
##########
File path: server/src/main/java/org/apache/cloudstack/backup/BackupManagerImpl.java
##########
@@ -1023,6 +1018,7 @@ protected void runInContext() {
List<VMInstanceVO> vms = vmInstanceDao.listByZoneWithBackups(dataCenter.getId(), null);
if (vms == null || vms.isEmpty()) {
+ LOG.warn(String.format("Can't find any VM to sync backups in zone [id: %s].", dataCenter.getId()));
Review comment:
Done.
##########
File path: server/src/main/java/org/apache/cloudstack/backup/BackupManagerImpl.java
##########
@@ -1012,6 +1006,7 @@ protected void runInContext() {
}
for (final DataCenter dataCenter : dataCenterDao.listAllZones()) {
if (dataCenter == null || isDisabled(dataCenter.getId())) {
+ LOG.warn(String.format("Backup Sync Task is not enabled in zone [%s]. Skipping this zone!", dataCenter == null ? "NULL Zone!" : dataCenter.getId()));
Review comment:
Done.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] SadiJr commented on a change in pull request #5455: Improve Veeam Plugin logs
Posted by GitBox <gi...@apache.org>.
SadiJr commented on a change in pull request #5455:
URL: https://github.com/apache/cloudstack/pull/5455#discussion_r711295747
##########
File path: plugins/backup/veeam/src/main/java/org/apache/cloudstack/backup/VeeamBackupProvider.java
##########
@@ -149,7 +152,7 @@ public boolean assignVMToBackupOffering(final VirtualMachine vm, final BackupOff
for (final BackupOffering job : client.listJobs()) {
if (job.getName().equals(clonedJobName)) {
final Job clonedJob = client.listJob(job.getExternalId());
- if (clonedJob.getScheduleConfigured() && !clonedJob.getScheduleEnabled()) {
+ if (BooleanUtils.isTrue(clonedJob.getScheduleConfigured()) && !clonedJob.getScheduleEnabled()) {
Review comment:
Because `BooleanUtils.isTrue()` is null safe, and the method `client.listJob(job.getExternalId())` can return null.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] Pearl1594 commented on a change in pull request #5455: Improve Veeam Plugin logs
Posted by GitBox <gi...@apache.org>.
Pearl1594 commented on a change in pull request #5455:
URL: https://github.com/apache/cloudstack/pull/5455#discussion_r712786230
##########
File path: plugins/backup/veeam/src/main/java/org/apache/cloudstack/backup/veeam/VeeamClient.java
##########
@@ -616,18 +633,20 @@ public boolean deleteJobAndBackup(final String jobName) {
public List<Backup.RestorePoint> listRestorePoints(String backupName, String vmInternalName) {
final List<String> cmds = Arrays.asList(
String.format("$backup = Get-VBRBackup -Name \"%s\"", backupName),
- String.format("if ($backup) { (Get-VBRRestorePoint -Backup:$backup -Name \"%s\" ^| Where-Object {$_.IsConsistent -eq $true}) }", vmInternalName)
+ String.format("if ($backup) { $restore = (Get-VBRRestorePoint -Backup:$backup -Name \"%s\" ^| Where-Object {$_.IsConsistent -eq $true})", vmInternalName),
+ "if ($restore) { $restore ^| Format-List } }"
);
Pair<Boolean, String> response = executePowerShellCommands(cmds);
final List<Backup.RestorePoint> restorePoints = new ArrayList<>();
if (response == null || !response.first()) {
- LOG.debug("Veeam restore point listing failed due to: " + (response != null ? response.second() : "no powershell output returned"));
return restorePoints;
}
+
for (final String block : response.second().split("\r\n\r\n")) {
if (block.isEmpty()) {
continue;
}
+ LOG.debug(String.format("Found restore points from [backupName: %s, vmInternalName: %s] with is: [%s].", backupName, vmInternalName, block));
Review comment:
minor nit:
```suggestion
LOG.debug(String.format("Found restore points from [backupName: %s, vmInternalName: %s] which is: [%s].", backupName, vmInternalName, block));
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] nvazquez commented on pull request #5455: Improve Veeam Plugin logs
Posted by GitBox <gi...@apache.org>.
nvazquez commented on pull request #5455:
URL: https://github.com/apache/cloudstack/pull/5455#issuecomment-925487044
Agree with @DaanHoogland's comment to trust on @SadiJr's tests
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] rhtyd commented on pull request #5455: Improve Veeam Plugin logs
Posted by GitBox <gi...@apache.org>.
rhtyd commented on pull request #5455:
URL: https://github.com/apache/cloudstack/pull/5455#issuecomment-923687317
@SadiJr was this tested against Veeam 9.x?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #5455: Improve Veeam Plugin logs
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5455:
URL: https://github.com/apache/cloudstack/pull/5455#issuecomment-925486344
@nvazquez a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #5455: Improve Veeam Plugin logs
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5455:
URL: https://github.com/apache/cloudstack/pull/5455#issuecomment-925499577
@nvazquez a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] rhtyd merged pull request #5455: Improve Veeam Plugin logs
Posted by GitBox <gi...@apache.org>.
rhtyd merged pull request #5455:
URL: https://github.com/apache/cloudstack/pull/5455
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] rhtyd commented on a change in pull request #5455: Improve Veeam Plugin logs
Posted by GitBox <gi...@apache.org>.
rhtyd commented on a change in pull request #5455:
URL: https://github.com/apache/cloudstack/pull/5455#discussion_r715547137
##########
File path: plugins/backup/veeam/src/main/java/org/apache/cloudstack/backup/veeam/VeeamClient.java
##########
@@ -616,18 +633,20 @@ public boolean deleteJobAndBackup(final String jobName) {
public List<Backup.RestorePoint> listRestorePoints(String backupName, String vmInternalName) {
final List<String> cmds = Arrays.asList(
String.format("$backup = Get-VBRBackup -Name \"%s\"", backupName),
- String.format("if ($backup) { (Get-VBRRestorePoint -Backup:$backup -Name \"%s\" ^| Where-Object {$_.IsConsistent -eq $true}) }", vmInternalName)
+ String.format("if ($backup) { $restore = (Get-VBRRestorePoint -Backup:$backup -Name \"%s\" ^| Where-Object {$_.IsConsistent -eq $true})", vmInternalName),
+ "if ($restore) { $restore ^| Format-List } }"
Review comment:
Code appears should be backward compatible
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] SadiJr commented on a change in pull request #5455: Improve Veeam Plugin logs
Posted by GitBox <gi...@apache.org>.
SadiJr commented on a change in pull request #5455:
URL: https://github.com/apache/cloudstack/pull/5455#discussion_r713867137
##########
File path: plugins/backup/veeam/src/main/java/org/apache/cloudstack/backup/veeam/VeeamClient.java
##########
@@ -616,18 +633,20 @@ public boolean deleteJobAndBackup(final String jobName) {
public List<Backup.RestorePoint> listRestorePoints(String backupName, String vmInternalName) {
final List<String> cmds = Arrays.asList(
String.format("$backup = Get-VBRBackup -Name \"%s\"", backupName),
- String.format("if ($backup) { (Get-VBRRestorePoint -Backup:$backup -Name \"%s\" ^| Where-Object {$_.IsConsistent -eq $true}) }", vmInternalName)
+ String.format("if ($backup) { $restore = (Get-VBRRestorePoint -Backup:$backup -Name \"%s\" ^| Where-Object {$_.IsConsistent -eq $true})", vmInternalName),
+ "if ($restore) { $restore ^| Format-List } }"
Review comment:
Yes, I tested in Veeam B&R v11 (build 11.0.0.837), Enterprise license. Works fine. And, according to the powershell documentation (https://docs.microsoft.com/en-us/powershell/module/microsoft.powershell.utility/format-list?view=powershell-7.1), when using Format-List, the commands will be output in the pattern expected by ACS.
But I don't tested in Veeam 9.x.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] nvazquez commented on pull request #5455: Improve Veeam Plugin logs
Posted by GitBox <gi...@apache.org>.
nvazquez commented on pull request #5455:
URL: https://github.com/apache/cloudstack/pull/5455#issuecomment-925499474
@blueorangutan test
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #5455: Improve Veeam Plugin logs
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5455:
URL: https://github.com/apache/cloudstack/pull/5455#issuecomment-925297785
Packaging result: :heavy_check_mark: el7 :heavy_multiplication_x: el8 :heavy_check_mark: debian :heavy_check_mark: suse15. SL-JID 1362
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] rhtyd commented on pull request #5455: Improve Veeam Plugin logs
Posted by GitBox <gi...@apache.org>.
rhtyd commented on pull request #5455:
URL: https://github.com/apache/cloudstack/pull/5455#issuecomment-924688664
@SadiJr can you address the comments and advise if you've tested this against Veeam 9.x?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org