[GitHub] [cassandra] clohfink commented on a change in pull request #719: Add metric for client concurrent byte throttle

[GitBox <gi...@apache.org>]

clohfink commented on a change in pull request #719:
URL: https://github.com/apache/cassandra/pull/719#discussion_r478647162



##########
File path: src/java/org/apache/cassandra/utils/EstimatedHistogram.java
##########
@@ -365,6 +370,57 @@ public int hashCode()
         return Objects.hashCode(getBucketOffsets(), getBuckets(false));
     }
 
+    public int size()
+    {
+        return toIntExact(count());
+    }
+
+    public void update(long l)
+    {
+        this.add(l);
+    }
+
+    static class EstimatedHistogramSnapshot extends UniformSnapshot

Review comment:
       this was copied from previous implementation that was replaced with the decaying reservoir. I can fix this up to be correct




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org