[GitHub] [druid] clintropolis commented on a diff in pull request #12947: add maxBytesInMemory and maxClientResponseBytes to SamplerConfig

[GitBox <gi...@apache.org>]

clintropolis commented on code in PR #12947:
URL: https://github.com/apache/druid/pull/12947#discussion_r953329702


##########
indexing-service/src/main/java/org/apache/druid/indexing/overlord/sampler/SamplerConfig.java:
##########
@@ -22,34 +22,53 @@
 import com.fasterxml.jackson.annotation.JsonCreator;
 import com.fasterxml.jackson.annotation.JsonProperty;
 import com.google.common.base.Preconditions;
+import org.apache.druid.data.input.InputFormat;
+import org.apache.druid.data.input.InputSource;
+import org.apache.druid.segment.indexing.DataSchema;
+
+import javax.annotation.Nullable;
 
 public class SamplerConfig
 {
   private static final int DEFAULT_NUM_ROWS = 200;
   private static final int MAX_NUM_ROWS = 5000;
   private static final int DEFAULT_TIMEOUT_MS = 10000;
 
+
+
   private final int numRows;
   private final int timeoutMs;
 
+  private final long maxBytesInMemory;
+
+  private final long maxClientResponseBytes;
+
   @JsonCreator
   public SamplerConfig(
-      @JsonProperty("numRows") Integer numRows,
-      @JsonProperty("timeoutMs") Integer timeoutMs
+      @JsonProperty("numRows") @Nullable Integer numRows,
+      @JsonProperty("timeoutMs") @Nullable Integer timeoutMs,
+      @JsonProperty("maxBytesInMemory") @Nullable Long maxBytesInMemory,
+      @JsonProperty("maxClientResponseBytes") @Nullable Long maxClientResponseBytes

Review Comment:
   yeah, that seems reasonable, forgot about that thing 👍 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org