[jira] [Commented] (ISIS-1029) Hidden{where} in layout is not honored by table representations

["Dan Haywood (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/ISIS-1029?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14312511#comment-14312511 ] 

Dan Haywood commented on ISIS-1029:
-----------------------------------

The issue is that, because @PropertyLayout, @CollectionLayout and @ActionLayout are new annotations, they actually have their own sections in the layout.json file.

So, instead of:
{code}
            "startDate": {
              "disabled": {},
              "hidden": {
                "where": "EVERYWHERE"
              },
              "typicalLength": {
                "value": 12
              }
            },
{code}

it actually needs to be:
{code}
            "startDate": {
              "propertyLayout": {
                "hidden": "EVERYWHERE",
                "typicalLength": 12
              },
              // disabled() is now only available under @Property, not under @PropertyLayout
            },
{code}

and so on.
~~~~

That being said, what the ticket says that the old hidden.where isn't working, which means that the code we have to ensure backward compatibility isn't working correctly.  So I'll take a look...

> Hidden{where} in layout is not honored by table representations
> ---------------------------------------------------------------
>
>                 Key: ISIS-1029
>                 URL: https://issues.apache.org/jira/browse/ISIS-1029
>             Project: Isis
>          Issue Type: Bug
>          Components: Viewer: Wicket
>    Affects Versions: viewer-wicket-1.8.0
>            Reporter: Sander Ginn
>            Assignee: Dan Haywood
>
> On removal of all annotations and defining hidden property in the respecting layout json files, these definitions are not honored in table representations. 
> Below is an example of how I defined the layout:
> {code}
> {
>       "span": 2,
>       "memberGroups": {
>         "Dates": {
>           "members": {
>             "startDate": {
>               "disabled": {},
>               "hidden": {
>                 "where": "EVERYWHERE"
>               },
>               "typicalLength": {
>                 "value": 12
>               }
>             },
>             "endDate": {
>               "actions": {
>                 "changeDates": {}
>               },
>               "disabled": {},
>               "hidden": {
>                 "where": "EVERYWHERE"
>               },
>               "typicalLength": {
>                 "value": 12
>               }
>             },
>             "tenancyStartDate": {
>               "disabled": {},
>               "hidden": {
>                 "where": "NOWHERE"
>               },
>               "typicalLength": {
>                 "value": 12
>               }
>             },
>             "tenancyEndDate": {
>               "disabled": {},
>               "hidden": {
>                 "where": "NOWHERE"
>               },
>               "typicalLength": {
>                 "value": 12
>               }
>             },
>             "tenancyDuration": {
>               "actions": {
>                 "changeTenancyDates": {}
>               },
>               "disabled": {},
>               "typicalLength": {
>                 "value": 25
>               }
>             }
>           }
>         }
>       }
>     }
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)