You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@weex.apache.org by YorkShen <gi...@git.apache.org> on 2017/03/17 03:14:45 UTC
[GitHub] incubator-weex pull request #124: * [Android] refactor animation
GitHub user YorkShen opened a pull request:
https://github.com/apache/incubator-weex/pull/124
* [Android] refactor animation
* Refactor animation using RenderAction and DomAction, as some public static method in WXAnimationModule has been removed, which may be a compatibility issues for some deeply involved android developer.
* Make `transformOrigin` reserve its last time state. Before this commit, transformOrigin is stateless during a sequence of animation, e.g. tranformOrigin would reset to `50%, 50%` every time if it was not given. This commit respect `transformOrigin` last time state unless it is specified this time. Developers who depends on the wrong implmentation may run into a problem.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/YorkShen/incubator-weex android_refactor_animation
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-weex/pull/124.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #124
----
commit dfb4a4ecff1f694390ff35fdef06cb50bef2e7b2
Author: YorkShen <sh...@gmail.com>
Date: 2017-03-17T01:55:50Z
* [android] Refactor Animation using RenderAction and DomAction.
commit 81f17f7a6fb995ea4b92efb46bc446b1fdd089f5
Author: YorkShen <sh...@gmail.com>
Date: 2017-03-17T02:47:47Z
* [android] Move animation from static methods to AnimationModule
commit 2240fb7f55a00991b3ac3975d3db58ef5b58b021
Author: YorkShen <sh...@gmail.com>
Date: 2017-03-17T03:01:28Z
* [Android] Fix stateless pivot, transform-origin will have last time's state.
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-weex issue #124: * [Android] refactor animation
Posted by YorkShen <gi...@git.apache.org>.
Github user YorkShen commented on the issue:
https://github.com/apache/incubator-weex/pull/124
@sospartan This should works, as I already rebase my changes.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-weex issue #124: * [Android] refactor animation
Posted by weex-bot <gi...@git.apache.org>.
Github user weex-bot commented on the issue:
https://github.com/apache/incubator-weex/pull/124
<!--
0 failure:
6 warning: Potential BREAK C..., Potential BREAK C..., Potential BREAK C..., Potential BREAK C..., Potential BREAK C..., Potential BREAK C...
-->
<table>
<thead>
<tr>
<th width="50"></th>
<th width="100%" data-danger-table="true">Warnings</th>
</tr>
</thead>
<tbody><tr>
<td>:warning:</td>
<td>Potential BREAK CHANGE. Modify public in android/sdk/src/main/java/com/taobao/weex/dom/DOMActionContextImpl.java without metion it in commit message. You'd better add 'break change' in your commit log. </td>
</tr>
<tr>
<td>:warning:</td>
<td>Potential BREAK CHANGE. Modify public in android/sdk/src/main/java/com/taobao/weex/dom/WXDomManager.java without metion it in commit message. You'd better add 'break change' in your commit log. </td>
</tr>
<tr>
<td>:warning:</td>
<td>Potential BREAK CHANGE. Modify public in android/sdk/src/main/java/com/taobao/weex/ui/RenderActionContextImpl.java without metion it in commit message. You'd better add 'break change' in your commit log. </td>
</tr>
<tr>
<td>:warning:</td>
<td>Potential BREAK CHANGE. Modify public in android/sdk/src/main/java/com/taobao/weex/ui/WXRenderManager.java without metion it in commit message. You'd better add 'break change' in your commit log. </td>
</tr>
<tr>
<td>:warning:</td>
<td>Potential BREAK CHANGE. Modify public in android/sdk/src/main/java/com/taobao/weex/ui/animation/WXAnimationBean.java without metion it in commit message. You'd better add 'break change' in your commit log. </td>
</tr>
<tr>
<td>:warning:</td>
<td>Potential BREAK CHANGE. Modify public in android/sdk/src/main/java/com/taobao/weex/ui/animation/WXAnimationModule.java without metion it in commit message. You'd better add 'break change' in your commit log. </td>
</tr>
</tbody>
</table>
<p align="right">
Generated by :no_entry_sign: <a href="http://github.com/danger/danger-js/">dangerJS</a>
</p>
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-weex issue #124: * [Android] refactor animation
Posted by sospartan <gi...@git.apache.org>.
Github user sospartan commented on the issue:
https://github.com/apache/incubator-weex/pull/124
@YorkShen pls mention 'break change' in your commit log like @weex-bot said.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-weex issue #124: * [Android] refactor animation
Posted by sospartan <gi...@git.apache.org>.
Github user sospartan commented on the issue:
https://github.com/apache/incubator-weex/pull/124
I mean 'commit message'. You'd better put the comment above to the 'commit message' like described in (this article)[https://chris.beams.io/posts/git-commit/]. And squash your commits too.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-weex pull request #124: * [Android] refactor animation
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/incubator-weex/pull/124
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---