You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@ambari.apache.org by Nate Cole <nc...@hortonworks.com> on 2017/03/02 21:01:30 UTC
Review Request 57255: Pre-Upgrade check message for disabling Auto
Start is difficult to understand and take action on
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57255/
-----------------------------------------------------------
Review request for Ambari, Dmitro Lisnichenko and Jonathan Hurley.
Bugs: AMBARI-20280
https://issues.apache.org/jira/browse/AMBARI-20280
Repository: ambari
Description
-------
Change the description for the Auto Start Disabled check.
Diffs
-----
ambari-server/src/main/java/org/apache/ambari/server/checks/CheckDescription.java 2d1468f
ambari-server/src/test/java/org/apache/ambari/server/checks/AutoStartDisabledCheckTest.java c1e2ce7
Diff: https://reviews.apache.org/r/57255/diff/1/
Testing
-------
Manual. Automated pending.
Thanks,
Nate Cole
Re: Review Request 57255: Pre-Upgrade check message for disabling
Auto Start is difficult to understand and take action on
Posted by Nate Cole <nc...@hortonworks.com>.
> On March 2, 2017, 4:04 p.m., Jonathan Hurley wrote:
> > ambari-server/src/main/java/org/apache/ambari/server/checks/CheckDescription.java
> > Lines 322 (patched)
> > <https://reviews.apache.org/r/57255/diff/1/?file=1653980#file1653980line322>
> >
> > "Turn the toggle switch off to Disabled and hit Save"
> >
> > Can we reword this to makie it clearer? Maybe, something like:
> >
> > "Disable the feature via the toggle switch and then select Save."
This is taken direct from the UI person that approved this message.
- Nate
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57255/#review167736
-----------------------------------------------------------
On March 2, 2017, 4:01 p.m., Nate Cole wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/57255/
> -----------------------------------------------------------
>
> (Updated March 2, 2017, 4:01 p.m.)
>
>
> Review request for Ambari, Dmitro Lisnichenko and Jonathan Hurley.
>
>
> Bugs: AMBARI-20280
> https://issues.apache.org/jira/browse/AMBARI-20280
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Change the description for the Auto Start Disabled check.
>
>
> Diffs
> -----
>
> ambari-server/src/main/java/org/apache/ambari/server/checks/CheckDescription.java 2d1468f
> ambari-server/src/test/java/org/apache/ambari/server/checks/AutoStartDisabledCheckTest.java c1e2ce7
>
>
> Diff: https://reviews.apache.org/r/57255/diff/1/
>
>
> Testing
> -------
>
> Manual. Automated pending.
>
>
> Thanks,
>
> Nate Cole
>
>
Re: Review Request 57255: Pre-Upgrade check message for disabling
Auto Start is difficult to understand and take action on
Posted by Jonathan Hurley <jh...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57255/#review167736
-----------------------------------------------------------
Fix it, then Ship it!
ambari-server/src/main/java/org/apache/ambari/server/checks/CheckDescription.java
Lines 322 (patched)
<https://reviews.apache.org/r/57255/#comment239657>
"Turn the toggle switch off to Disabled and hit Save"
Can we reword this to makie it clearer? Maybe, something like:
"Disable the feature via the toggle switch and then select Save."
- Jonathan Hurley
On March 2, 2017, 4:01 p.m., Nate Cole wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/57255/
> -----------------------------------------------------------
>
> (Updated March 2, 2017, 4:01 p.m.)
>
>
> Review request for Ambari, Dmitro Lisnichenko and Jonathan Hurley.
>
>
> Bugs: AMBARI-20280
> https://issues.apache.org/jira/browse/AMBARI-20280
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Change the description for the Auto Start Disabled check.
>
>
> Diffs
> -----
>
> ambari-server/src/main/java/org/apache/ambari/server/checks/CheckDescription.java 2d1468f
> ambari-server/src/test/java/org/apache/ambari/server/checks/AutoStartDisabledCheckTest.java c1e2ce7
>
>
> Diff: https://reviews.apache.org/r/57255/diff/1/
>
>
> Testing
> -------
>
> Manual. Automated pending.
>
>
> Thanks,
>
> Nate Cole
>
>