[GitHub] [skywalking] wu-sheng commented on a change in pull request #4157: Add service type from register and support browser as service type

[GitBox <gi...@apache.org>]

wu-sheng commented on a change in pull request #4157: Add service type from register and support browser as service type
URL: https://github.com/apache/skywalking/pull/4157#discussion_r362313230
 
 

 ##########
 File path: oap-server/server-core/src/main/java/org/apache/skywalking/oap/server/core/register/ServiceInventory.java
 ##########
 @@ -58,7 +58,10 @@
     @Setter @Getter @Column(columnName = NAME, matchQuery = true) private String name = Const.EMPTY_STRING;
     @Setter @Getter @Column(columnName = IS_ADDRESS) private int isAddress;
     @Setter @Getter @Column(columnName = ADDRESS_ID) private int addressId;
-    @Setter(AccessLevel.PRIVATE) @Getter(AccessLevel.PRIVATE) @Column(columnName = NODE_TYPE) private int nodeType;
+    /**
+     * Node type of the service, default {@link NodeType#Normal}
+     */
+    @Setter(AccessLevel.PRIVATE) @Getter(AccessLevel.PRIVATE) @Column(columnName = NODE_TYPE) private int nodeType = 0;
 
 Review comment:
   @kezhenxu94 As this type is int already, I think the value currently should be 0 already for all existing versions. I just change it for more clear and match the new type usage. That is all. 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services