You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@commons.apache.org by "Henri Biestro (Jira)" <ji...@apache.org> on 2023/10/19 12:01:00 UTC
[jira] [Comment Edited] (JEXL-410) JexlFeatures: ctor does not enable all features
[ https://issues.apache.org/jira/browse/JEXL-410?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17777223#comment-17777223 ]
Henri Biestro edited comment on JEXL-410 at 10/19/23 12:00 PM:
---------------------------------------------------------------
I'd rather correct the Javadoc than break production scripts.
As to why not changing the default flags (again), even enabling new more permissive ones, this is to avoid breaking upwards syntactic compatibility in a micro release. The known pitfall is the following scenario. To check 3.3.1, one may install it on a dev environment; someone 'discovers' new syntactic elements are permitted and starts using them in dev. Scripts are then moved to staging/qa (or even worse, production) environments that are still in 3.3 and failures ensue. Lesson (hard) learnt.
was (Author: henrib):
I'd rather correct the Javadoc than break production scripts.
As to why not changing the default flags (again), even enabling new more permissive ones, this is to avoid breaking upwards syntactic compatibility in a micro release. The known pitfall is the following scenario. To check 3.3.1, one may install it on a dev environment; someone 'discovers' new syntactic elements are permitted and starts using them in dev. Scripts are then moved to staging/qa (or even worse, production) environments that are still in 3.3 and failures ensues. Lesson (hard) learnt.
> JexlFeatures: ctor does not enable all features
> -----------------------------------------------
>
> Key: JEXL-410
> URL: https://issues.apache.org/jira/browse/JEXL-410
> Project: Commons JEXL
> Issue Type: Bug
> Affects Versions: 3.3
> Reporter: Sebb
> Assignee: Henri Biestro
> Priority: Major
> Fix For: 3.3.1
>
>
> The ctor Javadoc says it "Creates an all-features-enabled instance."
> However, that is not the case, as several flags are not included:
> REGISTER
> LEXICAL
> LEXICAL_SHADE
> FAT_ARROW
> CONST_CAPTURE
> (RESERVED is also omitted, but it is not a feature flag - it only indicates reservedNames is non-empty)
> If these are intentional omissions, they should be documented as such.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)