You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@datasketches.apache.org by jm...@apache.org on 2020/02/19 23:07:15 UTC
[incubator-datasketches-cpp] branch hll_single_estimate_call
created (now e7ac6ff)
This is an automated email from the ASF dual-hosted git repository.
jmalkin pushed a change to branch hll_single_estimate_call
in repository https://gitbox.apache.org/repos/asf/incubator-datasketches-cpp.git.
at e7ac6ff expose only hll's get_estimate() method in python warpper
This branch includes the following new commits:
new b97c76c Merge branch 'master' of github.com:/apache/incubator-datasketches-cpp into varopt_cleanup
new 333b21f Merge branch 'master' of github.com:/apache/incubator-datasketches-cpp into hll_single_estimate_call
new e7ac6ff expose only hll's get_estimate() method in python warpper
The 3 revisions listed above as "new" are entirely new to this
repository and will be described in separate emails. The revisions
listed as "add" were already present in the repository and have only
been added to this reference.
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@datasketches.apache.org
For additional commands, e-mail: commits-help@datasketches.apache.org
[incubator-datasketches-cpp] 02/03: Merge branch 'master' of
github.com:/apache/incubator-datasketches-cpp into hll_single_estimate_call
Posted by jm...@apache.org.
This is an automated email from the ASF dual-hosted git repository.
jmalkin pushed a commit to branch hll_single_estimate_call
in repository https://gitbox.apache.org/repos/asf/incubator-datasketches-cpp.git
commit 333b21fbb16b08b9525fd878337d7aea0e5e5360
Merge: b97c76c 5a5b168
Author: Jon Malkin <jm...@users.noreply.github.com>
AuthorDate: Wed Feb 19 13:39:17 2020 -0800
Merge branch 'master' of github.com:/apache/incubator-datasketches-cpp into hll_single_estimate_call
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@datasketches.apache.org
For additional commands, e-mail: commits-help@datasketches.apache.org
[incubator-datasketches-cpp] 01/03: Merge branch 'master' of
github.com:/apache/incubator-datasketches-cpp into varopt_cleanup
Posted by jm...@apache.org.
This is an automated email from the ASF dual-hosted git repository.
jmalkin pushed a commit to branch hll_single_estimate_call
in repository https://gitbox.apache.org/repos/asf/incubator-datasketches-cpp.git
commit b97c76c88f8796aa576fd4ccaefea10590fe1bc0
Merge: 6bf8b14 5fd701f
Author: Jon Malkin <jm...@users.noreply.github.com>
AuthorDate: Wed Feb 19 13:25:00 2020 -0800
Merge branch 'master' of github.com:/apache/incubator-datasketches-cpp into varopt_cleanup
hll/include/HllUnion-internal.hpp | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@datasketches.apache.org
For additional commands, e-mail: commits-help@datasketches.apache.org
[incubator-datasketches-cpp] 03/03: expose only hll's
get_estimate() method in python warpper
Posted by jm...@apache.org.
This is an automated email from the ASF dual-hosted git repository.
jmalkin pushed a commit to branch hll_single_estimate_call
in repository https://gitbox.apache.org/repos/asf/incubator-datasketches-cpp.git
commit e7ac6ffa4c7a05b3cc1ac871c55acc05fac73645
Author: Jon Malkin <jm...@users.noreply.github.com>
AuthorDate: Wed Feb 19 15:06:57 2020 -0800
expose only hll's get_estimate() method in python warpper
---
python/src/hll_wrapper.cpp | 2 --
python/tests/hll_test.py | 7 -------
2 files changed, 9 deletions(-)
diff --git a/python/src/hll_wrapper.cpp b/python/src/hll_wrapper.cpp
index 24b3530..cd57d15 100644
--- a/python/src/hll_wrapper.cpp
+++ b/python/src/hll_wrapper.cpp
@@ -84,7 +84,6 @@ void init_hll(py::module &m) {
.def_property_readonly("lg_config_k", &hll_sketch::get_lg_config_k)
.def_property_readonly("tgt_type", &hll_sketch::get_target_type)
.def("get_estimate", &hll_sketch::get_estimate)
- .def("get_composite_estimate", &hll_sketch::get_composite_estimate)
.def("get_lower_bound", &hll_sketch::get_lower_bound, py::arg("num_std_devs"))
.def("get_upper_bound", &hll_sketch::get_upper_bound, py::arg("num_std_devs"))
.def("is_compact", &hll_sketch::is_compact)
@@ -113,7 +112,6 @@ void init_hll(py::module &m) {
.def_property_readonly("lg_config_k", &hll_union::get_lg_config_k)
.def_property_readonly("tgt_type", &hll_union::get_target_type)
.def("get_estimate", &hll_union::get_estimate)
- .def("get_composite_estimate", &hll_union::get_composite_estimate)
.def("get_lower_bound", &hll_union::get_lower_bound, py::arg("num_std_devs"))
.def("get_upper_bound", &hll_union::get_upper_bound, py::arg("num_std_devs"))
.def("is_compact", &hll_union::is_compact)
diff --git a/python/tests/hll_test.py b/python/tests/hll_test.py
index 0fb727e..9403362 100644
--- a/python/tests/hll_test.py
+++ b/python/tests/hll_test.py
@@ -34,9 +34,6 @@ class HllTest(unittest.TestCase):
hll.update(i)
hll2.update(i + offset)
- # although we provide get_composite_estimate() and get_estimate(),
- # the latter will always give the best available estimate. we
- # recommend using get_estimate().
# we can check that the upper and lower bounds bracket the
# estimate, without needing to know the exact value.
self.assertLessEqual(hll.get_lower_bound(1), hll.get_estimate())
@@ -78,9 +75,7 @@ class HllTest(unittest.TestCase):
hll.update(3.14159) # double data
self.assertLessEqual(hll.get_lower_bound(1), hll.get_estimate())
- self.assertLessEqual(hll.get_lower_bound(1), hll.get_composite_estimate())
self.assertGreaterEqual(hll.get_upper_bound(1), hll.get_estimate())
- self.assertGreaterEqual(hll.get_upper_bound(1), hll.get_composite_estimate())
self.assertEqual(hll.lg_config_k, k)
self.assertEqual(hll.tgt_type, tgt_hll_type.HLL_6)
@@ -115,9 +110,7 @@ class HllTest(unittest.TestCase):
union.update(1.4142136)
self.assertLessEqual(union.get_lower_bound(1), union.get_estimate())
- self.assertLessEqual(union.get_lower_bound(1), union.get_composite_estimate())
self.assertGreaterEqual(union.get_upper_bound(1), union.get_estimate())
- self.assertGreaterEqual(union.get_upper_bound(1), union.get_composite_estimate())
self.assertEqual(union.lg_config_k, k)
self.assertFalse(union.is_compact())
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@datasketches.apache.org
For additional commands, e-mail: commits-help@datasketches.apache.org