[jira] [Commented] (SOLR-13650) Support for named global classloaders

["David Wayne Smiley (Jira)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/SOLR-13650?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16942485#comment-16942485 ] 

David Wayne Smiley commented on SOLR-13650:
-------------------------------------------

Seeing 9 commits on this issue to master suggests more care is needed in your dev practices Noble.  Mistakes happen, sometimes we overlook tests/precommit, but 9?  And some changed files were merely re-arrangements to import statements that are to Lucene code.  Please.  FWIW I use IntelliJ which presents a commit dialog/window with each file about to be committed, which is a juncture I use to fastidiously review each one to see that everything looks in order.  Sometimes I make mistakes as we all do but this self-review step helps.  If the work was WIP initially then consider a feature branch / PR instead and then squash at the end.

Also this was committed to 8x so shouldn't this be marked as Resolved to 8.3?

I took a look around at these commits.  I see you renamed "runtimelib" to "package" in cluster.Commands.json.  Curious; does this merely un/re-document the functionality as seen via introspection  in v2 or did it actually remove commands that used to work?

The CHANGES.txt talks of "packages" being a new thing yet the title of this issue is about named global classloaders.  So...?  This contributes to me being lost sometimes.  The design doc is good to the level of detail it goes but these JIRA issues and what was committed to what branch(s) and sometimes merged over to another is hard for me to decipher and thus delays my review. :-(

> Support for named global classloaders
> -------------------------------------
>
>                 Key: SOLR-13650
>                 URL: https://issues.apache.org/jira/browse/SOLR-13650
>             Project: Solr
>          Issue Type: Sub-task
>      Security Level: Public(Default Security Level. Issues are Public) 
>            Reporter: Noble Paul
>            Assignee: Noble Paul
>            Priority: Major
>              Labels: package
>          Time Spent: 20m
>  Remaining Estimate: 0h
>
> {code:json}
> curl -X POST -H 'Content-type:application/json' --data-binary '
> {
>   "add-package": {
>        "name": "my-package" ,
>       "sha512":"<the-sha512>"
>   }
> }' http://localhost:8983/api/cluster
> {code}
> This means that Solr creates a globally accessible classloader with a name {{my-package}} which contains all the jars of that package. 
>  A component should be able to use the package by using the {{"package" : "my-package"}}.
>  eg:
> {code:json}
> curl -X POST -H 'Content-type:application/json' --data-binary '
> {
>   "create-searchcomponent": {
>       "name": "my-searchcomponent" ,
>       "class" : "my.path.to.ClassName",
>      "package" : "my-package"
>   }
> }' http://localhost:8983/api/c/mycollection/config 
> {code}



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org