[GitHub] [kafka] showuon commented on a diff in pull request #13037: MINOR: make sure all partition info is propagated

[GitBox <gi...@apache.org>]

showuon commented on code in PR #13037:
URL: https://github.com/apache/kafka/pull/13037#discussion_r1055995690


##########
core/src/test/scala/unit/kafka/utils/TestUtils.scala:
##########
@@ -452,6 +452,7 @@ object TestUtils extends Logging {
     } catch {
       case e: ExecutionException => if (!(e.getCause != null &&

Review Comment:
   Yes, I have the same confusion at first. But look again, it'll find there is a (not)! in front of the whole condition. That is:
   **!** (e.getCause != null &&
             e.getCause.isInstanceOf[TopicExistsException] &&
             !waitForAllPartitionsMetadata(brokers, topic, effectiveNumPartitions).isEmpty &&
             topicHasSameNumPartitionsAndReplicationFactor(admin, topic,
               effectiveNumPartitions, replicationFactor)
   )



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org