You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@commons.apache.org by ju...@apache.org on 2013/01/08 01:01:55 UTC
svn commit: r1430097 - in
/commons/proper/compress/trunk/src/main/java/org/apache/commons/compress/archivers/zip:
ZipEightByteInteger.java ZipLong.java ZipShort.java
Author: julius
Date: Tue Jan 8 00:01:55 2013
New Revision: 1430097
URL: http://svn.apache.org/viewvc?rev=1430097&view=rev
Log:
COMPRESS-213 - ZipShort, ZipLong, ZipEightByteInteger should implement Serializable
Modified:
commons/proper/compress/trunk/src/main/java/org/apache/commons/compress/archivers/zip/ZipEightByteInteger.java
commons/proper/compress/trunk/src/main/java/org/apache/commons/compress/archivers/zip/ZipLong.java
commons/proper/compress/trunk/src/main/java/org/apache/commons/compress/archivers/zip/ZipShort.java
Modified: commons/proper/compress/trunk/src/main/java/org/apache/commons/compress/archivers/zip/ZipEightByteInteger.java
URL: http://svn.apache.org/viewvc/commons/proper/compress/trunk/src/main/java/org/apache/commons/compress/archivers/zip/ZipEightByteInteger.java?rev=1430097&r1=1430096&r2=1430097&view=diff
==============================================================================
--- commons/proper/compress/trunk/src/main/java/org/apache/commons/compress/archivers/zip/ZipEightByteInteger.java (original)
+++ commons/proper/compress/trunk/src/main/java/org/apache/commons/compress/archivers/zip/ZipEightByteInteger.java Tue Jan 8 00:01:55 2013
@@ -17,6 +17,7 @@
*/
package org.apache.commons.compress.archivers.zip;
+import java.io.Serializable;
import java.math.BigInteger;
import static org.apache.commons.compress.archivers.zip.ZipConstants.BYTE_MASK;
@@ -28,7 +29,8 @@ import static org.apache.commons.compres
*
* @since 1.2
*/
-public final class ZipEightByteInteger {
+public final class ZipEightByteInteger implements Serializable {
+ private static final long serialVersionUID = 1L;
private static final int BYTE_1 = 1;
private static final int BYTE_1_MASK = 0xFF00;
Modified: commons/proper/compress/trunk/src/main/java/org/apache/commons/compress/archivers/zip/ZipLong.java
URL: http://svn.apache.org/viewvc/commons/proper/compress/trunk/src/main/java/org/apache/commons/compress/archivers/zip/ZipLong.java?rev=1430097&r1=1430096&r2=1430097&view=diff
==============================================================================
--- commons/proper/compress/trunk/src/main/java/org/apache/commons/compress/archivers/zip/ZipLong.java (original)
+++ commons/proper/compress/trunk/src/main/java/org/apache/commons/compress/archivers/zip/ZipLong.java Tue Jan 8 00:01:55 2013
@@ -17,6 +17,8 @@
*/
package org.apache.commons.compress.archivers.zip;
+import java.io.Serializable;
+
import static org.apache.commons.compress.archivers.zip.ZipConstants.BYTE_MASK;
import static org.apache.commons.compress.archivers.zip.ZipConstants.WORD;
@@ -25,7 +27,8 @@ import static org.apache.commons.compres
* rules for the big endian byte order of ZIP files.
* @Immutable
*/
-public final class ZipLong implements Cloneable {
+public final class ZipLong implements Cloneable, Serializable {
+ private static final long serialVersionUID = 1L;
//private static final int BYTE_BIT_SIZE = 8;
Modified: commons/proper/compress/trunk/src/main/java/org/apache/commons/compress/archivers/zip/ZipShort.java
URL: http://svn.apache.org/viewvc/commons/proper/compress/trunk/src/main/java/org/apache/commons/compress/archivers/zip/ZipShort.java?rev=1430097&r1=1430096&r2=1430097&view=diff
==============================================================================
--- commons/proper/compress/trunk/src/main/java/org/apache/commons/compress/archivers/zip/ZipShort.java (original)
+++ commons/proper/compress/trunk/src/main/java/org/apache/commons/compress/archivers/zip/ZipShort.java Tue Jan 8 00:01:55 2013
@@ -17,6 +17,8 @@
*/
package org.apache.commons.compress.archivers.zip;
+import java.io.Serializable;
+
import static org.apache.commons.compress.archivers.zip.ZipConstants.BYTE_MASK;
/**
@@ -24,7 +26,9 @@ import static org.apache.commons.compres
* rules for the big endian byte order of ZIP files.
* @Immutable
*/
-public final class ZipShort implements Cloneable {
+public final class ZipShort implements Cloneable, Serializable {
+ private static final long serialVersionUID = 1L;
+
private static final int BYTE_1_MASK = 0xFF00;
private static final int BYTE_1_SHIFT = 8;
Re: svn commit: r1430097 - in /commons/proper/compress/trunk/src/main/java/org/apache/commons/compress/archivers/zip: ZipEightByteInteger.java ZipLong.java ZipShort.java
Posted by Stefan Bodewig <bo...@apache.org>.
On 2013-01-09, Julius Davies wrote:
> On Mon, Jan 7, 2013 at 9:16 PM, Stefan Bodewig <bo...@apache.org> wrote:
>> can you please record the changes in src/chanhes/changes.xml as well -
>> and add yourself as developer to the POM if you feel like it?
> Thanks for the tip. Done!
Great, thanks
Stefan
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org
Re: svn commit: r1430097 - in /commons/proper/compress/trunk/src/main/java/org/apache/commons/compress/archivers/zip: ZipEightByteInteger.java ZipLong.java ZipShort.java
Posted by Stefan Bodewig <bo...@apache.org>.
On 2013-01-09, Julius Davies wrote:
> On Mon, Jan 7, 2013 at 9:16 PM, Stefan Bodewig <bo...@apache.org> wrote:
>> can you please record the changes in src/chanhes/changes.xml as well -
>> and add yourself as developer to the POM if you feel like it?
> Thanks for the tip. Done!
Great, thanks
Stefan
Re: svn commit: r1430097 - in /commons/proper/compress/trunk/src/main/java/org/apache/commons/compress/archivers/zip:
ZipEightByteInteger.java ZipLong.java ZipShort.java
Posted by Julius Davies <ju...@gmail.com>.
On Mon, Jan 7, 2013 at 9:16 PM, Stefan Bodewig <bo...@apache.org> wrote:
> Hi Julius,
>
> can you please record the changes in src/chanhes/changes.xml as well -
> and add yourself as developer to the POM if you feel like it?
>
> Thanks
>
> Stefan
>
Thanks for the tip. Done!
yours,
Julius
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org
Re: svn commit: r1430097 - in /commons/proper/compress/trunk/src/main/java/org/apache/commons/compress/archivers/zip: ZipEightByteInteger.java ZipLong.java ZipShort.java
Posted by Stefan Bodewig <bo...@apache.org>.
Hi Julius,
can you please record the changes in src/chanhes/changes.xml as well -
and add yourself as developer to the POM if you feel like it?
Thanks
Stefan
Re: svn commit: r1430097 - in /commons/proper/compress/trunk/src/main/java/org/apache/commons/compress/archivers/zip: ZipEightByteInteger.java ZipLong.java ZipShort.java
Posted by Stefan Bodewig <bo...@apache.org>.
Hi Julius,
can you please record the changes in src/chanhes/changes.xml as well -
and add yourself as developer to the POM if you feel like it?
Thanks
Stefan
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org