You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2022/10/15 09:31:47 UTC
[GitHub] [arrow-ballista] Dandandan opened a new pull request, #349: Implement job cancellation in UI
Dandandan opened a new pull request, #349:
URL: https://github.com/apache/arrow-ballista/pull/349
# Which issue does this PR close?
<!--
We generally require a GitHub issue to be filed for all bug fixes and enhancements and this helps us generate change logs for our releases. You can link an issue to this PR using the GitHub syntax. For example `Closes #123` indicates that this PR will close issue #123.
-->
Closes #.
# Rationale for this change
<!--
Why are you proposing this change? If this is already explained clearly in the issue then this section is not needed.
Explaining clearly why changes are proposed helps reviewers understand your changes and offer better suggestions for fixes.
-->
# What changes are included in this PR?
<!--
There is no need to duplicate the description in the issue here but it is sometimes worth providing a summary of the individual changes in this PR.
-->
# Are there any user-facing changes?
<!--
If there are user-facing changes then we may require documentation to be updated before approving the PR.
-->
<!--
If there are any breaking changes to public APIs, please add the `api change` label.
-->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-ballista] Dandandan commented on a diff in pull request #349: Implement job cancellation in UI
Posted by GitBox <gi...@apache.org>.
Dandandan commented on code in PR #349:
URL: https://github.com/apache/arrow-ballista/pull/349#discussion_r996280904
##########
ballista/ui/scheduler/src/components/Header.tsx:
##########
@@ -53,15 +53,6 @@ export const Header: React.FunctionComponent<HeaderProps> = ({
<NavBarContainer>
<Flex flexDirection={"row"} alignItems={"center"}>
<img alt={"Ballista Logo"} src={Logo} />
- <Text
Review Comment:
Seems a bit redundant, I think we can remove it here
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-ballista] andygrove merged pull request #349: Implement job cancellation in UI
Posted by GitBox <gi...@apache.org>.
andygrove merged PR #349:
URL: https://github.com/apache/arrow-ballista/pull/349
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-ballista] Dandandan commented on a diff in pull request #349: Implement job cancellation in UI
Posted by GitBox <gi...@apache.org>.
Dandandan commented on code in PR #349:
URL: https://github.com/apache/arrow-ballista/pull/349#discussion_r996281163
##########
ballista/ui/scheduler/src/components/Summary.tsx:
##########
@@ -64,7 +64,7 @@ export const Summary: React.FunctionComponent<SummaryProps> = ({
fontWeight={"normal"}
>
<Text fontWeight={"light"} mb={2}>
- General Cluster Info
+ Cluster Details
Review Comment:
Not sure if text is necessary, but "Cluster Details" seems a bit more appropriate.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-ballista] Dandandan commented on a diff in pull request #349: Implement job cancellation in UI
Posted by GitBox <gi...@apache.org>.
Dandandan commented on code in PR #349:
URL: https://github.com/apache/arrow-ballista/pull/349#discussion_r996280836
##########
ballista/ui/scheduler/src/components/QueriesList.tsx:
##########
@@ -94,13 +94,20 @@ export const ActionsCell: (props: any) => React.ReactNode = (props: any) => {
};
return (
<Flex>
- <FaStop color={"red"} title={"Stop this job"} />
+ <FaStop color={"red"} title={"Stop this job"} onClick={() => {
+ fetch("api/job/" + props.value.job_id, {
Review Comment:
This works succesfully - but has the "infinite loop" problem
https://github.com/apache/arrow-ballista/issues/341
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-ballista] Dandandan commented on a diff in pull request #349: Implement job cancellation in UI
Posted by GitBox <gi...@apache.org>.
Dandandan commented on code in PR #349:
URL: https://github.com/apache/arrow-ballista/pull/349#discussion_r996280698
##########
ballista/ui/scheduler/src/components/QueriesList.tsx:
##########
@@ -51,7 +51,7 @@ export enum QueryStatus {
export interface Query {
job_id: string;
job_name: string;
- status: QueryStatus;
+ job_status: string;
Review Comment:
Fix - current API doesn't return `status` field.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org