You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@flink.apache.org by jgrier <gi...@git.apache.org> on 2017/01/25 06:09:35 UTC

[GitHub] flink pull request #3204: [FLINK-5634] Flink should not always redirect stdo...

GitHub user jgrier opened a pull request:

    https://github.com/apache/flink/pull/3204

    [FLINK-5634] Flink should not always redirect stdout to a file.	

    Adding flag to flink-daemon.sh and related scripts so that we can actually log to the console -- which is better for Docker environments.  Also modifying Docker entrypoint to use this.
    
    There is a follow on PR with many more changes to the Docker scripts and tooling based on this one.


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/jgrier/flink no-stdout-redirect

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/flink/pull/3204.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #3204
    
----
commit 5f6a9671816a16b810990a10310f994898e9ba41
Author: Jamie Grier <ja...@gmail.com>
Date:   2017-01-21T00:14:27Z

    Adding flag to flink-daemon.sh and related scripts so that we can actually log to the console -- which is better for Docker environments.

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] flink issue #3204: [FLINK-5634] Flink should not always redirect stdout to a...

Posted by StephanEwen <gi...@git.apache.org>.

Github user StephanEwen commented on the issue:

    https://github.com/apache/flink/pull/3204
  
    I think @greghogan may be right - if the docker scripts are okay with running the Flink processes in the foreground, then https://issues.apache.org/jira/browse/FLINK-4326 seems like the more general solution.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] flink issue #3204: [FLINK-5634] Flink should not always redirect stdout to a...

Posted by iemejia <gi...@git.apache.org>.

Github user iemejia commented on the issue:

    https://github.com/apache/flink/pull/3204
  
    @greghogan Definitely a misunderstanding, I had the impression you just didn't like my solution, so I didn't continue pushing for it (even if we finished with similar ideas).
    
    For ref, Greg's PR, so someone (a committer) reviews it
    https://github.com/apache/flink/pull/3351
    
    I will move the docker scripts to use start-foreground once it is merged.



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] flink issue #3204: [FLINK-5634] Flink should not always redirect stdout to a...

Posted by jgrier <gi...@git.apache.org>.

Github user jgrier commented on the issue:

    https://github.com/apache/flink/pull/3204
  
    Agreed.. If https://issues.apache.org/jira/browse/FLINK-4326 were merged this would also work fine. Whether or not Flink runs in the background or foreground is orthogonal to where the logs go \u2013 as long as Flink can be configured to log to stdout we're good.



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] flink issue #3204: [FLINK-5634] Flink should not always redirect stdout to a...

Posted by StephanEwen <gi...@git.apache.org>.

Github user StephanEwen commented on the issue:

    https://github.com/apache/flink/pull/3204
  
    Does anyone want to take a stab at addressing this the https://issues.apache.org/jira/browse/FLINK-4326 way? I think no one is active on that issue right now...


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] flink issue #3204: [FLINK-5634] Flink should not always redirect stdout to a...

Posted by greghogan <gi...@git.apache.org>.

Github user greghogan commented on the issue:

    https://github.com/apache/flink/pull/3204
  
    In regards to FLINK-4326, should the daemon scripts called by the docker script run in the foreground or background? It seems that this PR may be unnecessary.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] flink issue #3204: [FLINK-5634] Flink should not always redirect stdout to a...

Posted by greghogan <gi...@git.apache.org>.

Github user greghogan commented on the issue:

    https://github.com/apache/flink/pull/3204
  
    This is now looking like a game of hot potato :) I'm happy to let @iemejia create the PR but he had offered the same to me. If I don't hear otherwise first I'll create a PR for FLINK-4326. While sitting down so I don't step on anyone's toes.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] flink issue #3204: [FLINK-5634] Flink should not always redirect stdout to a...

Posted by StephanEwen <gi...@git.apache.org>.

Github user StephanEwen commented on the issue:

    https://github.com/apache/flink/pull/3204
  
    Looks good to me, +1
    
    @uce the ScriptMeister should probably give his blessing as well...


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---