You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by "msyavuz (via GitHub)" <gi...@apache.org> on 2026/09/25 09:08:21 UTC
[PR] fix(table): resolve auto-detected currency on time comparison columns [superset]
msyavuz opened a new pull request, #44649:
URL: https://github.com/apache/superset/pull/44649
### SUMMARY
**Problem:** In Table and Table V2 with Time Comparison, columns using the "Auto-detect" currency render plain numbers unless the currency code column is added to the chart. `getComparisonColFormatter` built a `CurrencyFormatter` from the raw `AUTO` currency, which only resolves per row from the currency code column, while the main columns already fell back to the backend's `detected_currency`.
**Solution:** Move the detected-currency fallback into a shared `resolveDetectedCurrency` helper in `superset-ui-core/currency-format` and use it for both main and comparison columns in both table plugins, replacing the duplicated inline logic.
### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
Comparison column with AUTO currency, GBP detected, currency code column not in the chart: before `100`, after `£ 100`.
### TESTING INSTRUCTIONS
`npm run test -- currency-format/utils.test.ts plugin-chart-table/test/TableChart.test.tsx plugin-chart-ag-grid-table/test/transformProps.test.ts`
Manual: set a dataset currency code column, give a metric's Main/#/△ columns "Auto-detect" currency, enable Time Comparison without adding the currency column. The symbol now shows.
### ADDITIONAL INFORMATION
- [ ] Has associated issue: No
- [ ] Required feature flags: No
- [x] Changes UI: Yes, comparison columns now show the detected currency symbol
- [ ] Includes DB Migration: No
- [ ] Introduces new feature or API: No, adds an internal `resolveDetectedCurrency` export to `@superset-ui/core`
- [ ] Removes existing feature or API: No
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] fix(table): resolve auto-detected currency on time comparison columns [superset]
Posted by "codecov[bot] (via GitHub)" <gi...@apache.org>.
codecov[bot] commented on PR #44649:
URL: https://github.com/apache/superset/pull/44649#issuecomment-5829984842
## [Codecov](https://app.codecov.io/gh/apache/superset/pull/44649?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:white_check_mark: All modified and coverable lines are covered by tests.
:white_check_mark: Project coverage is 81.11%. Comparing base ([`599026a`](https://app.codecov.io/gh/apache/superset/commit/599026a0e5a82f9728a333aea0e07b6a7bf8f771?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`736b4e1`](https://app.codecov.io/gh/apache/superset/commit/736b4e1ce52e051ad5c6412f5823c285cd218194?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #44649 +/- ##
=======================================
Coverage 81.10% 81.11%
=======================================
Files 2955 2955
Lines 178385 178388 +3
Branches 41336 41333 -3
=======================================
+ Hits 144680 144697 +17
+ Misses 30996 30982 -14
Partials 2709 2709
```
| [Flag](https://app.codecov.io/gh/apache/superset/pull/44649/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [javascript](https://app.codecov.io/gh/apache/superset/pull/44649/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `76.49% <100.00%> (+0.01%)` | :arrow_up: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
</details>
[:umbrella: View full report in Codecov by Harness](https://app.codecov.io/gh/apache/superset/pull/44649?dropdown=coverage&src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
:loudspeaker: Have feedback on the report? [Share it here](https://about.codecov.io/codecov-pr-comment-feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
- :package: [JS Bundle Analysis](https://docs.codecov.com/docs/javascript-bundle-analysis): Save yourself from yourself by tracking and limiting bundle sizes in JS merges.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] fix(table): resolve auto-detected currency on time comparison columns [superset]
Posted by "bito-code-review[bot] (via GitHub)" <gi...@apache.org>.
bito-code-review[bot] commented on PR #44649:
URL: https://github.com/apache/superset/pull/44649#issuecomment-5829845764
AI Code Review is in progress (usually takes 3 to 15 minutes unless it's a very large PR).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] fix(table): resolve auto-detected currency on time comparison columns [superset]
Posted by "netlify[bot] (via GitHub)" <gi...@apache.org>.
netlify[bot] commented on PR #44649:
URL: https://github.com/apache/superset/pull/44649#issuecomment-5831935286
### <span aria-hidden="true">✅</span> Deploy Preview for *superset-docs-preview* ready!
| Name | Link |
|:-:|------------------------|
|<span aria-hidden="true">🔨</span> Latest commit | 453742cc7c87537a11249e50688ada7737763d09 |
|<span aria-hidden="true">🔍</span> Latest deploy log | https://app.netlify.com/projects/superset-docs-preview/deploys/6ab66058447d3800082d0074 |
|<span aria-hidden="true">😎</span> Deploy Preview | [https://deploy-preview-44649--superset-docs-preview.netlify.app](https://deploy-preview-44649--superset-docs-preview.netlify.app) |
|<span aria-hidden="true">📱</span> Preview on mobile | <details><summary> Toggle QR Code... </summary><br /><br /><br /><br />_Use your smartphone camera to open QR code link._</details> |
|<span aria-hidden="true">🤖</span> Make changes | [Run an agent on this branch](https://app.netlify.com/projects/superset-docs-preview/agent-runs#DctNDoMgEEDhu8xawqRFJL1BjzH8GEkUyAhNaePdZfcW7_tD4XyUCi-ACSxTctvo4-z0aT-5xq-sZPcg3LiI45mToFazcI05JNeH8qHsub_9cJqs1jgbpRb_NIhoHh5xUXDd) |
---
<!-- [superset-docs-preview Preview](https://deploy-preview-44649--superset-docs-preview.netlify.app) -->
_To edit notification comments on pull requests, go to your [Netlify project configuration](https://app.netlify.com/projects/superset-docs-preview/configuration/notifications#deploy-notifications)._
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] fix(table): resolve auto-detected currency on time comparison columns [superset]
Posted by "msyavuz (via GitHub)" <gi...@apache.org>.
msyavuz merged PR #44649:
URL: https://github.com/apache/superset/pull/44649
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] fix(table): resolve auto-detected currency on time comparison columns [superset]
Posted by "bito-code-review[bot] (via GitHub)" <gi...@apache.org>.
bito-code-review[bot] commented on PR #44649:
URL: https://github.com/apache/superset/pull/44649#issuecomment-5834461395
**Bito Automatic Review Skipped – PR Already Merged**<br/><br/>Bito scheduled an automatic review for this pull request, but the review was skipped because this PR was merged before the review could be run.<br/>No action is needed if you didn't intend to review it. To get a review, you can type `/review` in a comment and save it
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org