You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ofbiz.apache.org by Michael Brohl <mi...@ecomify.de> on 2015/05/06 22:57:36 UTC
Re: svn commit: r1678076 [2/3] - in /ofbiz/trunk/applications/product/config:
ProductEntityLabels.xml ProductErrorUiLabels.xml
- Posting in dev because I have no permission for commits -
Yes, thought about that recently when doing the german translations.
The drawback is that you have no overview about missing translations.
It's easy to go through the files as they are now and add missing
translations.
I quick checked the size of the *UILabels.xml files, they are about 10.2
megs for all modules - not too much for today's servers with gigabytes
of RAM.
So I think it is not worth the effort...
Michael
Am 06.05.15 um 21:50 schrieb Adam Heath:
> Well, hmm. Nothing at all wrong with this change, but I'd like to
> discuss the pattern.
>
> So, the way alternative languages are implemented, is that if I am
> only concerned with *one* language, *all* languages have to be loaded
> in memory. Wouldn't it make more sense to split all these files into
> per-language-specific versions, so that only languages that an
> end-customer needs would have to be loaded into memory?
>
> Then, the name of the file ends up using the very same fallback
> mechanism for normal *.properties resources.
>
> On 05/06/2015 02:35 PM, chrisg@apache.org wrote:
>> Modified:
>> ofbiz/trunk/applications/product/config/ProductEntityLabels.xml
>> URL:
>> http://svn.apache.org/viewvc/ofbiz/trunk/applications/product/config/ProductEntityLabels.xml?rev=1678076&r1=1678075&r2=1678076&view=diff
>> ==============================================================================
>>
>> --- ofbiz/trunk/applications/product/config/ProductEntityLabels.xml
>> (original)
>> +++ ofbiz/trunk/applications/product/config/ProductEntityLabels.xml
>> Wed May 6 19:35:24 2015
>> @@ -388,6 +388,7 @@
>> <value xml:lang="zh-TW">å庫</value>
>> </property>
>> <property key="GoodIdentificationType.description.GOOGLE_ID">
>> + <value xml:lang="de">Google Id</value>
>> <value xml:lang="en">Google Id</value>
>> <value xml:lang="it">Codice Google</value>
>> <value xml:lang="ja">Google ID</value>
>> @@ -396,6 +397,7 @@
>> <value xml:lang="zh-TW">è°·æç¨æ¶å</value>
>> </property>
>> <property key="GoodIdentificationType.description.ISBN">
>> + <value xml:lang="de">ISBN</value>
>> <value xml:lang="en">ISBN</value>
>> <value xml:lang="es">ISBN</value>
>> <value xml:lang="fr">ISBN</value>
>
Re: svn commit: r1678076 [2/3] - in /ofbiz/trunk/applications/product/config:
ProductEntityLabels.xml ProductErrorUiLabels.xml
Posted by Adam Heath <do...@brainfood.com>.
Except that byte site is not equal to in-memory site. Java doesn't use
utf-8 internally to store character data. I believe each char is 4
bytes in size. Then you have all the extra string objects with their
char array pointing into the large shared blob.
On 05/06/2015 03:57 PM, Michael Brohl wrote:
> - Posting in dev because I have no permission for commits -
>
> Yes, thought about that recently when doing the german translations.
>
> The drawback is that you have no overview about missing translations.
> It's easy to go through the files as they are now and add missing
> translations.
>
> I quick checked the size of the *UILabels.xml files, they are about
> 10.2 megs for all modules - not too much for today's servers with
> gigabytes of RAM.
>
> So I think it is not worth the effort...
>
> Michael
>
> Am 06.05.15 um 21:50 schrieb Adam Heath:
>> Well, hmm. Nothing at all wrong with this change, but I'd like to
>> discuss the pattern.
>>
>> So, the way alternative languages are implemented, is that if I am
>> only concerned with *one* language, *all* languages have to be loaded
>> in memory. Wouldn't it make more sense to split all these files into
>> per-language-specific versions, so that only languages that an
>> end-customer needs would have to be loaded into memory?
>>
>> Then, the name of the file ends up using the very same fallback
>> mechanism for normal *.properties resources.
>>
>> On 05/06/2015 02:35 PM, chrisg@apache.org wrote:
>>> Modified:
>>> ofbiz/trunk/applications/product/config/ProductEntityLabels.xml
>>> URL:
>>> http://svn.apache.org/viewvc/ofbiz/trunk/applications/product/config/ProductEntityLabels.xml?rev=1678076&r1=1678075&r2=1678076&view=diff
>>>
>>> ==============================================================================
>>>
>>>
>>> --- ofbiz/trunk/applications/product/config/ProductEntityLabels.xml
>>> (original)
>>> +++ ofbiz/trunk/applications/product/config/ProductEntityLabels.xml
>>> Wed May 6 19:35:24 2015
>>> @@ -388,6 +388,7 @@
>>> <value xml:lang="zh-TW">å庫</value>
>>> </property>
>>> <property key="GoodIdentificationType.description.GOOGLE_ID">
>>> + <value xml:lang="de">Google Id</value>
>>> <value xml:lang="en">Google Id</value>
>>> <value xml:lang="it">Codice Google</value>
>>> <value xml:lang="ja">Google ID</value>
>>> @@ -396,6 +397,7 @@
>>> <value xml:lang="zh-TW">è°·æç¨æ¶å</value>
>>> </property>
>>> <property key="GoodIdentificationType.description.ISBN">
>>> + <value xml:lang="de">ISBN</value>
>>> <value xml:lang="en">ISBN</value>
>>> <value xml:lang="es">ISBN</value>
>>> <value xml:lang="fr">ISBN</value>
>>
>
>
>
Re: svn commit: r1678076 [2/3] - in /ofbiz/trunk/applications/product/config:
ProductEntityLabels.xml ProductErrorUiLabels.xml
Posted by Nicolas Malin <ni...@nereide.fr>.
Maybe it's possible to load only locale define on common.properties
nicolas
Le 07/05/2015 00:08, Christian Geisert a écrit :
> Hehe, this has already been discussed when switching to from .properties
> to .xml
>
> See https://issues.apache.org/jira/browse/OFBIZ-1442
>
> And I was against this change (with size as one argument against it) ...
> but meanwhile I like this format ;-)
>
> Christian
>
> Am 06.05.2015 22:57, schrieb Michael Brohl:
>> - Posting in dev because I have no permission for commits -
>>
>> Yes, thought about that recently when doing the german translations.
>>
>> The drawback is that you have no overview about missing translations.
>> It's easy to go through the files as they are now and add missing
>> translations.
>>
>> I quick checked the size of the *UILabels.xml files, they are about
>> 10.2 megs for all modules - not too much for today's servers with
>> gigabytes of RAM.
>>
>> So I think it is not worth the effort...
>>
>> Michael
>>
>> Am 06.05.15 um 21:50 schrieb Adam Heath:
>>> Well, hmm. Nothing at all wrong with this change, but I'd like to
>>> discuss the pattern.
>>>
>>> So, the way alternative languages are implemented, is that if I am
>>> only concerned with *one* language, *all* languages have to be loaded
>>> in memory. Wouldn't it make more sense to split all these files into
>>> per-language-specific versions, so that only languages that an
>>> end-customer needs would have to be loaded into memory?
>>>
>>> Then, the name of the file ends up using the very same fallback
>>> mechanism for normal *.properties resources.
>>>
>>> On 05/06/2015 02:35 PM, chrisg@apache.org wrote:
>>>> Modified:
>>>> ofbiz/trunk/applications/product/config/ProductEntityLabels.xml
>>>> URL:
>>>> http://svn.apache.org/viewvc/ofbiz/trunk/applications/product/config/ProductEntityLabels.xml?rev=1678076&r1=1678075&r2=1678076&view=diff
>>>>
>>>> ==============================================================================
>>>>
>>>>
>>>> --- ofbiz/trunk/applications/product/config/ProductEntityLabels.xml
>>>> (original)
>>>> +++ ofbiz/trunk/applications/product/config/ProductEntityLabels.xml
>>>> Wed May 6 19:35:24 2015
>>>> @@ -388,6 +388,7 @@
>>>> <value xml:lang="zh-TW">å庫</value>
>>>> </property>
>>>> <property key="GoodIdentificationType.description.GOOGLE_ID">
>>>> + <value xml:lang="de">Google Id</value>
>>>> <value xml:lang="en">Google Id</value>
>>>> <value xml:lang="it">Codice Google</value>
>>>> <value xml:lang="ja">Google ID</value>
>>>> @@ -396,6 +397,7 @@
>>>> <value xml:lang="zh-TW">è°·æç¨æ¶å</value>
>>>> </property>
>>>> <property key="GoodIdentificationType.description.ISBN">
>>>> + <value xml:lang="de">ISBN</value>
>>>> <value xml:lang="en">ISBN</value>
>>>> <value xml:lang="es">ISBN</value>
>>>> <value xml:lang="fr">ISBN</value>
>>
>>
Re: svn commit: r1678076 [2/3] - in /ofbiz/trunk/applications/product/config:
ProductEntityLabels.xml ProductErrorUiLabels.xml
Posted by Christian Geisert <ch...@isu-gmbh.de>.
Hehe, this has already been discussed when switching to from .properties
to .xml
See https://issues.apache.org/jira/browse/OFBIZ-1442
And I was against this change (with size as one argument against it) ...
but meanwhile I like this format ;-)
Christian
Am 06.05.2015 22:57, schrieb Michael Brohl:
> - Posting in dev because I have no permission for commits -
>
> Yes, thought about that recently when doing the german translations.
>
> The drawback is that you have no overview about missing translations.
> It's easy to go through the files as they are now and add missing
> translations.
>
> I quick checked the size of the *UILabels.xml files, they are about
> 10.2 megs for all modules - not too much for today's servers with
> gigabytes of RAM.
>
> So I think it is not worth the effort...
>
> Michael
>
> Am 06.05.15 um 21:50 schrieb Adam Heath:
>> Well, hmm. Nothing at all wrong with this change, but I'd like to
>> discuss the pattern.
>>
>> So, the way alternative languages are implemented, is that if I am
>> only concerned with *one* language, *all* languages have to be loaded
>> in memory. Wouldn't it make more sense to split all these files into
>> per-language-specific versions, so that only languages that an
>> end-customer needs would have to be loaded into memory?
>>
>> Then, the name of the file ends up using the very same fallback
>> mechanism for normal *.properties resources.
>>
>> On 05/06/2015 02:35 PM, chrisg@apache.org wrote:
>>> Modified:
>>> ofbiz/trunk/applications/product/config/ProductEntityLabels.xml
>>> URL:
>>> http://svn.apache.org/viewvc/ofbiz/trunk/applications/product/config/ProductEntityLabels.xml?rev=1678076&r1=1678075&r2=1678076&view=diff
>>>
>>> ==============================================================================
>>>
>>>
>>> --- ofbiz/trunk/applications/product/config/ProductEntityLabels.xml
>>> (original)
>>> +++ ofbiz/trunk/applications/product/config/ProductEntityLabels.xml
>>> Wed May 6 19:35:24 2015
>>> @@ -388,6 +388,7 @@
>>> <value xml:lang="zh-TW">å庫</value>
>>> </property>
>>> <property key="GoodIdentificationType.description.GOOGLE_ID">
>>> + <value xml:lang="de">Google Id</value>
>>> <value xml:lang="en">Google Id</value>
>>> <value xml:lang="it">Codice Google</value>
>>> <value xml:lang="ja">Google ID</value>
>>> @@ -396,6 +397,7 @@
>>> <value xml:lang="zh-TW">è°·æç¨æ¶å</value>
>>> </property>
>>> <property key="GoodIdentificationType.description.ISBN">
>>> + <value xml:lang="de">ISBN</value>
>>> <value xml:lang="en">ISBN</value>
>>> <value xml:lang="es">ISBN</value>
>>> <value xml:lang="fr">ISBN</value>
>>
>
>
>