[jira] [Closed] (ARROW-10973) [Rust] Document use of unsafe in compute kernels

["Andrew Lamb (Jira)" <ji...@apache.org>]

     [ https://issues.apache.org/jira/browse/ARROW-10973?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Andrew Lamb closed ARROW-10973.
-------------------------------
    Resolution: Invalid

> [Rust] Document use of unsafe in compute kernels
> ------------------------------------------------
>
>                 Key: ARROW-10973
>                 URL: https://issues.apache.org/jira/browse/ARROW-10973
>             Project: Apache Arrow
>          Issue Type: Sub-task
>          Components: Rust
>            Reporter: Andy Grove
>            Priority: Major
>
> There are ~7 uses of unsafe in the compute kernels and we should document them according to the guidelines in the Arrow crate README
>  
> {code:java}
> // JUSTIFICATION
> //  Benefit
> //      Describe the benefit of using unsafe. E.g.
> //      "30% performance degradation if the safe counterpart is used, see bench X."
> //  Soundness
> //      Describe why the code remains sound (according to the definition of rust's unsafe code guidelines). E.g.
> //      "We bounded check these values at initialization and the array is immutable."
> let ... = unsafe { ... }; {code}



--
This message was sent by Atlassian Jira
(v8.3.4#803005)