You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@oodt.apache.org by "Brian Foster (Created) (JIRA)" <ji...@apache.org> on 2012/03/16 03:11:38 UTC

[jira] [Created] (OODT-414) Create Java Logger Handler for CAS-PGE

Create Java Logger Handler for CAS-PGE
--------------------------------------

                 Key: OODT-414
                 URL: https://issues.apache.org/jira/browse/OODT-414
             Project: OODT
          Issue Type: Sub-task
          Components: pge wrapper framework
    Affects Versions: 0.3
         Environment: none
            Reporter: Brian Foster
            Assignee: Brian Foster
            Priority: Minor
             Fix For: 0.4
         Attachments: OODT-415.2012-03-15.patch.txt

This handler will allow for multiple CAS-PGE instances to exist in the same JVM while routing the logging from each to their own log files in their execution directory

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (OODT-414) Create Java Logger Handler for CAS-PGE

Posted by "jiraposter@reviews.apache.org (Commented) (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/OODT-414?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13231500#comment-13231500 ] 

jiraposter@reviews.apache.org commented on OODT-414:
----------------------------------------------------



bq.  On 2012-03-16 14:28:24, Chris Mattmann wrote:
bq.  > trunk/pge/src/test/org/apache/oodt/cas/pge/TestPGETaskInstance.java, line 108
bq.  > <https://reviews.apache.org/r/4375/diff/2/?file=93053#file93053line108>
bq.  >
bq.  >     what makes this throw an exception now?

I'm gradually adding "throws Exception" to all the methods in CAS-PGE's PGETaskInstance so if they are overridden by the extending class, the extending class can easily kill CAS-PGE (and give the reason why it should stop) by just throwing any Exception


- brian


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/4375/#review6035
-----------------------------------------------------------


On 2012-03-16 08:25:17, brian Foster wrote:
bq.  
bq.  -----------------------------------------------------------
bq.  This is an automatically generated e-mail. To reply, visit:
bq.  https://reviews.apache.org/r/4375/
bq.  -----------------------------------------------------------
bq.  
bq.  (Updated 2012-03-16 08:25:17)
bq.  
bq.  
bq.  Review request for oodt, Chris Mattmann, Ricky Nguyen, Paul Ramirez, and Thomas Bennett.
bq.  
bq.  
bq.  Summary
bq.  -------
bq.  
bq.  This handler will allow for multiple CAS-PGE instances to exist in the same JVM while routing the logging from each to their own log files in their execution directory
bq.  
bq.  -----
bq.  This patch also includes:
bq.   - adding support for PgeMetadata to take PgeTaskMetKeys directly
bq.   - some cleanup and reorganizing of PgeTaskInstance
bq.  
bq.  
bq.  This addresses bug OODT-414.
bq.      https://issues.apache.org/jira/browse/OODT-414
bq.  
bq.  
bq.  Diffs
bq.  -----
bq.  
bq.    trunk/pge/src/main/java/org/apache/oodt/cas/pge/PGETaskInstance.java 1301267 
bq.    trunk/pge/src/main/java/org/apache/oodt/cas/pge/logging/PgeLogHandler.java PRE-CREATION 
bq.    trunk/pge/src/main/java/org/apache/oodt/cas/pge/logging/PgeLogRecord.java PRE-CREATION 
bq.    trunk/pge/src/main/java/org/apache/oodt/cas/pge/metadata/PgeMetadata.java 1300798 
bq.    trunk/pge/src/main/java/org/apache/oodt/cas/pge/metadata/PgeTaskMetKeys.java 1301267 
bq.    trunk/pge/src/test/org/apache/oodt/cas/pge/TestPGETaskInstance.java 1301267 
bq.    trunk/pge/src/test/org/apache/oodt/cas/pge/logging/TestPgeLogHandler.java PRE-CREATION 
bq.  
bq.  Diff: https://reviews.apache.org/r/4375/diff
bq.  
bq.  
bq.  Testing
bq.  -------
bq.  
bq.  Added and updated unit-tests
bq.  
bq.  
bq.  Thanks,
bq.  
bq.  brian
bq.  
bq.


                
> Create Java Logger Handler for CAS-PGE
> --------------------------------------
>
>                 Key: OODT-414
>                 URL: https://issues.apache.org/jira/browse/OODT-414
>             Project: OODT
>          Issue Type: Sub-task
>          Components: pge wrapper framework
>    Affects Versions: 0.3
>         Environment: none
>            Reporter: Brian Foster
>            Assignee: Brian Foster
>            Priority: Minor
>             Fix For: 0.4
>
>         Attachments: OODT-414.2012-03-15.txt
>
>
> This handler will allow for multiple CAS-PGE instances to exist in the same JVM while routing the logging from each to their own log files in their execution directory

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (OODT-414) Create Java Logger Handler for CAS-PGE

Posted by "jiraposter@reviews.apache.org (Commented) (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/OODT-414?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13231235#comment-13231235 ] 

jiraposter@reviews.apache.org commented on OODT-414:
----------------------------------------------------


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/4375/#review6035
-----------------------------------------------------------



trunk/pge/src/main/java/org/apache/oodt/cas/pge/PGETaskInstance.java
<https://reviews.apache.org/r/4375/#comment13014>

    I like this having an explicit step now.



trunk/pge/src/test/org/apache/oodt/cas/pge/TestPGETaskInstance.java
<https://reviews.apache.org/r/4375/#comment13015>

    what makes this throw an exception now?


- Chris


On 2012-03-16 08:25:17, brian Foster wrote:
bq.  
bq.  -----------------------------------------------------------
bq.  This is an automatically generated e-mail. To reply, visit:
bq.  https://reviews.apache.org/r/4375/
bq.  -----------------------------------------------------------
bq.  
bq.  (Updated 2012-03-16 08:25:17)
bq.  
bq.  
bq.  Review request for oodt, Chris Mattmann, Ricky Nguyen, Paul Ramirez, and Thomas Bennett.
bq.  
bq.  
bq.  Summary
bq.  -------
bq.  
bq.  This handler will allow for multiple CAS-PGE instances to exist in the same JVM while routing the logging from each to their own log files in their execution directory
bq.  
bq.  -----
bq.  This patch also includes:
bq.   - adding support for PgeMetadata to take PgeTaskMetKeys directly
bq.   - some cleanup and reorganizing of PgeTaskInstance
bq.  
bq.  
bq.  This addresses bug OODT-414.
bq.      https://issues.apache.org/jira/browse/OODT-414
bq.  
bq.  
bq.  Diffs
bq.  -----
bq.  
bq.    trunk/pge/src/main/java/org/apache/oodt/cas/pge/PGETaskInstance.java 1301267 
bq.    trunk/pge/src/main/java/org/apache/oodt/cas/pge/logging/PgeLogHandler.java PRE-CREATION 
bq.    trunk/pge/src/main/java/org/apache/oodt/cas/pge/logging/PgeLogRecord.java PRE-CREATION 
bq.    trunk/pge/src/main/java/org/apache/oodt/cas/pge/metadata/PgeMetadata.java 1300798 
bq.    trunk/pge/src/main/java/org/apache/oodt/cas/pge/metadata/PgeTaskMetKeys.java 1301267 
bq.    trunk/pge/src/test/org/apache/oodt/cas/pge/TestPGETaskInstance.java 1301267 
bq.    trunk/pge/src/test/org/apache/oodt/cas/pge/logging/TestPgeLogHandler.java PRE-CREATION 
bq.  
bq.  Diff: https://reviews.apache.org/r/4375/diff
bq.  
bq.  
bq.  Testing
bq.  -------
bq.  
bq.  Added and updated unit-tests
bq.  
bq.  
bq.  Thanks,
bq.  
bq.  brian
bq.  
bq.


                
> Create Java Logger Handler for CAS-PGE
> --------------------------------------
>
>                 Key: OODT-414
>                 URL: https://issues.apache.org/jira/browse/OODT-414
>             Project: OODT
>          Issue Type: Sub-task
>          Components: pge wrapper framework
>    Affects Versions: 0.3
>         Environment: none
>            Reporter: Brian Foster
>            Assignee: Brian Foster
>            Priority: Minor
>             Fix For: 0.4
>
>         Attachments: OODT-414.2012-03-15.txt
>
>
> This handler will allow for multiple CAS-PGE instances to exist in the same JVM while routing the logging from each to their own log files in their execution directory

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Updated] (OODT-414) Create Java Logger Handler for CAS-PGE

Posted by "Brian Foster (Updated) (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/OODT-414?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Brian Foster updated OODT-414:
------------------------------

    Attachment: OODT-414.2012-03-15.txt
    
> Create Java Logger Handler for CAS-PGE
> --------------------------------------
>
>                 Key: OODT-414
>                 URL: https://issues.apache.org/jira/browse/OODT-414
>             Project: OODT
>          Issue Type: Sub-task
>          Components: pge wrapper framework
>    Affects Versions: 0.3
>         Environment: none
>            Reporter: Brian Foster
>            Assignee: Brian Foster
>            Priority: Minor
>             Fix For: 0.4
>
>         Attachments: OODT-414.2012-03-15.txt
>
>
> This handler will allow for multiple CAS-PGE instances to exist in the same JVM while routing the logging from each to their own log files in their execution directory

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (OODT-414) Create Java Logger Handler for CAS-PGE

Posted by "jiraposter@reviews.apache.org (Commented) (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/OODT-414?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13230970#comment-13230970 ] 

jiraposter@reviews.apache.org commented on OODT-414:
----------------------------------------------------


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/4375/
-----------------------------------------------------------

(Updated 2012-03-16 08:25:17.505045)


Review request for oodt, Chris Mattmann, Ricky Nguyen, Paul Ramirez, and Thomas Bennett.


Changes
-------

Updated to use new methods in oodt-commons ExecUtils


Summary
-------

This handler will allow for multiple CAS-PGE instances to exist in the same JVM while routing the logging from each to their own log files in their execution directory

-----
This patch also includes:
 - adding support for PgeMetadata to take PgeTaskMetKeys directly
 - some cleanup and reorganizing of PgeTaskInstance


This addresses bug OODT-414.
    https://issues.apache.org/jira/browse/OODT-414


Diffs (updated)
-----

  trunk/pge/src/main/java/org/apache/oodt/cas/pge/PGETaskInstance.java 1301267 
  trunk/pge/src/main/java/org/apache/oodt/cas/pge/logging/PgeLogHandler.java PRE-CREATION 
  trunk/pge/src/main/java/org/apache/oodt/cas/pge/logging/PgeLogRecord.java PRE-CREATION 
  trunk/pge/src/main/java/org/apache/oodt/cas/pge/metadata/PgeMetadata.java 1300798 
  trunk/pge/src/main/java/org/apache/oodt/cas/pge/metadata/PgeTaskMetKeys.java 1301267 
  trunk/pge/src/test/org/apache/oodt/cas/pge/TestPGETaskInstance.java 1301267 
  trunk/pge/src/test/org/apache/oodt/cas/pge/logging/TestPgeLogHandler.java PRE-CREATION 

Diff: https://reviews.apache.org/r/4375/diff


Testing
-------

Added and updated unit-tests


Thanks,

brian


                
> Create Java Logger Handler for CAS-PGE
> --------------------------------------
>
>                 Key: OODT-414
>                 URL: https://issues.apache.org/jira/browse/OODT-414
>             Project: OODT
>          Issue Type: Sub-task
>          Components: pge wrapper framework
>    Affects Versions: 0.3
>         Environment: none
>            Reporter: Brian Foster
>            Assignee: Brian Foster
>            Priority: Minor
>             Fix For: 0.4
>
>         Attachments: OODT-414.2012-03-15.txt
>
>
> This handler will allow for multiple CAS-PGE instances to exist in the same JVM while routing the logging from each to their own log files in their execution directory

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (OODT-414) Create Java Logger Handler for CAS-PGE

Posted by "jiraposter@reviews.apache.org (Commented) (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/OODT-414?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13231561#comment-13231561 ] 

jiraposter@reviews.apache.org commented on OODT-414:
----------------------------------------------------



bq.  On 2012-03-16 14:28:24, Chris Mattmann wrote:
bq.  > trunk/pge/src/test/org/apache/oodt/cas/pge/TestPGETaskInstance.java, line 108
bq.  > <https://reviews.apache.org/r/4375/diff/2/?file=93053#file93053line108>
bq.  >
bq.  >     what makes this throw an exception now?
bq.  
bq.  brian Foster wrote:
bq.      I'm gradually adding "throws Exception" to all the methods in CAS-PGE's PGETaskInstance so if they are overridden by the extending class, the extending class can easily kill CAS-PGE (and give the reason why it should stop) by just throwing any Exception

+1, makes sense to me.


- Chris


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/4375/#review6035
-----------------------------------------------------------


On 2012-03-16 08:25:17, brian Foster wrote:
bq.  
bq.  -----------------------------------------------------------
bq.  This is an automatically generated e-mail. To reply, visit:
bq.  https://reviews.apache.org/r/4375/
bq.  -----------------------------------------------------------
bq.  
bq.  (Updated 2012-03-16 08:25:17)
bq.  
bq.  
bq.  Review request for oodt, Chris Mattmann, Ricky Nguyen, Paul Ramirez, and Thomas Bennett.
bq.  
bq.  
bq.  Summary
bq.  -------
bq.  
bq.  This handler will allow for multiple CAS-PGE instances to exist in the same JVM while routing the logging from each to their own log files in their execution directory
bq.  
bq.  -----
bq.  This patch also includes:
bq.   - adding support for PgeMetadata to take PgeTaskMetKeys directly
bq.   - some cleanup and reorganizing of PgeTaskInstance
bq.  
bq.  
bq.  This addresses bug OODT-414.
bq.      https://issues.apache.org/jira/browse/OODT-414
bq.  
bq.  
bq.  Diffs
bq.  -----
bq.  
bq.    trunk/pge/src/main/java/org/apache/oodt/cas/pge/PGETaskInstance.java 1301267 
bq.    trunk/pge/src/main/java/org/apache/oodt/cas/pge/logging/PgeLogHandler.java PRE-CREATION 
bq.    trunk/pge/src/main/java/org/apache/oodt/cas/pge/logging/PgeLogRecord.java PRE-CREATION 
bq.    trunk/pge/src/main/java/org/apache/oodt/cas/pge/metadata/PgeMetadata.java 1300798 
bq.    trunk/pge/src/main/java/org/apache/oodt/cas/pge/metadata/PgeTaskMetKeys.java 1301267 
bq.    trunk/pge/src/test/org/apache/oodt/cas/pge/TestPGETaskInstance.java 1301267 
bq.    trunk/pge/src/test/org/apache/oodt/cas/pge/logging/TestPgeLogHandler.java PRE-CREATION 
bq.  
bq.  Diff: https://reviews.apache.org/r/4375/diff
bq.  
bq.  
bq.  Testing
bq.  -------
bq.  
bq.  Added and updated unit-tests
bq.  
bq.  
bq.  Thanks,
bq.  
bq.  brian
bq.  
bq.


                
> Create Java Logger Handler for CAS-PGE
> --------------------------------------
>
>                 Key: OODT-414
>                 URL: https://issues.apache.org/jira/browse/OODT-414
>             Project: OODT
>          Issue Type: Sub-task
>          Components: pge wrapper framework
>    Affects Versions: 0.3
>         Environment: none
>            Reporter: Brian Foster
>            Assignee: Brian Foster
>            Priority: Minor
>             Fix For: 0.4
>
>         Attachments: OODT-414.2012-03-15.txt
>
>
> This handler will allow for multiple CAS-PGE instances to exist in the same JVM while routing the logging from each to their own log files in their execution directory

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (OODT-414) Create Java Logger Handler for CAS-PGE

Posted by "jiraposter@reviews.apache.org (Commented) (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/OODT-414?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13231234#comment-13231234 ] 

jiraposter@reviews.apache.org commented on OODT-414:
----------------------------------------------------


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/4375/#review6036
-----------------------------------------------------------

Ship it!


Minor comments, LGTM.

- Chris


On 2012-03-16 08:25:17, brian Foster wrote:
bq.  
bq.  -----------------------------------------------------------
bq.  This is an automatically generated e-mail. To reply, visit:
bq.  https://reviews.apache.org/r/4375/
bq.  -----------------------------------------------------------
bq.  
bq.  (Updated 2012-03-16 08:25:17)
bq.  
bq.  
bq.  Review request for oodt, Chris Mattmann, Ricky Nguyen, Paul Ramirez, and Thomas Bennett.
bq.  
bq.  
bq.  Summary
bq.  -------
bq.  
bq.  This handler will allow for multiple CAS-PGE instances to exist in the same JVM while routing the logging from each to their own log files in their execution directory
bq.  
bq.  -----
bq.  This patch also includes:
bq.   - adding support for PgeMetadata to take PgeTaskMetKeys directly
bq.   - some cleanup and reorganizing of PgeTaskInstance
bq.  
bq.  
bq.  This addresses bug OODT-414.
bq.      https://issues.apache.org/jira/browse/OODT-414
bq.  
bq.  
bq.  Diffs
bq.  -----
bq.  
bq.    trunk/pge/src/main/java/org/apache/oodt/cas/pge/PGETaskInstance.java 1301267 
bq.    trunk/pge/src/main/java/org/apache/oodt/cas/pge/logging/PgeLogHandler.java PRE-CREATION 
bq.    trunk/pge/src/main/java/org/apache/oodt/cas/pge/logging/PgeLogRecord.java PRE-CREATION 
bq.    trunk/pge/src/main/java/org/apache/oodt/cas/pge/metadata/PgeMetadata.java 1300798 
bq.    trunk/pge/src/main/java/org/apache/oodt/cas/pge/metadata/PgeTaskMetKeys.java 1301267 
bq.    trunk/pge/src/test/org/apache/oodt/cas/pge/TestPGETaskInstance.java 1301267 
bq.    trunk/pge/src/test/org/apache/oodt/cas/pge/logging/TestPgeLogHandler.java PRE-CREATION 
bq.  
bq.  Diff: https://reviews.apache.org/r/4375/diff
bq.  
bq.  
bq.  Testing
bq.  -------
bq.  
bq.  Added and updated unit-tests
bq.  
bq.  
bq.  Thanks,
bq.  
bq.  brian
bq.  
bq.


                
> Create Java Logger Handler for CAS-PGE
> --------------------------------------
>
>                 Key: OODT-414
>                 URL: https://issues.apache.org/jira/browse/OODT-414
>             Project: OODT
>          Issue Type: Sub-task
>          Components: pge wrapper framework
>    Affects Versions: 0.3
>         Environment: none
>            Reporter: Brian Foster
>            Assignee: Brian Foster
>            Priority: Minor
>             Fix For: 0.4
>
>         Attachments: OODT-414.2012-03-15.txt
>
>
> This handler will allow for multiple CAS-PGE instances to exist in the same JVM while routing the logging from each to their own log files in their execution directory

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (OODT-414) Create Java Logger Handler for CAS-PGE

Posted by "jiraposter@reviews.apache.org (Commented) (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/OODT-414?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13231513#comment-13231513 ] 

jiraposter@reviews.apache.org commented on OODT-414:
----------------------------------------------------



bq.  On 2012-03-16 14:28:24, Chris Mattmann wrote:
bq.  > trunk/pge/src/main/java/org/apache/oodt/cas/pge/PGETaskInstance.java, line 568
bq.  > <https://reviews.apache.org/r/4375/diff/2/?file=93048#file93048line568>
bq.  >
bq.  >     I like this having an explicit step now.

after this patch goes in, the trunk CAS-PGE will have a feature which was attempted in wengine branch CAS-PGE but i never got working right... when multiple CAS-PGEs run in the same JVM, which is the normal case since several will end up in a CAS-Resource's BatchStub, they will log on top of each other since the logger was based on the class name and CAS-PGE usually had the same class name so was impossible to filter loggers by that... so it was really hard to sift through the logs finding relevant logger for a given CAS-PGE instance... this patch fixed that by making logging base on PGETask/Name (or legacy PGETask_Name)


- brian


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/4375/#review6035
-----------------------------------------------------------


On 2012-03-16 08:25:17, brian Foster wrote:
bq.  
bq.  -----------------------------------------------------------
bq.  This is an automatically generated e-mail. To reply, visit:
bq.  https://reviews.apache.org/r/4375/
bq.  -----------------------------------------------------------
bq.  
bq.  (Updated 2012-03-16 08:25:17)
bq.  
bq.  
bq.  Review request for oodt, Chris Mattmann, Ricky Nguyen, Paul Ramirez, and Thomas Bennett.
bq.  
bq.  
bq.  Summary
bq.  -------
bq.  
bq.  This handler will allow for multiple CAS-PGE instances to exist in the same JVM while routing the logging from each to their own log files in their execution directory
bq.  
bq.  -----
bq.  This patch also includes:
bq.   - adding support for PgeMetadata to take PgeTaskMetKeys directly
bq.   - some cleanup and reorganizing of PgeTaskInstance
bq.  
bq.  
bq.  This addresses bug OODT-414.
bq.      https://issues.apache.org/jira/browse/OODT-414
bq.  
bq.  
bq.  Diffs
bq.  -----
bq.  
bq.    trunk/pge/src/main/java/org/apache/oodt/cas/pge/PGETaskInstance.java 1301267 
bq.    trunk/pge/src/main/java/org/apache/oodt/cas/pge/logging/PgeLogHandler.java PRE-CREATION 
bq.    trunk/pge/src/main/java/org/apache/oodt/cas/pge/logging/PgeLogRecord.java PRE-CREATION 
bq.    trunk/pge/src/main/java/org/apache/oodt/cas/pge/metadata/PgeMetadata.java 1300798 
bq.    trunk/pge/src/main/java/org/apache/oodt/cas/pge/metadata/PgeTaskMetKeys.java 1301267 
bq.    trunk/pge/src/test/org/apache/oodt/cas/pge/TestPGETaskInstance.java 1301267 
bq.    trunk/pge/src/test/org/apache/oodt/cas/pge/logging/TestPgeLogHandler.java PRE-CREATION 
bq.  
bq.  Diff: https://reviews.apache.org/r/4375/diff
bq.  
bq.  
bq.  Testing
bq.  -------
bq.  
bq.  Added and updated unit-tests
bq.  
bq.  
bq.  Thanks,
bq.  
bq.  brian
bq.  
bq.


                
> Create Java Logger Handler for CAS-PGE
> --------------------------------------
>
>                 Key: OODT-414
>                 URL: https://issues.apache.org/jira/browse/OODT-414
>             Project: OODT
>          Issue Type: Sub-task
>          Components: pge wrapper framework
>    Affects Versions: 0.3
>         Environment: none
>            Reporter: Brian Foster
>            Assignee: Brian Foster
>            Priority: Minor
>             Fix For: 0.4
>
>         Attachments: OODT-414.2012-03-15.txt
>
>
> This handler will allow for multiple CAS-PGE instances to exist in the same JVM while routing the logging from each to their own log files in their execution directory

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (OODT-414) Create Java Logger Handler for CAS-PGE

Posted by "jiraposter@reviews.apache.org (Commented) (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/OODT-414?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13230834#comment-13230834 ] 

jiraposter@reviews.apache.org commented on OODT-414:
----------------------------------------------------


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/4375/
-----------------------------------------------------------

Review request for oodt, Chris Mattmann, Ricky Nguyen, Paul Ramirez, and Thomas Bennett.


Summary
-------

This handler will allow for multiple CAS-PGE instances to exist in the same JVM while routing the logging from each to their own log files in their execution directory

-----
This patch also includes:
 - adding support for PgeMetadata to take PgeTaskMetKeys directly
 - some cleanup and reorganizing of PgeTaskInstance


This addresses bug OODT-414.
    https://issues.apache.org/jira/browse/OODT-414


Diffs
-----

  trunk/pge/src/main/java/org/apache/oodt/cas/pge/PGETaskInstance.java 1301267 
  trunk/pge/src/main/java/org/apache/oodt/cas/pge/logging/PgeLogHandler.java PRE-CREATION 
  trunk/pge/src/main/java/org/apache/oodt/cas/pge/logging/PgeLogRecord.java PRE-CREATION 
  trunk/pge/src/main/java/org/apache/oodt/cas/pge/metadata/PgeMetadata.java 1300798 
  trunk/pge/src/main/java/org/apache/oodt/cas/pge/metadata/PgeTaskMetKeys.java 1301267 
  trunk/pge/src/test/org/apache/oodt/cas/pge/TestPGETaskInstance.java 1301267 
  trunk/pge/src/test/org/apache/oodt/cas/pge/logging/TestPgeLogHandler.java PRE-CREATION 

Diff: https://reviews.apache.org/r/4375/diff


Testing
-------

Added and updated unit-tests


Thanks,

brian


                
> Create Java Logger Handler for CAS-PGE
> --------------------------------------
>
>                 Key: OODT-414
>                 URL: https://issues.apache.org/jira/browse/OODT-414
>             Project: OODT
>          Issue Type: Sub-task
>          Components: pge wrapper framework
>    Affects Versions: 0.3
>         Environment: none
>            Reporter: Brian Foster
>            Assignee: Brian Foster
>            Priority: Minor
>             Fix For: 0.4
>
>         Attachments: OODT-414.2012-03-15.txt
>
>
> This handler will allow for multiple CAS-PGE instances to exist in the same JVM while routing the logging from each to their own log files in their execution directory

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Resolved] (OODT-414) Create Java Logger Handler for CAS-PGE

Posted by "Brian Foster (Resolved) (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/OODT-414?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Brian Foster resolved OODT-414.
-------------------------------

    Resolution: Fixed

- fixed in r1301762
                
> Create Java Logger Handler for CAS-PGE
> --------------------------------------
>
>                 Key: OODT-414
>                 URL: https://issues.apache.org/jira/browse/OODT-414
>             Project: OODT
>          Issue Type: Sub-task
>          Components: pge wrapper framework
>    Affects Versions: 0.3
>         Environment: none
>            Reporter: Brian Foster
>            Assignee: Brian Foster
>            Priority: Minor
>             Fix For: 0.4
>
>         Attachments: OODT-414.2012-03-15.txt
>
>
> This handler will allow for multiple CAS-PGE instances to exist in the same JVM while routing the logging from each to their own log files in their execution directory

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Updated] (OODT-414) Create Java Logger Handler for CAS-PGE

Posted by "Brian Foster (Updated) (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/OODT-414?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Brian Foster updated OODT-414:
------------------------------

    Attachment: OODT-415.2012-03-15.patch.txt

- attached patch
                
> Create Java Logger Handler for CAS-PGE
> --------------------------------------
>
>                 Key: OODT-414
>                 URL: https://issues.apache.org/jira/browse/OODT-414
>             Project: OODT
>          Issue Type: Sub-task
>          Components: pge wrapper framework
>    Affects Versions: 0.3
>         Environment: none
>            Reporter: Brian Foster
>            Assignee: Brian Foster
>            Priority: Minor
>             Fix For: 0.4
>
>         Attachments: OODT-415.2012-03-15.patch.txt
>
>
> This handler will allow for multiple CAS-PGE instances to exist in the same JVM while routing the logging from each to their own log files in their execution directory

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Updated] (OODT-414) Create Java Logger Handler for CAS-PGE

Posted by "Brian Foster (Updated) (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/OODT-414?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Brian Foster updated OODT-414:
------------------------------

    Attachment:     (was: OODT-415.2012-03-15.patch.txt)
    
> Create Java Logger Handler for CAS-PGE
> --------------------------------------
>
>                 Key: OODT-414
>                 URL: https://issues.apache.org/jira/browse/OODT-414
>             Project: OODT
>          Issue Type: Sub-task
>          Components: pge wrapper framework
>    Affects Versions: 0.3
>         Environment: none
>            Reporter: Brian Foster
>            Assignee: Brian Foster
>            Priority: Minor
>             Fix For: 0.4
>
>         Attachments: OODT-414.2012-03-15.txt
>
>
> This handler will allow for multiple CAS-PGE instances to exist in the same JVM while routing the logging from each to their own log files in their execution directory

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira