You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@ozone.apache.org by "sarvekshayr (via GitHub)" <gi...@apache.org> on 2025/01/13 04:23:15 UTC
[PR] HDDS-12050. Implement TransactionInfoRepair command for SCM [ozone]
sarvekshayr opened a new pull request, #7689:
URL: https://github.com/apache/ozone/pull/7689
## What changes were proposed in this pull request?
`ozone repair scm update-transaction`
A port of the existing `ozone repair om update-transaction` for SCM.
## What is the link to the Apache JIRA
[HDDS-12050](https://issues.apache.org/jira/browse/HDDS-12050)
## How was this patch tested?
Tested the patch on a docker cluster.
```
bash-5.1$ ozone repair scm
Missing required subcommand
Usage: ozone repair scm [COMMAND]
Operational tool to repair SCM.
Commands:
cert Subcommand for all certificate related repairs on SCM
update-transaction CLI to update the highest index in scmTransactionInfos
table.
```
```
bash-5.1$ ozone repair scm update-transaction --db /data/metadata/scm.db --term 2 --index 2
ATTENTION: Running as user hadoop. Make sure this is the same user used to run the Ozone process. Are you sure you want to continue (y/N)? y
Run as user: hadoop
Error: SCM is currently running on this host with PID 7. Stop the service before running the repair tool.
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
Re: [PR] HDDS-12050. Implement TransactionInfoRepair command for SCM [ozone]
Posted by "adoroszlai (via GitHub)" <gi...@apache.org>.
adoroszlai commented on PR #7689:
URL: https://github.com/apache/ozone/pull/7689#issuecomment-2588123758
@errose28 could you please review?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
Re: [PR] HDDS-12050. Implement TransactionInfoRepair command for SCM [ozone]
Posted by "adoroszlai (via GitHub)" <gi...@apache.org>.
adoroszlai merged PR #7689:
URL: https://github.com/apache/ozone/pull/7689
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
Re: [PR] HDDS-12050. Implement TransactionInfoRepair command for SCM [ozone]
Posted by "adoroszlai (via GitHub)" <gi...@apache.org>.
adoroszlai commented on PR #7689:
URL: https://github.com/apache/ozone/pull/7689#issuecomment-2586699478
> The change proposed is simpler, reduces duplication and the patch looks good overall. We can commit the change.
Thanks, I've added my commits to this PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
Re: [PR] HDDS-12050. Implement TransactionInfoRepair command for SCM [ozone]
Posted by "adoroszlai (via GitHub)" <gi...@apache.org>.
adoroszlai commented on PR #7689:
URL: https://github.com/apache/ozone/pull/7689#issuecomment-2592210351
@nandakumar131 please review if you have some time
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
Re: [PR] HDDS-12050. Implement TransactionInfoRepair command for SCM [ozone]
Posted by "adoroszlai (via GitHub)" <gi...@apache.org>.
adoroszlai commented on PR #7689:
URL: https://github.com/apache/ozone/pull/7689#issuecomment-2610573779
Thanks @sarvekshayr for the patch, @nandakumar131, @Tejaskriya for the review.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
Re: [PR] HDDS-12050. Implement TransactionInfoRepair command for SCM [ozone]
Posted by "sarvekshayr (via GitHub)" <gi...@apache.org>.
sarvekshayr commented on PR #7689:
URL: https://github.com/apache/ozone/pull/7689#issuecomment-2586507403
> I would like to avoid copying logic for SCM's version of the tool. Here's my attempt to reduce duplication: [adoroszlai@29fd408](https://github.com/adoroszlai/ozone/commit/29fd4080b5efe9e3a8be7a6343d02a66e21c2c80), which results in smaller diff: [master...adoroszlai:ozone:HDDS-12050](https://github.com/apache/ozone/compare/master...adoroszlai:ozone:HDDS-12050)
Thank you @adoroszlai. The change proposed is simpler, reduces duplication and the patch looks good overall.
We can commit the change.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
Re: [PR] HDDS-12050. Implement TransactionInfoRepair command for SCM [ozone]
Posted by "sarvekshayr (via GitHub)" <gi...@apache.org>.
sarvekshayr commented on PR #7689:
URL: https://github.com/apache/ozone/pull/7689#issuecomment-2594811080
> Thanks for working on this @sarvekshayr , Could we add a test under the integration test `TestOzoneRepairShell` for testing scm component as well? (there is `testUpdateTransactionInfoTable` testing for om already)
Sure, I'll modify it to test scm component as well.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
Re: [PR] HDDS-12050. Implement TransactionInfoRepair command for SCM [ozone]
Posted by "nandakumar131 (via GitHub)" <gi...@apache.org>.
nandakumar131 commented on PR #7689:
URL: https://github.com/apache/ozone/pull/7689#issuecomment-2609548318
Thanks @adoroszlai for solving the conflict.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org