You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Wenzhe Zhou (Code Review)" <ge...@cloudera.org> on 2020/01/30 00:36:00 UTC

[Impala-ASF-CR] IMPALA-8110: Fix the Parquet stats filtering issue to correctly handle narrowed integer types

Wenzhe Zhou has uploaded a new patch set (#4). ( http://gerrit.cloudera.org:8080/15087 )

Change subject: IMPALA-8110: Fix the Parquet stats filtering issue to correctly handle narrowed integer types
......................................................................

IMPALA-8110: Fix the Parquet stats filtering issue to correctly
handle narrowed integer types

This patch adds validation for the paired stats values of tinyint
and smallint column data type when reading min/max column stats
value from Parquet file.

Testing:
 - Did Manual tests: create table with column as int type, intert
   some values, then alter table to change the column data type as
   tinyint (int8), insert more values, verify the query return
   correct number of rows when PARQUET_READ_STATISTICS is set as 1.
   Did similar tests to change column data type from int to smallint,
   and from smallint to tinyint.
 - Added test cases in parquet-stats.test for column data type been
   changed from int to tinyint, from smallint to tinyint and from
   int to smallint.
 - Passed all EE tests.
 - Passed pre-review-test on Jenkins, including FE tests, BE tests,
   EE tests, JDBS test and cluster tests.

Change-Id: Id8bdaf4c4b2d0c6ea26d6e9bf013afca647e53a1
---
M be/src/exec/parquet/hdfs-parquet-scanner.cc
M be/src/exec/parquet/parquet-column-stats.cc
M be/src/exec/parquet/parquet-column-stats.h
M testdata/workloads/functional-query/queries/QueryTest/parquet-stats.test
4 files changed, 94 insertions(+), 6 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/87/15087/4
-- 
To view, visit http://gerrit.cloudera.org:8080/15087
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Id8bdaf4c4b2d0c6ea26d6e9bf013afca647e53a1
Gerrit-Change-Number: 15087
Gerrit-PatchSet: 4
Gerrit-Owner: Wenzhe Zhou <wz...@cloudera.com>
Gerrit-Reviewer: Bikramjeet Vig <bi...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>