You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by "ramitkataria (via GitHub)" <gi...@apache.org> on 2025/09/09 00:26:25 UTC
Re: [PR] Add Async support for SMTP Notifier [airflow]
ramitkataria commented on code in PR #55308:
URL: https://github.com/apache/airflow/pull/55308#discussion_r2331604445
##########
providers/slack/src/airflow/providers/slack/notifications/slack_webhook.py:
##########
@@ -64,7 +65,11 @@ def __init__(
retry_handlers: list[RetryHandler] | None = None,
**kwargs,
):
- super().__init__(**kwargs)
+ if AIRFLOW_V_3_1_PLUS:
Review Comment:
Should we add a check in the BaseNotifier instead? Something like:
```
if context and not AIRFLOW_V_3_1_PLUS:
raise ...
````
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org