You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@druid.apache.org by GitBox <gi...@apache.org> on 2019/02/27 14:34:01 UTC
[GitHub] kamaci commented on a change in pull request #7121: Prohibit
Throwables.propagate()
kamaci commented on a change in pull request #7121: Prohibit Throwables.propagate()
URL: https://github.com/apache/incubator-druid/pull/7121#discussion_r260775400
##########
File path: indexing-hadoop/src/main/java/org/apache/druid/indexer/updater/HadoopConverterJob.java
##########
@@ -344,9 +343,7 @@ public DataSegment apply(final Path input)
}
}
catch (InterruptedException | ClassNotFoundException e) {
- RuntimeException exception = Throwables.propagate(e);
- throwable = exception;
- throw exception;
+ throw new RuntimeException(e);
Review comment:
Removing this catch clause causes unhandled `InterruptedException` and `ClassNotFoundException`. Should I also remove `throw t` after removing that catch clause?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org