You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@nemo.apache.org by GitBox <gi...@apache.org> on 2018/06/28 06:34:04 UTC

[GitHub] seojangho commented on a change in pull request #56: [NEMO-16] Implement collection of data from executor to client

seojangho commented on a change in pull request #56: [NEMO-16] Implement collection of data from executor to client
URL: https://github.com/apache/incubator-nemo/pull/56#discussion_r198720704
 
 

 ##########
 File path: common/src/main/java/edu/snu/nemo/common/ContextImpl.java
 ##########
 @@ -18,23 +18,36 @@
 import edu.snu.nemo.common.ir.vertex.transform.Transform;
 
 import java.util.Map;
+import java.util.Optional;
 
 /**
  * Transform Context Implementation.
  */
 public final class ContextImpl implements Transform.Context {
   private final Map sideInputs;
+  private Optional<String> data;
 
 Review comment:
   How about letting data `Nullable` and returning `Optional.ofNullable(data)` in `getSerializedData`?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services