You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by "xinrong-meng (via GitHub)" <gi...@apache.org> on 2023/07/14 18:05:08 UTC

[GitHub] [spark] xinrong-meng commented on a diff in pull request #41946: [SPARK-44264][PYTHON][ML] FunctionPickler Class

xinrong-meng commented on code in PR #41946:
URL: https://github.com/apache/spark/pull/41946#discussion_r1264006192


##########
python/pyspark/ml/dl_util.py:
##########
@@ -91,25 +87,20 @@ def create_fn_run_script(
         ----------
         pickled_fn_path: str
             This is the path of the file containing the pickled function, args, and kwargs.
-
         fn_output_path: str
             This is the location where the created file will save the pickled output of
             the function.
-
         script_path: str
             This is the path which will be used for the created pytorch file.
-
         prefix_code: str
             This contains a string that the user can pass in which will be executed before
             the code generated by this class to execute the function and save it. If
             prefix_code is the empty string, nothing will be written before the auto-
             generated code.
-
         suffix_code: str
             This contains a string of code that the user can pass in which will be executed
             after the code generated by this class finishes executing. If suffix_code is
             the empty string, nothing will be written after the auto-generated code.
-

Review Comment:
   Would you please add the blank line back between "Parameters" section and "Returns"?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org