[GitHub] [nifi-minifi-cpp] adamdebreceni commented on a diff in pull request #1439: MINIFICPP-1967 Add batch processing of lines in TailFile

[GitBox <gi...@apache.org>]

adamdebreceni commented on code in PR #1439:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1439#discussion_r1008109715


##########
extensions/standard-processors/processors/TailFile.cpp:
##########
@@ -135,6 +135,13 @@ const core::Property TailFile::AttributeProviderService(
         ->asType<minifi::controllers::AttributeProviderService>()
         ->build());
 
+const core::Property TailFile::BatchSize(
+    core::PropertyBuilder::createProperty("Batch Size")
+        ->withDescription("Maximum number of lines to process in a single trigger. If set to 0 all new lines will be processed.")

Review Comment:
   should we change this to "number of flowfiles emitted" or similar? with the input delimiter the user could break the "flowfile == line" correspondence 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org