You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@beam.apache.org by "aIbrahiim (via GitHub)" <gi...@apache.org> on 2026/06/17 21:36:29 UTC
[PR] Fix Milvus ML PreCommit xdist, container startup, and grpc readiness [beam]
aIbrahiim opened a new pull request, #39007:
URL: https://github.com/apache/beam/pull/39007
**Please** add a meaningful description for your change here
------------------------
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
- [ ] Mention the appropriate issue in your description (for example: `addresses #123`), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment `fixes #<ISSUE NUMBER>` instead.
- [ ] Update `CHANGES.md` with noteworthy changes.
- [ ] If this contribution is large, please file an Apache [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf).
See the [Contributor Guide](https://beam.apache.org/contribute) for more tips on [how to make review process smoother](https://github.com/apache/beam/blob/master/CONTRIBUTING.md#make-the-reviewers-job-easier).
To check the build health, please visit [https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md](https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md)
GitHub Actions Tests Status (on master branch)
------------------------------------------------------------------------------------------------
[](https://github.com/apache/beam/actions?query=workflow%3A%22Build+python+source+distribution+and+wheels%22+branch%3Amaster+event%3Aschedule)
[](https://github.com/apache/beam/actions?query=workflow%3A%22Python+Tests%22+branch%3Amaster+event%3Aschedule)
[](https://github.com/apache/beam/actions?query=workflow%3A%22Java+Tests%22+branch%3Amaster+event%3Aschedule)
[](https://github.com/apache/beam/actions?query=workflow%3A%22Go+tests%22+branch%3Amaster+event%3Aschedule)
See [CI.md](https://github.com/apache/beam/blob/master/CI.md) for more information about GitHub Actions CI or the [workflows README](https://github.com/apache/beam/blob/master/.github/workflows/README.md) to see a list of phrases to trigger workflows.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fix The PreCommit Python ML tests with ML deps installed job [beam]
Posted by "aIbrahiim (via GitHub)" <gi...@apache.org>.
aIbrahiim commented on PR #39007:
URL: https://github.com/apache/beam/pull/39007#issuecomment-4740154139
> Are these milvus tests still running in any of the test suites? Can you confirm?
yes, I checked and they're still running. There are currently two active Milvus integration test files:
- ingestion/milvus_search_it_test.py
- enrichment/milvus_search_it_test.py
Both are marked with @pytest.mark.require_docker_in_docker, and they are included in the PreCommit Python ML workflow and they run on the ubuntu latest runner with Python 3.13 and the failing job is the one that runs apache_beam/ml/ -m require_docker_in_docker, so the Milvus tests are definitely still part of the test suite and that's where the container startup timeout is happening
`WARNING apache_beam.ml.rag.test_utils:test_utils.py:201 Retry 2/3:
Failed to start Milvus DB container. Reason: Port mapping for container
166f055b71eda80e14ff7076a4c3d714e6af6ba1f718227eac3fe91c8c564b94 and
port 43681 is not available.`
`WARNING apache_beam.ml.rag.utils:utils.py:210 Milvus client connection
after container start attempt 1 failed: <MilvusException: (code=2,
message=Fail connecting to server on localhost:36461, illegal connection
params or server unavailable)>. Retrying in 2.00 seconds...
WARNING apache_beam.ml.rag.utils:utils.py:210 Milvus client connection
after container start attempt 2 failed: ... Retrying in 2.40 seconds...
... [attempts 3-21] ...
WARNING apache_beam.ml.rag.utils:utils.py:210 Milvus client connection
after container start attempt 21 failed: ... Retrying in 76.68 seconds.`
`___ ERROR at setup of TestMilvusVectorWriterConfig.test_write_with_batching ____`
@claudevdm
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fix Milvus ML PreCommit xdist, container startup, and grpc readiness [beam]
Posted by "gemini-code-assist[bot] (via GitHub)" <gi...@apache.org>.
gemini-code-assist[bot] commented on PR #39007:
URL: https://github.com/apache/beam/pull/39007#issuecomment-4735893748
## Summary of Changes
Hello, I'm Gemini Code Assist[^1]! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!
This pull request addresses stability and configuration issues within the Milvus integration tests. By disabling parallel execution (xdist) for specific tests, refining container startup commands, and tuning connection retry parameters, the changes ensure more reliable test outcomes in the CI environment.
### Highlights
* **Test Stability**: Disabled xdist for Milvus integration tests to prevent concurrency issues during test execution.
* **Container Configuration**: Explicitly set the startup command for the Milvus container to ensure proper initialization.
* **Connection Retries**: Adjusted the retry logic for Milvus client connections to improve efficiency during startup.
<details>
<summary><b>New Features</b></summary>
🧠You can now enable **Memory** (public preview) to help **Gemini Code Assist** learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. **Click [here](https://codeassist.google/code-review/login) to enable Memory in your admin console.**
</details>
<details>
<summary><b>Using Gemini Code Assist</b></summary>
<br>
The full guide for Gemini Code Assist can be found on our [documentation page](https://developers.google.com/gemini-code-assist/docs/review-github-code), here are some quick tips.
<b>Invoking Gemini</b>
You can request assistance from Gemini at any point by creating a comment using either `/gemini <command>` or `@gemini-code-assist <command>`. Below is a summary of the supported commands on the current page.
Feature | Command | Description
--- | --- | ---
Code Review | `/gemini review` | Performs a code review for the current pull request in its current state.
Pull Request Summary | `/gemini summary` | Provides a summary of the current pull request in its current state.
Comment | @gemini-code-assist | Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help | `/gemini help` | Displays a list of available commands.
<b>Customization</b>
To customize the Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a `.gemini/` folder in the base of the repository. Detailed instructions can be found [here](https://developers.google.com/gemini-code-assist/docs/customize-gemini-behavior-github).
<b>Limitations & Feedback</b>
Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counterproductive. You can react with :thumbsup: and :thumbsdown: on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up [here](https://google.qualtrics.com/jfe/form/SV_2cyuGuTWsEw84yG).
</details>
[^1]: Review the [Privacy Notices](https://policies.google.com/privacy), [Generative AI Prohibited Use Policy](https://policies.google.com/terms/generative-ai/use-policy), [Terms of Service](https://policies.google.com/terms), and learn how to configure Gemini Code Assist in GitHub [here](https://developers.google.com/gemini-code-assist/docs/customize-gemini-behavior-github). Gemini can make mistakes, so double check it and [use code with caution](https://support.google.com/legal/answer/13505487).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fix The PreCommit Python ML tests with ML deps installed job [beam]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #39007:
URL: https://github.com/apache/beam/pull/39007#issuecomment-4736913618
Assigning reviewers:
R: @claudevdm for label python.
Note: If you would like to opt out of this review, comment `assign to next reviewer`.
Available commands:
- `stop reviewer notifications` - opt out of the automated review tooling
- `remind me after tests pass` - tag the comment author after tests pass
- `waiting on author` - shift the attention set back to the author (any comment or push by the author will return the attention set to the reviewers)
The PR bot will only process comments in the main thread (not review comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fix The PreCommit Python ML tests with ML deps installed job [beam]
Posted by "codecov[bot] (via GitHub)" <gi...@apache.org>.
codecov[bot] commented on PR #39007:
URL: https://github.com/apache/beam/pull/39007#issuecomment-4736394864
## [Codecov](https://app.codecov.io/gh/apache/beam/pull/39007?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:x: Patch coverage is `0%` with `1 line` in your changes missing coverage. Please review.
:white_check_mark: Project coverage is 60.25%. Comparing base ([`6ed0635`](https://app.codecov.io/gh/apache/beam/commit/6ed0635429a6bd01c04c353c4c270927fe5004a5?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`64d0c6d`](https://app.codecov.io/gh/apache/beam/commit/64d0c6d75e574a6a45f39c4846e4eb7dc0d6c268?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
:warning: Report is 25 commits behind head on master.
| [Files with missing lines](https://app.codecov.io/gh/apache/beam/pull/39007?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
|---|---|---|
| [sdks/python/apache\_beam/ml/rag/test\_utils.py](https://app.codecov.io/gh/apache/beam/pull/39007?src=pr&el=tree&filepath=sdks%2Fpython%2Fapache_beam%2Fml%2Frag%2Ftest_utils.py&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vbWwvcmFnL3Rlc3RfdXRpbHMucHk=) | 0.00% | [1 Missing :warning: ](https://app.codecov.io/gh/apache/beam/pull/39007?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #39007 +/- ##
=========================================
Coverage 60.25% 60.25%
Complexity 20572 20572
=========================================
Files 3318 3318
Lines 315452 315485 +33
Branches 17142 17142
=========================================
+ Hits 190073 190104 +31
- Misses 116830 116832 +2
Partials 8549 8549
```
| [Flag](https://app.codecov.io/gh/apache/beam/pull/39007/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [python](https://app.codecov.io/gh/apache/beam/pull/39007/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `79.27% <0.00%> (+<0.01%)` | :arrow_up: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
</details>
[:umbrella: View full report in Codecov by Harness](https://app.codecov.io/gh/apache/beam/pull/39007?dropdown=coverage&src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
:loudspeaker: Have feedback on the report? [Share it here](https://about.codecov.io/codecov-pr-comment-feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
- :package: [JS Bundle Analysis](https://docs.codecov.com/docs/javascript-bundle-analysis): Save yourself from yourself by tracking and limiting bundle sizes in JS merges.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fix The PreCommit Python ML tests with ML deps installed job [beam]
Posted by "Abacn (via GitHub)" <gi...@apache.org>.
Abacn merged PR #39007:
URL: https://github.com/apache/beam/pull/39007
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fix Milvus ML PreCommit xdist, container startup, and grpc readiness [beam]
Posted by "gemini-code-assist[bot] (via GitHub)" <gi...@apache.org>.
gemini-code-assist[bot] commented on code in PR #39007:
URL: https://github.com/apache/beam/pull/39007#discussion_r3431708550
##########
sdks/python/apache_beam/ml/rag/test_utils.py:
##########
@@ -152,9 +153,8 @@ def list_collections_probe():
retry_with_backoff(
list_collections_probe,
- max_retries=25,
+ max_retries=5,
retry_delay=2.0,
Review Comment:
Reducing `max_retries` to 5 with a flat `retry_delay` of 2.0 seconds allows only 10 seconds for the Milvus container to become ready. In resource-constrained CI environments (such as GitHub Actions runners), starting a Milvus standalone container (which includes etcd and MinIO) can frequently take longer than 10 seconds, potentially leading to flaky test failures. Consider keeping a higher retry limit (e.g., 15 or 20 retries) or retaining the backoff factor to ensure sufficient startup time.
```suggestion
max_retries=15,
retry_delay=2.0,
retry_backoff_factor=1.1,
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org