You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@tomcat.apache.org by "ASF GitHub Bot (JIRA)" <ji...@apache.org> on 2014/12/08 15:16:12 UTC

[jira] [Commented] (MTOMCAT-290) Parallel deployment - Support version in war file name when using run-war goal

    [ https://issues.apache.org/jira/browse/MTOMCAT-290?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14237887#comment-14237887 ] 

ASF GitHub Bot commented on MTOMCAT-290:
----------------------------------------

GitHub user oroger opened a pull request:

    https://github.com/apache/tomcat-maven-plugin/pull/14

    MTOMCAT-290 - Fix for parallel deployment

    Fix for the probleme explained in MTOMCAT-290 (https://issues.apache.org/jira/browse/MTOMCAT-290).
    This fix simply strip the version, if present, from the path when running a WAR.
    
    BEWARE: I did not look into the internals of the project, this patch might have side-effects should not have side effects but I could not verify it (Is there a test suite to run for this plugin?)

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/oroger/tomcat-maven-plugin trunk

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/tomcat-maven-plugin/pull/14.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #14
    
----
commit dc29fabf542812f84df03581a5f20b747794edf6
Author: Olivier Roger <or...@informex.be>
Date:   2014-12-08T14:04:45Z

    Fix for parallel deployment

----


> Parallel deployment - Support version in war file name when using run-war goal
> ------------------------------------------------------------------------------
>
>                 Key: MTOMCAT-290
>                 URL: https://issues.apache.org/jira/browse/MTOMCAT-290
>             Project: Apache Tomcat Maven Plugin
>          Issue Type: Improvement
>          Components: tomcat7
>    Affects Versions: 2.2
>         Environment: maven tomcat7
>            Reporter: Olivier Roger
>            Assignee: Olivier Lamy (*$^¨%`£)
>            Priority: Minor
>              Labels: maven, parallel-deployment, run-war
>         Attachments: tomcat-maven-plugin_parallel-deploy.patch
>
>
> When using the tomcat7:run-war goal, the context is created based on the *path* configuration parameter.
> To use parallel deployment (http://jagadesh4java.blogspot.be/2013/08/tomcat-7-parallel-deployment.html) I usually append the timestamp to the path as shown below:
> 	<groupId>org.apache.tomcat.maven</groupId>
> 	<artifactId>tomcat7-maven-plugin</artifactId>
> 	<configuration>
> 		<path>/myWar##${maven.build.timestamp}</path>
> This works perfectly when deploying (tomcat7:deploy-only) the war since Tomcat detect the ## and separate the context from the version.
> However there the same process is not applied when running the war (tomocat7:run-war) the *##* characters are URL encoded as *%13%13* and the version (=timestamp) is in the resulting context.
> Usually all character should be URL encoded as it is done as the moment, but this case of parallel deployement might be an exception. (feature was introducted in tomcat7).



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org