You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@grails.apache.org by "clayburn (via GitHub)" <gi...@apache.org> on 2026/10/11 14:30:31 UTC
[PR] Use the Grails Develocity access key for the remote build cache [grails-core]
clayburn opened a new pull request, #16613:
URL: https://github.com/apache/grails-core/pull/16613
## Description
Fixes #16346.
CI builds were rejected with `403: Forbidden` when storing entries in the Apache Develocity remote build cache, so the cache was never populated. ASF Infra has now provisioned a Develocity access key with cache write access and stored it as the `GRAILS_DEVELOCITY_ACCESS_KEY` secret ([INFRA-28501](https://issues.apache.org/jira/browse/INFRA-28501)).
### Changes
- **Use the new key through setup-gradle.** Every workflow now passes `secrets.GRAILS_DEVELOCITY_ACCESS_KEY` to the `develocity-access-key` input of `gradle/actions/setup-gradle`. setup-gradle exchanges it for a short-lived access token and exports that token to the build as `DEVELOCITY_ACCESS_KEY`, so the long-lived key never reaches the Gradle process. The Forge AWS deploy workflow, which previously passed no key, now does too. (`release-verify.yml` is left without a key on purpose: it verifies a release from a pristine environment.)
- **Push only with credentials.** In every `settings.gradle` (root, `build-logic`, `grails-gradle`, `grails-forge`, `end-to-end`, `end-to-end/legacy-g7-command-plugin`), remote cache `push` is now enabled only when the `DEVELOCITY_ACCESS_KEY` environment variable is present, instead of whenever `CI` is set. Builds without credentials, such as pull requests from forks where secrets are unavailable, read from the cache but no longer attempt stores that get rejected.
- **Groovy snapshot canary.** The canary init script read `GRAILS_DEVELOCITY_ACCESS_KEY`, which no workflow exports, so it never pushed to the cache. It now reads `DEVELOCITY_ACCESS_KEY`, consistent with the settings files.
### Verification
Once CI runs from `apache/grails-core`, not this fork, the build scans should show remote cache stores succeeding instead of `403: Forbidden` (Performance → Build cache in the scan).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@grails.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Use the Grails Develocity access key for the remote build cache [grails-core]
Posted by "testlens-app[bot] (via GitHub)" <gi...@apache.org>.
testlens-app[bot] commented on PR #16613:
URL: https://github.com/apache/grails-core/pull/16613#issuecomment-6112058682
## ✅ All tests passed ✅
🏷️ Commit: 57582ce032d847ee9ab8ca35f702050a6548e421
▶️ Tests: 110080 executed
⚪️ Checks: 92/92 completed
---
_Learn more about TestLens at [testlens.app/docs](https://testlens.app/docs/features/pr-comment/)._
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@grails.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Use the Grails Develocity access key for the remote build cache [grails-core]
Posted by "clayburn (via GitHub)" <gi...@apache.org>.
clayburn commented on PR #16613:
URL: https://github.com/apache/grails-core/pull/16613#issuecomment-6119659231
@jdaugherty - sounds good. Just to be clear, you will need to push this branch to `apache/grails-core` to test it properly. From my fork, push will be disabled as my fork cannot access the secret.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@grails.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Use the Grails Develocity access key for the remote build cache [grails-core]
Posted by "jdaugherty (via GitHub)" <gi...@apache.org>.
jdaugherty commented on PR #16613:
URL: https://github.com/apache/grails-core/pull/16613#issuecomment-6111166693
I will perform this merge if the key is confirmed working. I will then followup with a PR to adopt the cache instead of the github cache approach.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@grails.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Use the Grails Develocity access key for the remote build cache [grails-core]
Posted by "codecov[bot] (via GitHub)" <gi...@apache.org>.
codecov[bot] commented on PR #16613:
URL: https://github.com/apache/grails-core/pull/16613#issuecomment-6111727942
## [Codecov](https://app.codecov.io/gh/apache/grails-core/pull/16613?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:white_check_mark: All modified and coverable lines are covered by tests.
:white_check_mark: Project coverage is 59.5825%. Comparing base ([`bfa7093`](https://app.codecov.io/gh/apache/grails-core/commit/bfa709384d5e03de3a4bd77c3e12e9b80d37e4e2?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`57582ce`](https://app.codecov.io/gh/apache/grails-core/commit/57582ce032d847ee9ab8ca35f702050a6548e421?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
<details><summary>Additional details and impacted files</summary>
[](https://app.codecov.io/gh/apache/grails-core/pull/16613?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
```diff
@@ Coverage Diff @@
## 8.0.x #16613 +/- ##
==================================================
- Coverage 59.5890% 59.5825% -0.0064%
+ Complexity 25035 25033 -2
==================================================
Files 2175 2175
Lines 108651 108651
Branches 19821 19821
==================================================
- Hits 64744 64737 -7
- Misses 34965 34970 +5
- Partials 8942 8944 +2
```
[see 3 files with indirect coverage changes](https://app.codecov.io/gh/apache/grails-core/pull/16613/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
</details>
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
- :package: [JS Bundle Analysis](https://docs.codecov.com/docs/javascript-bundle-analysis): Save yourself from yourself by tracking and limiting bundle sizes in JS merges.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@grails.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Use the Grails Develocity access key for the remote build cache [grails-core]
Posted by "jdaugherty (via GitHub)" <gi...@apache.org>.
jdaugherty merged PR #16613:
URL: https://github.com/apache/grails-core/pull/16613
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@grails.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org