You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@brooklyn.apache.org by alasdairhodge <gi...@git.apache.org> on 2015/10/20 11:49:56 UTC
[GitHub] incubator-brooklyn pull request: Update ‘xml-apis’ dependency
GitHub user alasdairhodge opened a pull request:
https://github.com/apache/incubator-brooklyn/pull/970
Update ‘xml-apis’ dependency
Resolves Eclipse build errors in `XmlPlanToSpecTransformer`. Command-line Maven build was happy, possibly due to later version accidentally getting picked up via transitive dependency.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/alasdairhodge/incubator-brooklyn fix/xml-apis-version
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-brooklyn/pull/970.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #970
----
commit a80bbcfb5e05e79e0aea3882d52aa0320ca56f9d
Author: Alasdair Hodge <gi...@alasdairhodge.co.uk>
Date: 2015-10-20T09:47:22Z
Update ‘xml-apis’ dependency to version required by XmlPlanToSpecTransformer.
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-brooklyn pull request: Update ‘xml-apis’ dependency
Posted by alasdairhodge <gi...@git.apache.org>.
Github user alasdairhodge commented on the pull request:
https://github.com/apache/incubator-brooklyn/pull/970#issuecomment-149806949
Grrr, build failure is unrelated:
```
testJmxFeedIsPersistedWithPreCreatedJmxHelper(org.apache.brooklyn.feed.jmx.RebindJmxFeedTest) Time elapsed: 1.476 sec <<< FAILURE!
java.rmi.server.ExportException: Port already in use: 40127;
```
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-brooklyn pull request: Update ‘xml-apis’ dependency
Posted by alasdairhodge <gi...@git.apache.org>.
Github user alasdairhodge commented on the pull request:
https://github.com/apache/incubator-brooklyn/pull/970#issuecomment-149801969
Thanks @neykov, works a treat.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-brooklyn pull request: Update ‘xml-apis’ dependency
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/incubator-brooklyn/pull/970
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-brooklyn pull request: Update ‘xml-apis’ dependency
Posted by neykov <gi...@git.apache.org>.
Github user neykov commented on the pull request:
https://github.com/apache/incubator-brooklyn/pull/970#issuecomment-149583962
The functionality is already provided in the JRE. There's a transitive dependency on `xml-apis` coming from `domj4`, but it's web site says that: `These dependencies are only required to compile and run unit tests for the application:`. Its `pom.xml` seems to be incorrectly generated (from gradle) so it includes it as a normal compile dependency.
I'd say remove the `xml-apis` dependency altogether and exclude it from the `dom4j` dependency (which comes from `org.reflections` in `core`).
Couldn't figure out why the enforcer `DependencyConvergence` rule didn't catch the version mismatch though.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---