You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@hudi.apache.org by "alexeykudinkin (via GitHub)" <gi...@apache.org> on 2023/02/07 02:18:19 UTC
[GitHub] [hudi] alexeykudinkin opened a new pull request, #7873: [MINOR] Added safety-net check to catch any potential issue to deduce parallelism from the incoming `Dataset` appropriately
alexeykudinkin opened a new pull request, #7873:
URL: https://github.com/apache/hudi/pull/7873
…
### Change Logs
_Describe context and summary for this change. Highlight if any code was copied._
### Impact
_Describe any public API or user-facing feature change or any performance impact._
### Risk level (write none, low medium or high below)
_If medium or high, explain what verification was done to mitigate the risks._
### Documentation Update
_Describe any necessary documentation update if there is any new feature, config, or user-facing change_
- _The config description must be updated if new configs are added or the default value of the configs are changed_
- _Any new feature or user-facing change requires updating the Hudi website. Please create a Jira ticket, attach the
ticket number here and follow the [instruction](https://hudi.apache.org/contribute/developer-setup#website) to make
changes to the website._
### Contributor's checklist
- [ ] Read through [contributor's guide](https://hudi.apache.org/contribute/how-to-contribute)
- [ ] Change Logs and Impact were stated clearly
- [ ] Adequate tests were added if applicable
- [ ] CI passed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #7873: [MINOR] Added safety-net check to catch any potential issue to deduce parallelism from the incoming `Dataset` appropriately
Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #7873:
URL: https://github.com/apache/hudi/pull/7873#issuecomment-1420608673
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "0b593429c380bd6519b152b0e91ca05e5ee1bf3d",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=14978",
"triggerID" : "0b593429c380bd6519b152b0e91ca05e5ee1bf3d",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 0b593429c380bd6519b152b0e91ca05e5ee1bf3d Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=14978)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] danny0405 commented on a diff in pull request #7873: [MINOR] Added safety-net check to catch any potential issue to deduce parallelism from the incoming `Dataset` appropriately
Posted by "danny0405 (via GitHub)" <gi...@apache.org>.
danny0405 commented on code in PR #7873:
URL: https://github.com/apache/hudi/pull/7873#discussion_r1098169437
##########
hudi-client/hudi-spark-client/src/main/scala/org/apache/hudi/HoodieDatasetBulkInsertHelper.scala:
##########
@@ -203,6 +203,17 @@ object HoodieDatasetBulkInsertHelper
.values
}
+ override protected def deduceShuffleParallelism(input: DataFrame, configuredParallelism: Int): Int = {
+ val deduceParallelism = super.deduceShuffleParallelism(input, configuredParallelism)
+ // NOTE: In case parallelism deduction failed to accurately deduce parallelism level of the
+ // incoming dataset we fallback to default parallelism level set for this Spark session
+ if (deduceParallelism > 0) {
+ deduceParallelism
+ } else {
+ input.sparkSession.sparkContext.defaultParallelism
Review Comment:
Curious, only bulk_insert has this issue like deduced parallelism is 0 or nefative?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #7873: [MINOR] Added safety-net check to catch any potential issue to deduce parallelism from the incoming `Dataset` appropriately
Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #7873:
URL: https://github.com/apache/hudi/pull/7873#issuecomment-1420126764
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "0b593429c380bd6519b152b0e91ca05e5ee1bf3d",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "0b593429c380bd6519b152b0e91ca05e5ee1bf3d",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 0b593429c380bd6519b152b0e91ca05e5ee1bf3d UNKNOWN
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] codope merged pull request #7873: [MINOR] Added safety-net check to catch any potential issue to deduce parallelism from the incoming `Dataset` appropriately
Posted by "codope (via GitHub)" <gi...@apache.org>.
codope merged PR #7873:
URL: https://github.com/apache/hudi/pull/7873
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] alexeykudinkin commented on a diff in pull request #7873: [MINOR] Added safety-net check to catch any potential issue to deduce parallelism from the incoming `Dataset` appropriately
Posted by "alexeykudinkin (via GitHub)" <gi...@apache.org>.
alexeykudinkin commented on code in PR #7873:
URL: https://github.com/apache/hudi/pull/7873#discussion_r1098181956
##########
hudi-client/hudi-spark-client/src/main/scala/org/apache/hudi/HoodieDatasetBulkInsertHelper.scala:
##########
@@ -203,6 +203,17 @@ object HoodieDatasetBulkInsertHelper
.values
}
+ override protected def deduceShuffleParallelism(input: DataFrame, configuredParallelism: Int): Int = {
+ val deduceParallelism = super.deduceShuffleParallelism(input, configuredParallelism)
+ // NOTE: In case parallelism deduction failed to accurately deduce parallelism level of the
+ // incoming dataset we fallback to default parallelism level set for this Spark session
+ if (deduceParallelism > 0) {
+ deduceParallelism
+ } else {
+ input.sparkSession.sparkContext.defaultParallelism
Review Comment:
@yihua i'm gonna take it up as part of HUDI-5716
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] yihua commented on a diff in pull request #7873: [MINOR] Added safety-net check to catch any potential issue to deduce parallelism from the incoming `Dataset` appropriately
Posted by "yihua (via GitHub)" <gi...@apache.org>.
yihua commented on code in PR #7873:
URL: https://github.com/apache/hudi/pull/7873#discussion_r1098128758
##########
hudi-client/hudi-spark-client/src/main/scala/org/apache/hudi/HoodieDatasetBulkInsertHelper.scala:
##########
@@ -203,6 +203,17 @@ object HoodieDatasetBulkInsertHelper
.values
}
+ override protected def deduceShuffleParallelism(input: DataFrame, configuredParallelism: Int): Int = {
+ val deduceParallelism = super.deduceShuffleParallelism(input, configuredParallelism)
+ // NOTE: In case parallelism deduction failed to accurately deduce parallelism level of the
+ // incoming dataset we fallback to default parallelism level set for this Spark session
+ if (deduceParallelism > 0) {
+ deduceParallelism
+ } else {
+ input.sparkSession.sparkContext.defaultParallelism
Review Comment:
Could you add a follow-up for unit-testing such a case?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] alexeykudinkin commented on a diff in pull request #7873: [MINOR] Added safety-net check to catch any potential issue to deduce parallelism from the incoming `Dataset` appropriately
Posted by "alexeykudinkin (via GitHub)" <gi...@apache.org>.
alexeykudinkin commented on code in PR #7873:
URL: https://github.com/apache/hudi/pull/7873#discussion_r1098181956
##########
hudi-client/hudi-spark-client/src/main/scala/org/apache/hudi/HoodieDatasetBulkInsertHelper.scala:
##########
@@ -203,6 +203,17 @@ object HoodieDatasetBulkInsertHelper
.values
}
+ override protected def deduceShuffleParallelism(input: DataFrame, configuredParallelism: Int): Int = {
+ val deduceParallelism = super.deduceShuffleParallelism(input, configuredParallelism)
+ // NOTE: In case parallelism deduction failed to accurately deduce parallelism level of the
+ // incoming dataset we fallback to default parallelism level set for this Spark session
+ if (deduceParallelism > 0) {
+ deduceParallelism
+ } else {
+ input.sparkSession.sparkContext.defaultParallelism
Review Comment:
@yihua i'm gonna take it up as part of HUDI-5716
@danny0405 correct, it's only affecting bulk-insert row-writing path
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] danny0405 commented on a diff in pull request #7873: [MINOR] Added safety-net check to catch any potential issue to deduce parallelism from the incoming `Dataset` appropriately
Posted by "danny0405 (via GitHub)" <gi...@apache.org>.
danny0405 commented on code in PR #7873:
URL: https://github.com/apache/hudi/pull/7873#discussion_r1098169437
##########
hudi-client/hudi-spark-client/src/main/scala/org/apache/hudi/HoodieDatasetBulkInsertHelper.scala:
##########
@@ -203,6 +203,17 @@ object HoodieDatasetBulkInsertHelper
.values
}
+ override protected def deduceShuffleParallelism(input: DataFrame, configuredParallelism: Int): Int = {
+ val deduceParallelism = super.deduceShuffleParallelism(input, configuredParallelism)
+ // NOTE: In case parallelism deduction failed to accurately deduce parallelism level of the
+ // incoming dataset we fallback to default parallelism level set for this Spark session
+ if (deduceParallelism > 0) {
+ deduceParallelism
+ } else {
+ input.sparkSession.sparkContext.defaultParallelism
Review Comment:
Curious, only bulk_insert has this issue like deduced parallelism is 0 or negative?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #7873: [MINOR] Added safety-net check to catch any potential issue to deduce parallelism from the incoming `Dataset` appropriately
Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #7873:
URL: https://github.com/apache/hudi/pull/7873#issuecomment-1420132935
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "0b593429c380bd6519b152b0e91ca05e5ee1bf3d",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=14978",
"triggerID" : "0b593429c380bd6519b152b0e91ca05e5ee1bf3d",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 0b593429c380bd6519b152b0e91ca05e5ee1bf3d Azure: [PENDING](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=14978)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org