You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@arrow.apache.org by "Ji Liu (Jira)" <ji...@apache.org> on 2019/10/14 04:32:00 UTC

[jira] [Created] (ARROW-6871) [Java] Enhance TransferPair related parameters check and tests

Ji Liu created ARROW-6871:
-----------------------------

             Summary: [Java] Enhance TransferPair related parameters check and tests
                 Key: ARROW-6871
                 URL: https://issues.apache.org/jira/browse/ARROW-6871
             Project: Apache Arrow
          Issue Type: Bug
          Components: Java
            Reporter: Ji Liu
            Assignee: Ji Liu


{{TransferPair}} related param checks in different classes have potential problems:

i. {{copyValueSafe}} do not check from index, if from > valueCount, no error is shown.

ii. {{splitAndTansferPair}} has no indices check in classes like {{VarcharVector}}

iii. {{splitAndTranserPair}} indices check in classes like UnionVector is not correct (Preconditions.checkArgument(startIndex + length <= valueCount)), should check params separately.

iv. some assert usages should be replaced with {{Preconditions}}.

v. should add more UT to cover corner cases.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)