You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@nuttx.apache.org by GitBox <gi...@apache.org> on 2021/11/26 10:28:00 UTC
[GitHub] [incubator-nuttx] chrade opened a new pull request #4897: Phyplus release 1.2
chrade opened a new pull request #4897:
URL: https://github.com/apache/incubator-nuttx/pull/4897
## Summary
## Impact
## Testing
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] LingaoM commented on a change in pull request #4897: Phyplus release 1.2
Posted by GitBox <gi...@apache.org>.
LingaoM commented on a change in pull request #4897:
URL: https://github.com/apache/incubator-nuttx/pull/4897#discussion_r758079517
##########
File path: arch/arm/src/phy62xx/Kconfig
##########
@@ -0,0 +1,27 @@
+#
+# For a description of the syntax of this configuration file,
+# see the file kconfig-language.txt in the NuttX tools repository.
+#
+
+comment "PHY62xx Configuration Options"
+
+choice
+ prompt "only PHY 6222 Chip Selection"
+ default ARCH_CHIP_PHY6222
+ depends on ARCH_CHIP_PHY62XX
+
+config ARCH_CHIP_PHY6222
+ bool "PHY6222"
+endchoise
+
+config PHY6222_BLE
+ bool "enable ble"
Review comment:
Below also look like too.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] xiaoxiang781216 merged pull request #4897: Phyplus release 1.2
Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 merged pull request #4897:
URL: https://github.com/apache/incubator-nuttx/pull/4897
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] xiaoxiang781216 commented on pull request #4897: Phyplus release 1.2
Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 commented on pull request #4897:
URL: https://github.com/apache/incubator-nuttx/pull/4897#issuecomment-979925785
Please fix the warning not related to ROM Mix case symbol:
```
Warning: /home/runner/work/incubator-nuttx/incubator-nuttx/nuttx/arch/arm/include/phy62xx/phy62xx_irq.h:49:62: warning: Wrong column position of comment right of code
Warning: /home/runner/work/incubator-nuttx/incubator-nuttx/nuttx/arch/arm/include/phy62xx/phy62xx_irq.h:50:60: warning: Wrong column position of comment right of code
Warning: /home/runner/work/incubator-nuttx/incubator-nuttx/nuttx/arch/arm/include/phy62xx/phy62xx_irq.h:51:61: warning: Wrong column position of comment right of code
Warning: /home/runner/work/incubator-nuttx/incubator-nuttx/nuttx/arch/arm/include/phy62xx/phy62xx_irq.h:52:63: warning: Wrong column position of comment right of code
Warning: /home/runner/work/incubator-nuttx/incubator-nuttx/nuttx/arch/arm/include/phy62xx/phy62xx_irq.h:53:66: warning: Wrong column position of comment right of code
Warning: /home/runner/work/incubator-nuttx/incubator-nuttx/nuttx/arch/arm/include/phy62xx/phy62xx_irq.h:54:61: warning: Wrong column position of comment right of code
Warning: /home/runner/work/incubator-nuttx/incubator-nuttx/nuttx/arch/arm/include/phy62xx/phy62xx_irq.h:55:62: warning: Wrong column position of comment right of code
Warning: /home/runner/work/incubator-nuttx/incubator-nuttx/nuttx/arch/arm/include/phy62xx/phy62xx_irq.h:56:65: warning: Wrong column position of comment right of code
Warning: /home/runner/work/incubator-nuttx/incubator-nuttx/nuttx/arch/arm/include/phy62xx/phy62xx_irq.h:57:65: warning: Wrong column position of comment right of code
Warning: /home/runner/work/incubator-nuttx/incubator-nuttx/nuttx/arch/arm/include/phy62xx/phy62xx_irq.h:58:66: warning: Wrong column position of comment right of code
Warning: /home/runner/work/incubator-nuttx/incubator-nuttx/nuttx/arch/arm/include/phy62xx/phy62xx_irq.h:59:66: warning: Wrong column position of comment right of code
Warning: /home/runner/work/incubator-nuttx/incubator-nuttx/nuttx/arch/arm/include/phy62xx/phy62xx_irq.h:60:65: warning: Wrong column position of comment right of code
Warning: /home/runner/work/incubator-nuttx/incubator-nuttx/nuttx/arch/arm/include/phy62xx/phy62xx_irq.h:61:64: warning: Wrong column position of comment right of code
Warning: /home/runner/work/incubator-nuttx/incubator-nuttx/nuttx/arch/arm/include/phy62xx/phy62xx_irq.h:62:64: warning: Wrong column position of comment right of code
Warning: /home/runner/work/incubator-nuttx/incubator-nuttx/nuttx/arch/arm/include/phy62xx/phy62xx_irq.h:63:64: warning: Wrong column position of comment right of code
Warning: /home/runner/work/incubator-nuttx/incubator-nuttx/nuttx/arch/arm/include/phy62xx/phy62xx_irq.h:64:66: warning: Wrong column position of comment right of code
Warning: /home/runner/work/incubator-nuttx/incubator-nuttx/nuttx/arch/arm/include/phy62xx/phy62xx_irq.h:65:65: warning: Wrong column position of comment right of code
Warning: /home/runner/work/incubator-nuttx/incubator-nuttx/nuttx/arch/arm/include/phy62xx/phy62xx_irq.h:66:65: warning: Wrong column position of comment right of code
Warning: /home/runner/work/incubator-nuttx/incubator-nuttx/nuttx/arch/arm/include/phy62xx/phy62xx_irq.h:69:63: warning: Wrong column position of comment right of code
Warning: /home/runner/work/incubator-nuttx/incubator-nuttx/nuttx/arch/arm/include/phy62xx/phy62xx_irq.h:70:66: warning: Wrong column position of comment right of code
Warning: /home/runner/work/incubator-nuttx/incubator-nuttx/nuttx/arch/arm/include/phy62xx/phy62xx_irq.h:71:65: warning: Wrong column position of comment right of code
Error: /home/runner/work/incubator-nuttx/incubator-nuttx/nuttx/arch/arm/src/phy62xx/phyplus_timerisr.h:1:77: error: Carriage returns found. First detected
Error: /home/runner/work/incubator-nuttx/incubator-nuttx/nuttx/arch/arm/src/phy62xx/phyplus_timerisr.h:1:78: error: Long line found
Error: /home/runner/work/incubator-nuttx/incubator-nuttx/nuttx/arch/arm/src/phy62xx/phyplus_timerisr.h:2:1: error: Relative file path does not match actual file
Error: /home/runner/work/incubator-nuttx/incubator-nuttx/nuttx/arch/arm/src/phy62xx/pplus_mtd_flash.c:380:0: error: No indentation line
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] LingaoM commented on a change in pull request #4897: Phyplus release 1.2
Posted by GitBox <gi...@apache.org>.
LingaoM commented on a change in pull request #4897:
URL: https://github.com/apache/incubator-nuttx/pull/4897#discussion_r758078303
##########
File path: arch/arm/include/phy62xx/phy62xx_irq.h
##########
@@ -0,0 +1,104 @@
+/****************************************************************************
+ * arch/arm/include/phy62xx/phy62xx_irq.h
+ *
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership. The
+ * ASF licenses this file to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance with the
+ * License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS, WITHOUT
+ * WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the
+ * License for the specific language governing permissions and limitations
+ * under the License.
+ *
+ ****************************************************************************/
+
+/* This file should never be included directly but, rather, only indirectly
+ * through nuttx/irq.h
+ */
+
+#ifndef __ARCH_ARM_INCLUDE_STM32F0L0G0_STM32F0_IRQ_H
+#define __ARCH_ARM_INCLUDE_STM32F0L0G0_STM32F0_IRQ_H
Review comment:
What this?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] LingaoM commented on a change in pull request #4897: Phyplus release 1.2
Posted by GitBox <gi...@apache.org>.
LingaoM commented on a change in pull request #4897:
URL: https://github.com/apache/incubator-nuttx/pull/4897#discussion_r758079025
##########
File path: arch/arm/src/phy62xx/Kconfig
##########
@@ -0,0 +1,27 @@
+#
+# For a description of the syntax of this configuration file,
+# see the file kconfig-language.txt in the NuttX tools repository.
+#
+
+comment "PHY62xx Configuration Options"
+
+choice
+ prompt "only PHY 6222 Chip Selection"
+ default ARCH_CHIP_PHY6222
+ depends on ARCH_CHIP_PHY62XX
+
+config ARCH_CHIP_PHY6222
+ bool "PHY6222"
+endchoise
+
+config PHY6222_BLE
+ bool "enable ble"
Review comment:
```suggestion
bool "Enable ble"
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org