[GitHub] [pulsar] michaeljmarshall commented on a diff in pull request #18898: [fix][misc] do not require encryption on system topics

[GitBox <gi...@apache.org>]

michaeljmarshall commented on code in PR #18898:
URL: https://github.com/apache/pulsar/pull/18898#discussion_r1047522423


##########
pulsar-broker/src/main/java/org/apache/pulsar/broker/service/persistent/SystemTopic.java:
##########
@@ -76,4 +76,10 @@ public boolean isCompactionEnabled() {
         // even though is not explicitly set in the policies.
         return !NamespaceService.isHeartbeatNamespace(TopicName.get(topic));
     }
+
+    @Override
+    public boolean isEncryptionRequired() {
+        // System topics are only written by the broker that can't know the encryption context.

Review Comment:
   It's tangential, but have we explicitly stated the limitation that system topics are only written to by the broker?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org