You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@iceberg.apache.org by GitBox <gi...@apache.org> on 2020/01/07 19:10:08 UTC
[GitHub] [incubator-iceberg] Voltir opened a new pull request #727: Fix for
#245
Voltir opened a new pull request #727: Fix for #245
URL: https://github.com/apache/incubator-iceberg/pull/727
Shades google.common to fix a conflicting versions used by spark 2.4.x
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [incubator-iceberg] Voltir commented on issue #727: Fix for #245
Posted by GitBox <gi...@apache.org>.
Voltir commented on issue #727: Fix for #245
URL: https://github.com/apache/incubator-iceberg/pull/727#issuecomment-572176172
Ah, you are right. I don't fully understand how shading / relocating works :/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [incubator-iceberg] chenjunjiedada commented on issue #727: Fix for
#245
Posted by GitBox <gi...@apache.org>.
chenjunjiedada commented on issue #727: Fix for #245
URL: https://github.com/apache/incubator-iceberg/pull/727#issuecomment-571940333
@Voltir , I see the line right before your added line did the shade job. Does that not work?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [incubator-iceberg] Voltir closed pull request #727: Fix for #245
Posted by GitBox <gi...@apache.org>.
Voltir closed pull request #727: Fix for #245
URL: https://github.com/apache/incubator-iceberg/pull/727
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [incubator-iceberg] Voltir commented on issue #727: Fix for #245
Posted by GitBox <gi...@apache.org>.
Voltir commented on issue #727: Fix for #245
URL: https://github.com/apache/incubator-iceberg/pull/727#issuecomment-572187691
@chenjunjiedada What do you make of this though:
```
jar -tf ~/Downloads/iceberg-spark-runtime-0.7.0-incubating.jar | grep guava | head
META-INF/maven/org.apache.avro/avro-guava-dependencies/
META-INF/maven/org.apache.avro/avro-guava-dependencies/pom.xml
META-INF/maven/org.apache.avro/avro-guava-dependencies/pom.properties
META-INF/maven/com.google.guava/
META-INF/maven/com.google.guava/guava/
META-INF/maven/com.google.guava/guava/pom.xml
META-INF/maven/com.google.guava/guava/pom.properties
META-INF/maven/com.google.guava/failureaccess/
META-INF/maven/com.google.guava/failureaccess/pom.properties
META-INF/maven/com.google.guava/failureaccess/pom.xml
```
It appears guava isnt shaded (and might be the source of our issues)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org