You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@wicket.apache.org by Johan Compagner <jc...@gmail.com> on 2007/08/31 19:51:04 UTC
Re: [jira] Created: (WICKET-911) refactor feedback to allow users to easily add custom levels
ha... also my idea :)
On 8/31/07, Igor Vaynberg (JIRA) <ji...@apache.org> wrote:
>
> refactor feedback to allow users to easily add custom levels
> ------------------------------------------------------------
>
> Key: WICKET-911
> URL: https://issues.apache.org/jira/browse/WICKET-911
> Project: Wicket
> Issue Type: Improvement
> Components: wicket
> Affects Versions: 1.3.0-final
> Reporter: Igor Vaynberg
> Fix For: 1.4.0-alpha
>
>
> we have preset levels of fatal/error/warn/info, but users keep asking for
> more, such as sucess, see WICKET-907. we should probably refactor feedback
> to have
>
> component.addfeedback(feedbackmessage) instead of having ten methods for
> prebuild levels. as far as i can see wicket doesnt need to know if the
> message is error or success so there is no point in having a more
> complicated system.
>
> --
> This message is automatically generated by JIRA.
> -
> You can reply to this email to add a comment to the issue online.
>
>
Re: [jira] Created: (WICKET-911) refactor feedback to allow users to easily add custom levels
Posted by Igor Vaynberg <ig...@gmail.com>.
ick, just create whatever subclasses of feedbackmessage you need
and use those
it will probably have a abstract string getlevel(), afict it is only the
feedbackpanel that needs to know the level so it can set the appropriate css
class, and message filters for filtering.
there is no semantic meaning behind error/info/etc
-igor
On 8/31/07, Martijn Dashorst <ma...@gmail.com> wrote:
>
> addFeedback(String class, String message)
> addFeedback(String class, IModel message)
>
> But before you know it, we're implementing Log4j in our feedback
> mechanism. Isn't there a JSR that standardizes this and we could
> implement/get inspiration on?
>
> Martijn
>
> On 8/31/07, Johan Compagner <jc...@gmail.com> wrote:
> > ha... also my idea :)
> >
> > On 8/31/07, Igor Vaynberg (JIRA) <ji...@apache.org> wrote:
> > >
> > > refactor feedback to allow users to easily add custom levels
> > > ------------------------------------------------------------
> > >
> > > Key: WICKET-911
> > > URL: https://issues.apache.org/jira/browse/WICKET-911
> > > Project: Wicket
> > > Issue Type: Improvement
> > > Components: wicket
> > > Affects Versions: 1.3.0-final
> > > Reporter: Igor Vaynberg
> > > Fix For: 1.4.0-alpha
> > >
> > >
> > > we have preset levels of fatal/error/warn/info, but users keep asking
> for
> > > more, such as sucess, see WICKET-907. we should probably refactor
> feedback
> > > to have
> > >
> > > component.addfeedback(feedbackmessage) instead of having ten methods
> for
> > > prebuild levels. as far as i can see wicket doesnt need to know if the
> > > message is error or success so there is no point in having a more
> > > complicated system.
> > >
> > > --
> > > This message is automatically generated by JIRA.
> > > -
> > > You can reply to this email to add a comment to the issue online.
> > >
> > >
> >
>
>
> --
> Buy Wicket in Action: http://manning.com/dashorst
> Apache Wicket 1.3.0-beta3 is released
> Get it now: http://www.apache.org/dyn/closer.cgi/wicket/1.3.0-beta3/
>
Re: [jira] Created: (WICKET-911) refactor feedback to allow users to easily add custom levels
Posted by Martijn Dashorst <ma...@gmail.com>.
addFeedback(String class, String message)
addFeedback(String class, IModel message)
But before you know it, we're implementing Log4j in our feedback
mechanism. Isn't there a JSR that standardizes this and we could
implement/get inspiration on?
Martijn
On 8/31/07, Johan Compagner <jc...@gmail.com> wrote:
> ha... also my idea :)
>
> On 8/31/07, Igor Vaynberg (JIRA) <ji...@apache.org> wrote:
> >
> > refactor feedback to allow users to easily add custom levels
> > ------------------------------------------------------------
> >
> > Key: WICKET-911
> > URL: https://issues.apache.org/jira/browse/WICKET-911
> > Project: Wicket
> > Issue Type: Improvement
> > Components: wicket
> > Affects Versions: 1.3.0-final
> > Reporter: Igor Vaynberg
> > Fix For: 1.4.0-alpha
> >
> >
> > we have preset levels of fatal/error/warn/info, but users keep asking for
> > more, such as sucess, see WICKET-907. we should probably refactor feedback
> > to have
> >
> > component.addfeedback(feedbackmessage) instead of having ten methods for
> > prebuild levels. as far as i can see wicket doesnt need to know if the
> > message is error or success so there is no point in having a more
> > complicated system.
> >
> > --
> > This message is automatically generated by JIRA.
> > -
> > You can reply to this email to add a comment to the issue online.
> >
> >
>
--
Buy Wicket in Action: http://manning.com/dashorst
Apache Wicket 1.3.0-beta3 is released
Get it now: http://www.apache.org/dyn/closer.cgi/wicket/1.3.0-beta3/