You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@directory.apache.org by "Alex Karasulu (JIRA)" <ji...@apache.org> on 2008/07/09 20:57:31 UTC
[jira] Created: (DIRSHARED-12) Remove the code taken from
BouncyCastle since we now depend on bouncy castle.
Remove the code taken from BouncyCastle since we now depend on bouncy castle.
-----------------------------------------------------------------------------
Key: DIRSHARED-12
URL: https://issues.apache.org/jira/browse/DIRSHARED-12
Project: Directory Shared
Issue Type: Task
Reporter: Alex Karasulu
We have a dep on bc now so there's no need for the forked classes in shared-asn1
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (DIRSHARED-12) Remove the code taken from
BouncyCastle since we now depend on bouncy castle.
Posted by "Felix Knecht (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/DIRSHARED-12?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12871599#action_12871599 ]
Felix Knecht commented on DIRSHARED-12:
---------------------------------------
I give it a try. The main methods missing are the static methods X.valueOf(...).
Can I rely on the test cases - meaning I suppose it as solved when test cases are working?
> Remove the code taken from BouncyCastle since we now depend on bouncy castle.
> -----------------------------------------------------------------------------
>
> Key: DIRSHARED-12
> URL: https://issues.apache.org/jira/browse/DIRSHARED-12
> Project: Directory Shared
> Issue Type: Task
> Reporter: Alex Karasulu
> Assignee: Felix Knecht
> Fix For: 1.1.0
>
>
> We have a dep on bc now so there's no need for the forked classes in shared-asn1
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (DIRSHARED-12) Remove the code taken from
BouncyCastle since we now depend on bouncy castle.
Posted by "Emmanuel Lecharny (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/DIRSHARED-12?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12871605#action_12871605 ]
Emmanuel Lecharny commented on DIRSHARED-12:
--------------------------------------------
It's a bit more complicated : Kerberos heavily depend on shared-asn1, and many added methods aren't present in the BC classes. We can easily fix the intValue() method by getValue().intValue(), the same for getOctets() which is already existing as getBytes().
The main problem is the DERSequence.add( DERObject ) which does not exist in BC, and this is a major show-stopper.
> Remove the code taken from BouncyCastle since we now depend on bouncy castle.
> -----------------------------------------------------------------------------
>
> Key: DIRSHARED-12
> URL: https://issues.apache.org/jira/browse/DIRSHARED-12
> Project: Directory Shared
> Issue Type: Task
> Reporter: Alex Karasulu
> Assignee: Felix Knecht
> Fix For: 1.1.0
>
>
> We have a dep on bc now so there's no need for the forked classes in shared-asn1
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (DIRSHARED-12) Remove the code taken from
BouncyCastle since we now depend on bouncy castle.
Posted by "Emmanuel Lecharny (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/DIRSHARED-12?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12871549#action_12871549 ]
Emmanuel Lecharny commented on DIRSHARED-12:
--------------------------------------------
Hmmm, rigth, I forgot about this one. This was probably the reason why we created this JIRA at the first place...
> Remove the code taken from BouncyCastle since we now depend on bouncy castle.
> -----------------------------------------------------------------------------
>
> Key: DIRSHARED-12
> URL: https://issues.apache.org/jira/browse/DIRSHARED-12
> Project: Directory Shared
> Issue Type: Task
> Reporter: Alex Karasulu
> Assignee: Felix Knecht
> Fix For: 0.9.20
>
>
> We have a dep on bc now so there's no need for the forked classes in shared-asn1
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (DIRSHARED-12) Remove the code taken from
BouncyCastle since we now depend on bouncy castle.
Posted by "Emmanuel Lecharny (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/DIRSHARED-12?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Emmanuel Lecharny updated DIRSHARED-12:
---------------------------------------
Fix Version/s: 0.9.20
(was: 1.0.0-RC1)
> Remove the code taken from BouncyCastle since we now depend on bouncy castle.
> -----------------------------------------------------------------------------
>
> Key: DIRSHARED-12
> URL: https://issues.apache.org/jira/browse/DIRSHARED-12
> Project: Directory Shared
> Issue Type: Task
> Reporter: Alex Karasulu
> Fix For: 0.9.20
>
>
> We have a dep on bc now so there's no need for the forked classes in shared-asn1
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (DIRSHARED-12) Remove the code taken from
BouncyCastle since we now depend on bouncy castle.
Posted by "Emmanuel Lecharny (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/DIRSHARED-12?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Emmanuel Lecharny updated DIRSHARED-12:
---------------------------------------
Fix Version/s: 1.1.0
(was: 0.9.20)
Postponed
> Remove the code taken from BouncyCastle since we now depend on bouncy castle.
> -----------------------------------------------------------------------------
>
> Key: DIRSHARED-12
> URL: https://issues.apache.org/jira/browse/DIRSHARED-12
> Project: Directory Shared
> Issue Type: Task
> Reporter: Alex Karasulu
> Assignee: Felix Knecht
> Fix For: 1.1.0
>
>
> We have a dep on bc now so there's no need for the forked classes in shared-asn1
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (DIRSHARED-12) Remove the code taken from
BouncyCastle since we now depend on bouncy castle.
Posted by "Emmanuel Lecharny (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/DIRSHARED-12?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Emmanuel Lecharny updated DIRSHARED-12:
---------------------------------------
Fix Version/s: 1.0.0
> Remove the code taken from BouncyCastle since we now depend on bouncy castle.
> -----------------------------------------------------------------------------
>
> Key: DIRSHARED-12
> URL: https://issues.apache.org/jira/browse/DIRSHARED-12
> Project: Directory Shared
> Issue Type: Task
> Reporter: Alex Karasulu
> Fix For: 1.0.0
>
>
> We have a dep on bc now so there's no need for the forked classes in shared-asn1
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Reopened: (DIRSHARED-12) Remove the code taken from
BouncyCastle since we now depend on bouncy castle.
Posted by "Felix Knecht (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/DIRSHARED-12?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Felix Knecht reopened DIRSHARED-12:
-----------------------------------
Assignee: Felix Knecht
The package shared/asn1/src/main/java/org/apache/directory/shared/asn1/der seems to be a copy of bouncy castle classes.
> Remove the code taken from BouncyCastle since we now depend on bouncy castle.
> -----------------------------------------------------------------------------
>
> Key: DIRSHARED-12
> URL: https://issues.apache.org/jira/browse/DIRSHARED-12
> Project: Directory Shared
> Issue Type: Task
> Reporter: Alex Karasulu
> Assignee: Felix Knecht
> Fix For: 0.9.20
>
>
> We have a dep on bc now so there's no need for the forked classes in shared-asn1
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (DIRSHARED-12) Remove the code taken from
BouncyCastle since we now depend on bouncy castle.
Posted by "Felix Knecht (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/DIRSHARED-12?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12871306#action_12871306 ]
Felix Knecht commented on DIRSHARED-12:
---------------------------------------
I can the the dependency, neither in shared/pom.xml nor in shared/asn1/pom.xml. Is it already there?
Do we have a license problem here?
BouncyCastle License isn't part of the authorized third party licenses by apache [1]. BouncyCastle says "our license is an adaptation of the MIT X11 License and should be read as such." [2]. To me (as a not native english speaker) it's not very clean if "should be read as MIT X11 License" or "should be read as adaption". At least for the 2nd interpretation I'm not sure if we're allowed to use.
[1] http://www.apache.org/legal/3party.html
[2] http://www.bouncycastle.org/licence.html
> Remove the code taken from BouncyCastle since we now depend on bouncy castle.
> -----------------------------------------------------------------------------
>
> Key: DIRSHARED-12
> URL: https://issues.apache.org/jira/browse/DIRSHARED-12
> Project: Directory Shared
> Issue Type: Task
> Reporter: Alex Karasulu
> Fix For: 1.0.0-RC1
>
>
> We have a dep on bc now so there's no need for the forked classes in shared-asn1
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Resolved: (DIRSHARED-12) Remove the code taken from
BouncyCastle since we now depend on bouncy castle.
Posted by "Emmanuel Lecharny (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/DIRSHARED-12?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Emmanuel Lecharny resolved DIRSHARED-12.
----------------------------------------
Resolution: Fixed
We use BC 40 in ApacheDS.
The license is a direct derivation from MIT license, which is fully compatible with ASL 2.0. The only difference with the MIT license is the "Bouncy Castle" name in top of it.
I think we are 100% safe here.
> Remove the code taken from BouncyCastle since we now depend on bouncy castle.
> -----------------------------------------------------------------------------
>
> Key: DIRSHARED-12
> URL: https://issues.apache.org/jira/browse/DIRSHARED-12
> Project: Directory Shared
> Issue Type: Task
> Reporter: Alex Karasulu
> Fix For: 1.0.0-RC1
>
>
> We have a dep on bc now so there's no need for the forked classes in shared-asn1
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (DIRSHARED-12) Remove the code taken from
BouncyCastle since we now depend on bouncy castle.
Posted by "Emmanuel Lecharny (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/DIRSHARED-12?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12871558#action_12871558 ]
Emmanuel Lecharny commented on DIRSHARED-12:
--------------------------------------------
I tried to use the BC classes instead of those we have in the shared-asn1 package, but sadly those classes were heavily modified to allow some specific manipulations. We can't get rid of them atm.
> Remove the code taken from BouncyCastle since we now depend on bouncy castle.
> -----------------------------------------------------------------------------
>
> Key: DIRSHARED-12
> URL: https://issues.apache.org/jira/browse/DIRSHARED-12
> Project: Directory Shared
> Issue Type: Task
> Reporter: Alex Karasulu
> Assignee: Felix Knecht
> Fix For: 1.1.0
>
>
> We have a dep on bc now so there's no need for the forked classes in shared-asn1
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Issue Comment Edited: (DIRSHARED-12) Remove the code taken
from BouncyCastle since we now depend on bouncy castle.
Posted by "Felix Knecht (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/DIRSHARED-12?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12871306#action_12871306 ]
Felix Knecht edited comment on DIRSHARED-12 at 5/25/10 3:23 PM:
----------------------------------------------------------------
I can't find the dependency, neither in shared/pom.xml nor in shared/asn1/pom.xml. Is it already there?
Do we have a license problem here?
BouncyCastle License isn't part of the authorized third party licenses by apache [1]. BouncyCastle says "our license is an adaptation of the MIT X11 License and should be read as such." [2]. To me (as a not native english speaker) it's not very clean if "should be read as MIT X11 License" or "should be read as adaption". At least for the 2nd interpretation I'm not sure if we're allowed to use.
[1] http://www.apache.org/legal/3party.html
[2] http://www.bouncycastle.org/licence.html
was (Author: felixk):
I can the the dependency, neither in shared/pom.xml nor in shared/asn1/pom.xml. Is it already there?
Do we have a license problem here?
BouncyCastle License isn't part of the authorized third party licenses by apache [1]. BouncyCastle says "our license is an adaptation of the MIT X11 License and should be read as such." [2]. To me (as a not native english speaker) it's not very clean if "should be read as MIT X11 License" or "should be read as adaption". At least for the 2nd interpretation I'm not sure if we're allowed to use.
[1] http://www.apache.org/legal/3party.html
[2] http://www.bouncycastle.org/licence.html
> Remove the code taken from BouncyCastle since we now depend on bouncy castle.
> -----------------------------------------------------------------------------
>
> Key: DIRSHARED-12
> URL: https://issues.apache.org/jira/browse/DIRSHARED-12
> Project: Directory Shared
> Issue Type: Task
> Reporter: Alex Karasulu
> Fix For: 1.0.0-RC1
>
>
> We have a dep on bc now so there's no need for the forked classes in shared-asn1
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.