You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@thrift.apache.org by "Eric Anderson (JIRA)" <ji...@apache.org> on 2008/07/10 08:31:33 UTC
[jira] Created: (THRIFT-71) Debian packaging for thrift
Debian packaging for thrift
---------------------------
Key: THRIFT-71
URL: https://issues.apache.org/jira/browse/THRIFT-71
Project: Thrift
Issue Type: Improvement
Environment: debian stable (etch); probably will work on lenny, but untested
Reporter: Eric Anderson
We're using thrift on Debian, so I wanted to have a package for easier
installation by other users.
Attached is a patch to add packaging for debian to the
thrift-20080411p1 release. It includes two bug fixes to make the
tests work reliably: 1) adding /usr/share/java/commons-lang.jar to the
search path for the java tests, and 2) sleeping 1 second after
starting the server for the python tests. If the patch is accepted,
the maintainer should probably be set to the thrift mailing list,
rather than the example mailing list address I used.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (THRIFT-71) Debian packaging for thrift
Posted by "Esteve Fernandez (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/THRIFT-71?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12919787#action_12919787 ]
Esteve Fernandez commented on THRIFT-71:
----------------------------------------
@Roger
Sure, +1 to both
@David
I think you're right, the Debian packaging guide says something about it's better not having a debian directory at the top level. However, the important thing is that the debian directory should not be shipped with the release tarball, but in a separate diff.
> Debian packaging for thrift
> ---------------------------
>
> Key: THRIFT-71
> URL: https://issues.apache.org/jira/browse/THRIFT-71
> Project: Thrift
> Issue Type: Improvement
> Environment: debian stable (etch); probably will work on lenny, but untested
> Reporter: Eric Anderson
> Priority: Minor
> Attachments: debian-packaging.patch, thrift-71.patch, thrift-71_v2.patch, thrift-71_v3.patch, thrift-71_v4.patch, thrift-71_v5.patch, thrift-71_v6.patch, thrift-71_v7.patch, THRIFT-71_v8_0.5.0.patch
>
>
> We're using thrift on Debian, so I wanted to have a package for easier
> installation by other users.
> Attached is a patch to add packaging for debian to the
> thrift-20080411p1 release. It includes two bug fixes to make the
> tests work reliably: 1) adding /usr/share/java/commons-lang.jar to the
> search path for the java tests, and 2) sleeping 1 second after
> starting the server for the python tests. If the patch is accepted,
> the maintainer should probably be set to the thrift mailing list,
> rather than the example mailing list address I used.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (THRIFT-71) Debian packaging for thrift
Posted by "Esteve Fernandez (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/THRIFT-71?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Esteve Fernandez updated THRIFT-71:
-----------------------------------
Attachment: thrift-71.patch
This patch breaks Thrift down into smaller packages, one for each language library.
> Debian packaging for thrift
> ---------------------------
>
> Key: THRIFT-71
> URL: https://issues.apache.org/jira/browse/THRIFT-71
> Project: Thrift
> Issue Type: Improvement
> Environment: debian stable (etch); probably will work on lenny, but untested
> Reporter: Eric Anderson
> Priority: Minor
> Attachments: debian-packaging.patch, thrift-71.patch
>
>
> We're using thrift on Debian, so I wanted to have a package for easier
> installation by other users.
> Attached is a patch to add packaging for debian to the
> thrift-20080411p1 release. It includes two bug fixes to make the
> tests work reliably: 1) adding /usr/share/java/commons-lang.jar to the
> search path for the java tests, and 2) sleeping 1 second after
> starting the server for the python tests. If the patch is accepted,
> the maintainer should probably be set to the thrift mailing list,
> rather than the example mailing list address I used.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (THRIFT-71) Debian packaging for thrift
Posted by "Esteve Fernandez (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/THRIFT-71?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12661078#action_12661078 ]
Esteve Fernandez commented on THRIFT-71:
----------------------------------------
Michael: Actually there's a C# package (libthrift-cil), but I don't have much experience with CIL libraries in Debian/Ubuntu, so I don't know if it's packaged properly.
Anyway, I use that repository for testing purposes, you should use txamqpteam's PPA (https://launchpad.net/~txamqpteam/+archive), which includes a Debian/Ubuntu package for txAMQP. I didn't bother to send the diff because there seemed to be no interest in this issue (last comment was from July) and there are no release plans (Thrift won't be included in Debian unless there's an actual release), but I'll gladly attach it if someone wants to apply it.
> Debian packaging for thrift
> ---------------------------
>
> Key: THRIFT-71
> URL: https://issues.apache.org/jira/browse/THRIFT-71
> Project: Thrift
> Issue Type: Improvement
> Environment: debian stable (etch); probably will work on lenny, but untested
> Reporter: Eric Anderson
> Priority: Minor
> Attachments: debian-packaging.patch
>
>
> We're using thrift on Debian, so I wanted to have a package for easier
> installation by other users.
> Attached is a patch to add packaging for debian to the
> thrift-20080411p1 release. It includes two bug fixes to make the
> tests work reliably: 1) adding /usr/share/java/commons-lang.jar to the
> search path for the java tests, and 2) sleeping 1 second after
> starting the server for the python tests. If the patch is accepted,
> the maintainer should probably be set to the thrift mailing list,
> rather than the example mailing list address I used.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (THRIFT-71) Debian packaging for thrift
Posted by "Esteve Fernandez (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/THRIFT-71?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Esteve Fernandez updated THRIFT-71:
-----------------------------------
Attachment: thrift-71_v5.patch
Depend on openjdk-6-jdk | java-sdk, as per Todd's suggestion.
> Debian packaging for thrift
> ---------------------------
>
> Key: THRIFT-71
> URL: https://issues.apache.org/jira/browse/THRIFT-71
> Project: Thrift
> Issue Type: Improvement
> Environment: debian stable (etch); probably will work on lenny, but untested
> Reporter: Eric Anderson
> Priority: Minor
> Attachments: debian-packaging.patch, thrift-71.patch, thrift-71_v2.patch, thrift-71_v3.patch, thrift-71_v4.patch, thrift-71_v5.patch
>
>
> We're using thrift on Debian, so I wanted to have a package for easier
> installation by other users.
> Attached is a patch to add packaging for debian to the
> thrift-20080411p1 release. It includes two bug fixes to make the
> tests work reliably: 1) adding /usr/share/java/commons-lang.jar to the
> search path for the java tests, and 2) sleeping 1 second after
> starting the server for the python tests. If the patch is accepted,
> the maintainer should probably be set to the thrift mailing list,
> rather than the example mailing list address I used.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (THRIFT-71) Debian packaging for thrift
Posted by "Esteve Fernandez (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/THRIFT-71?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12672353#action_12672353 ]
Esteve Fernandez commented on THRIFT-71:
----------------------------------------
The python-all-dbg* stuff should be optional. We could simply have two separate debian/control files, one which depends on it and another one that doesn't, it could be part of a "release" make target.. if we ever make a release ;-)
As for the C# part, I'm not sure if etch could build it after all. It ships with Mono 1.2.2, which IMHO is too old to /lang:linq, but I don't really know though, I'm no C# expert. Michael is the person to ask :-) Anyway, could you install mono-gmcs from etch-backports and try to build Thrift?
> Debian packaging for thrift
> ---------------------------
>
> Key: THRIFT-71
> URL: https://issues.apache.org/jira/browse/THRIFT-71
> Project: Thrift
> Issue Type: Improvement
> Environment: debian stable (etch); probably will work on lenny, but untested
> Reporter: Eric Anderson
> Priority: Minor
> Attachments: debian-packaging.patch, thrift-71.patch, thrift-71_v2.patch, thrift-71_v3.patch, thrift-71_v4.patch, thrift-71_v5.patch
>
>
> We're using thrift on Debian, so I wanted to have a package for easier
> installation by other users.
> Attached is a patch to add packaging for debian to the
> thrift-20080411p1 release. It includes two bug fixes to make the
> tests work reliably: 1) adding /usr/share/java/commons-lang.jar to the
> search path for the java tests, and 2) sleeping 1 second after
> starting the server for the python tests. If the patch is accepted,
> the maintainer should probably be set to the thrift mailing list,
> rather than the example mailing list address I used.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Issue Comment Edited: (THRIFT-71) Debian packaging for
thrift
Posted by "Todd Lipcon (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/THRIFT-71?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12672344#action_12672344 ]
tlipcon edited comment on THRIFT-71 at 2/10/09 10:26 AM:
-------------------------------------------------------------
Couple more thoughts upon trying to build:
- The python-all-dbg build depend doesn't seem to exist for etch - it's new in lenny/sid. Removing it causes issues building the libthrift-python-dbg package of course. Not sure what the best course of action is here.
- Good point on erlang-nox. The build-depend on erlang-base should also be erlang-nox then, since erlang-base-hipe is a valid alternative. Or, we could do erlang-base | erlang-base-hipe. I'm not sure exactly what the dependency structure looks like here and how dpkg satisfies them, but you seem to have a much better grasp than I do :)
- Confirmed that openjdk-6-jdk is too specific of a depend above - I don't have that package, but use sun-java6-jdk instead. Doing the | approach seems fine as you suggested.
- EDITED: had a csharp problem here, but looks like that's just THRIFT-309. Had a race condition with Esteve telling me about it ;-)
I'd like to say we should just drop etch support, but unfortunately Amie Street (and i'm guessing some others) are still deploying on it, so it's a blocker for adopting this deb.
-Todd
was (Author: tlipcon):
Couple more thoughts upon trying to build:
- The python-all-dbg build depend doesn't seem to exist for etch - it's new in lenny/sid. Removing it causes issues building the libthrift-python-dbg package of course. Not sure what the best course of action is here.
- Good point on erlang-nox. The build-depend on erlang-base should also be erlang-nox then, since erlang-base-hipe is a valid alternative. Or, we could do erlang-base | erlang-base-hipe. I'm not sure exactly what the dependency structure looks like here and how dpkg satisfies them, but you seem to have a much better grasp than I do :)
- Confirmed that openjdk-6-jdk is too specific of a depend above - I don't have that package, but use sun-java6-jdk instead. Doing the | approach seems fine as you suggested.
- Getting this error on the csharp build:
{noformat}
gmcs src/Protocol/TBase.cs src/Protocol/TProtocolException.cs src/Protocol/TProtocolFactory.cs src/Protocol/TList.cs src/Protocol/TSet.cs src/Protocol/TMap.cs src/Protocol/TProtocolUtil.cs src/Protocol/TMessageType.cs src/Protocol/TProtocol.cs src/Protocol/TType.cs src/Protocol/TField.cs src/Protocol/TMessage.cs src/Protocol/TStruct.cs src/Protocol/TBinaryProtocol.cs src/Server/TThreadedServer.cs src/Server/TThreadPoolServer.cs src/Server/TSimpleServer.cs src/Server/TServer.cs src/Transport/TBufferedTransport.cs src/Transport/TTransport.cs src/Transport/TSocket.cs src/Transport/TTransportException.cs src/Transport/TStreamTransport.cs src/Transport/TServerTransport.cs src/Transport/TServerSocket.cs src/Transport/TTransportFactory.cs src/TProcessor.cs src/TApplicationException.cs /out:Thrift.dll /target:library /langversion:linq
error CS1617: Invalid option `linq' for /langversion. It must be either `ISO-1' or `Default'
Compilation failed: 1 error(s), 0 warnings
{noformat}
I have never touched csharp to be honest, so not sure what this is about. I'm guessing it's etch-specific as well.
I'd like to say we should just drop etch support, but unfortunately Amie Street (and i'm guessing some others) are still deploying on it, so it's a blocker for adopting this deb.
-Todd
> Debian packaging for thrift
> ---------------------------
>
> Key: THRIFT-71
> URL: https://issues.apache.org/jira/browse/THRIFT-71
> Project: Thrift
> Issue Type: Improvement
> Environment: debian stable (etch); probably will work on lenny, but untested
> Reporter: Eric Anderson
> Priority: Minor
> Attachments: debian-packaging.patch, thrift-71.patch, thrift-71_v2.patch, thrift-71_v3.patch, thrift-71_v4.patch, thrift-71_v5.patch
>
>
> We're using thrift on Debian, so I wanted to have a package for easier
> installation by other users.
> Attached is a patch to add packaging for debian to the
> thrift-20080411p1 release. It includes two bug fixes to make the
> tests work reliably: 1) adding /usr/share/java/commons-lang.jar to the
> search path for the java tests, and 2) sleeping 1 second after
> starting the server for the python tests. If the patch is accepted,
> the maintainer should probably be set to the thrift mailing list,
> rather than the example mailing list address I used.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (THRIFT-71) Debian packaging for thrift
Posted by "Thomas Koch (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/THRIFT-71?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12902085#action_12902085 ]
Thomas Koch commented on THRIFT-71:
-----------------------------------
Wouldn't it be the easiest thing to do to help Eric Evans to get thrift into Debian? Just look again at http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=524135
> Debian packaging for thrift
> ---------------------------
>
> Key: THRIFT-71
> URL: https://issues.apache.org/jira/browse/THRIFT-71
> Project: Thrift
> Issue Type: Improvement
> Environment: debian stable (etch); probably will work on lenny, but untested
> Reporter: Eric Anderson
> Priority: Minor
> Attachments: debian-packaging.patch, thrift-71.patch, thrift-71_v2.patch, thrift-71_v3.patch, thrift-71_v4.patch, thrift-71_v5.patch, thrift-71_v6.patch, thrift-71_v7.patch
>
>
> We're using thrift on Debian, so I wanted to have a package for easier
> installation by other users.
> Attached is a patch to add packaging for debian to the
> thrift-20080411p1 release. It includes two bug fixes to make the
> tests work reliably: 1) adding /usr/share/java/commons-lang.jar to the
> search path for the java tests, and 2) sleeping 1 second after
> starting the server for the python tests. If the patch is accepted,
> the maintainer should probably be set to the thrift mailing list,
> rather than the example mailing list address I used.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (THRIFT-71) Debian packaging for thrift
Posted by "Todd Lipcon (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/THRIFT-71?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12706266#action_12706266 ]
Todd Lipcon commented on THRIFT-71:
-----------------------------------
I don't have a clean patch available at the moment, but I had to make the following changes:
- Remove libcommons-lang-java and liblog4j1.2-java from build depends now that Ivy is used for the Java lib
- Get rid of the -Dthrift.extra.cpath in debian/rules
> Debian packaging for thrift
> ---------------------------
>
> Key: THRIFT-71
> URL: https://issues.apache.org/jira/browse/THRIFT-71
> Project: Thrift
> Issue Type: Improvement
> Environment: debian stable (etch); probably will work on lenny, but untested
> Reporter: Eric Anderson
> Priority: Minor
> Attachments: debian-packaging.patch, thrift-71.patch, thrift-71_v2.patch, thrift-71_v3.patch, thrift-71_v4.patch, thrift-71_v5.patch, thrift-71_v6.patch
>
>
> We're using thrift on Debian, so I wanted to have a package for easier
> installation by other users.
> Attached is a patch to add packaging for debian to the
> thrift-20080411p1 release. It includes two bug fixes to make the
> tests work reliably: 1) adding /usr/share/java/commons-lang.jar to the
> search path for the java tests, and 2) sleeping 1 second after
> starting the server for the python tests. If the patch is accepted,
> the maintainer should probably be set to the thrift mailing list,
> rather than the example mailing list address I used.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (THRIFT-71) Debian packaging for thrift
Posted by "Esteve Fernandez (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/THRIFT-71?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Esteve Fernandez updated THRIFT-71:
-----------------------------------
Attachment: thrift-71_v2.patch
Newer version of the patch. I had to disable C# support due to THRIFT-264 and THRIFT-272.
> Debian packaging for thrift
> ---------------------------
>
> Key: THRIFT-71
> URL: https://issues.apache.org/jira/browse/THRIFT-71
> Project: Thrift
> Issue Type: Improvement
> Environment: debian stable (etch); probably will work on lenny, but untested
> Reporter: Eric Anderson
> Priority: Minor
> Attachments: debian-packaging.patch, thrift-71.patch, thrift-71_v2.patch
>
>
> We're using thrift on Debian, so I wanted to have a package for easier
> installation by other users.
> Attached is a patch to add packaging for debian to the
> thrift-20080411p1 release. It includes two bug fixes to make the
> tests work reliably: 1) adding /usr/share/java/commons-lang.jar to the
> search path for the java tests, and 2) sleeping 1 second after
> starting the server for the python tests. If the patch is accepted,
> the maintainer should probably be set to the thrift mailing list,
> rather than the example mailing list address I used.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (THRIFT-71) Debian packaging for thrift
Posted by "Anthony Molinaro (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/THRIFT-71?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12901588#action_12901588 ]
Anthony Molinaro commented on THRIFT-71:
----------------------------------------
Hi, I'm not a commiter for thrift, so take this as an opinion from the peanut gallery, and nothing more.
This patch looks like it puts a debian directory at the root of the thrift tree. For the rpm spec file it's in the contrib directory, and looking back through the history of this it seems as though it was in contrib at some point and then pulled out.
However, I would question the placing of this in thrift at all. Most distributions keep these files separate from the source code distribution. For instance Redhat has their .spec files separate from all the software they package. They don't try to keep the files with the package. The problem with keeping these with the package is there is no one tasked with maintaining them. Doesn't debian have a place where it keeps these packaging specific files? Actually, looking at wikipedia it seems like there is a process for debian packaging http://en.wikipedia.org/wiki/Debian#Package_maintenance
and it seems like its usually the role of the maintainer of a debian package to take the upstream sources and build a package from them. It does not and probably should not require the upstream package to contain packaging specific configuration.
Other than that, it seems like the problems with the distribution (ie, commons-lang and python unit test), were fixed and are no longer a problem. So it should be fine for you to keep the debian packaging files wherever you would like and simply use them to build packages, letting the thrift developers know if they break something during the release cycle.
Alternatively, I think this could be added to contrib with the same guarantees on contrib as everything else which is no guarantees that
any of it works ever :)
Mostly up to the people maintaining the thrift source to decide.
> Debian packaging for thrift
> ---------------------------
>
> Key: THRIFT-71
> URL: https://issues.apache.org/jira/browse/THRIFT-71
> Project: Thrift
> Issue Type: Improvement
> Environment: debian stable (etch); probably will work on lenny, but untested
> Reporter: Eric Anderson
> Priority: Minor
> Attachments: debian-packaging.patch, thrift-71.patch, thrift-71_v2.patch, thrift-71_v3.patch, thrift-71_v4.patch, thrift-71_v5.patch, thrift-71_v6.patch, thrift-71_v7.patch
>
>
> We're using thrift on Debian, so I wanted to have a package for easier
> installation by other users.
> Attached is a patch to add packaging for debian to the
> thrift-20080411p1 release. It includes two bug fixes to make the
> tests work reliably: 1) adding /usr/share/java/commons-lang.jar to the
> search path for the java tests, and 2) sleeping 1 second after
> starting the server for the python tests. If the patch is accepted,
> the maintainer should probably be set to the thrift mailing list,
> rather than the example mailing list address I used.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (THRIFT-71) Debian packaging for thrift
Posted by "Esteve Fernandez (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/THRIFT-71?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Esteve Fernandez updated THRIFT-71:
-----------------------------------
Attachment: thrift-71_v6.patch
This patch adds support for Perl
> Debian packaging for thrift
> ---------------------------
>
> Key: THRIFT-71
> URL: https://issues.apache.org/jira/browse/THRIFT-71
> Project: Thrift
> Issue Type: Improvement
> Environment: debian stable (etch); probably will work on lenny, but untested
> Reporter: Eric Anderson
> Priority: Minor
> Attachments: debian-packaging.patch, thrift-71.patch, thrift-71_v2.patch, thrift-71_v3.patch, thrift-71_v4.patch, thrift-71_v5.patch, thrift-71_v6.patch
>
>
> We're using thrift on Debian, so I wanted to have a package for easier
> installation by other users.
> Attached is a patch to add packaging for debian to the
> thrift-20080411p1 release. It includes two bug fixes to make the
> tests work reliably: 1) adding /usr/share/java/commons-lang.jar to the
> search path for the java tests, and 2) sleeping 1 second after
> starting the server for the python tests. If the patch is accepted,
> the maintainer should probably be set to the thrift mailing list,
> rather than the example mailing list address I used.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (THRIFT-71) Debian packaging for thrift
Posted by "David Reiss (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/THRIFT-71?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12612702#action_12612702 ]
David Reiss commented on THRIFT-71:
-----------------------------------
Todd, do you want to compare this with what you've got at <http://gitweb.thrift-rpc.org/?p=thrift.git;a=tree;f=debian;h=16f5fd8;hb=c0e3e13>.
Personally, I don't like the idea of having a debian directory at the top level of the tree. I'd prefer to have either the directory or the patch under contrib. Thoughts?
> Debian packaging for thrift
> ---------------------------
>
> Key: THRIFT-71
> URL: https://issues.apache.org/jira/browse/THRIFT-71
> Project: Thrift
> Issue Type: Improvement
> Environment: debian stable (etch); probably will work on lenny, but untested
> Reporter: Eric Anderson
> Priority: Minor
> Attachments: debian-packaging.patch
>
>
> We're using thrift on Debian, so I wanted to have a package for easier
> installation by other users.
> Attached is a patch to add packaging for debian to the
> thrift-20080411p1 release. It includes two bug fixes to make the
> tests work reliably: 1) adding /usr/share/java/commons-lang.jar to the
> search path for the java tests, and 2) sleeping 1 second after
> starting the server for the python tests. If the patch is accepted,
> the maintainer should probably be set to the thrift mailing list,
> rather than the example mailing list address I used.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (THRIFT-71) Debian packaging for thrift
Posted by "David Reiss (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/THRIFT-71?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12901625#action_12901625 ]
David Reiss commented on THRIFT-71:
-----------------------------------
I mostly agree with Anthony. I'm fine committing some form of debian packaging files or .diff.gz under contrib, but I don't think it belongs at top level in the distribution.
> Debian packaging for thrift
> ---------------------------
>
> Key: THRIFT-71
> URL: https://issues.apache.org/jira/browse/THRIFT-71
> Project: Thrift
> Issue Type: Improvement
> Environment: debian stable (etch); probably will work on lenny, but untested
> Reporter: Eric Anderson
> Priority: Minor
> Attachments: debian-packaging.patch, thrift-71.patch, thrift-71_v2.patch, thrift-71_v3.patch, thrift-71_v4.patch, thrift-71_v5.patch, thrift-71_v6.patch, thrift-71_v7.patch
>
>
> We're using thrift on Debian, so I wanted to have a package for easier
> installation by other users.
> Attached is a patch to add packaging for debian to the
> thrift-20080411p1 release. It includes two bug fixes to make the
> tests work reliably: 1) adding /usr/share/java/commons-lang.jar to the
> search path for the java tests, and 2) sleeping 1 second after
> starting the server for the python tests. If the patch is accepted,
> the maintainer should probably be set to the thrift mailing list,
> rather than the example mailing list address I used.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (THRIFT-71) Debian packaging for thrift
Posted by "David Reiss (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/THRIFT-71?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12671505#action_12671505 ]
David Reiss commented on THRIFT-71:
-----------------------------------
I'd like for the three different people who have worked on Debian packaging to come to an agreement on which is best (and incorporate the best features of each). Two of the patches are here, the third is at http://gitweb.thrift-rpc.org/?p=thrift.git;a=tree;f=debian;h=16f5fd8;hb=pri/tlipcon/debian-moved
I still think that platform-specific packaging information should not be at the top level of the source tree, so if I end up committing this, I'll move the dir under contrib.
> Debian packaging for thrift
> ---------------------------
>
> Key: THRIFT-71
> URL: https://issues.apache.org/jira/browse/THRIFT-71
> Project: Thrift
> Issue Type: Improvement
> Environment: debian stable (etch); probably will work on lenny, but untested
> Reporter: Eric Anderson
> Priority: Minor
> Attachments: debian-packaging.patch, thrift-71.patch, thrift-71_v2.patch, thrift-71_v3.patch, thrift-71_v4.patch
>
>
> We're using thrift on Debian, so I wanted to have a package for easier
> installation by other users.
> Attached is a patch to add packaging for debian to the
> thrift-20080411p1 release. It includes two bug fixes to make the
> tests work reliably: 1) adding /usr/share/java/commons-lang.jar to the
> search path for the java tests, and 2) sleeping 1 second after
> starting the server for the python tests. If the patch is accepted,
> the maintainer should probably be set to the thrift mailing list,
> rather than the example mailing list address I used.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (THRIFT-71) Debian packaging for thrift
Posted by "Todd Lipcon (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/THRIFT-71?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12672344#action_12672344 ]
Todd Lipcon commented on THRIFT-71:
-----------------------------------
Couple more thoughts upon trying to build:
- The python-all-dbg build depend doesn't seem to exist for etch - it's new in lenny/sid. Removing it causes issues building the libthrift-python-dbg package of course. Not sure what the best course of action is here.
- Good point on erlang-nox. The build-depend on erlang-base should also be erlang-nox then, since erlang-base-hipe is a valid alternative. Or, we could do erlang-base | erlang-base-hipe. I'm not sure exactly what the dependency structure looks like here and how dpkg satisfies them, but you seem to have a much better grasp than I do :)
- Confirmed that openjdk-6-jdk is too specific of a depend above - I don't have that package, but use sun-java6-jdk instead. Doing the | approach seems fine as you suggested.
- Getting this error on the csharp build:
{noformat}
gmcs src/Protocol/TBase.cs src/Protocol/TProtocolException.cs src/Protocol/TProtocolFactory.cs src/Protocol/TList.cs src/Protocol/TSet.cs src/Protocol/TMap.cs src/Protocol/TProtocolUtil.cs src/Protocol/TMessageType.cs src/Protocol/TProtocol.cs src/Protocol/TType.cs src/Protocol/TField.cs src/Protocol/TMessage.cs src/Protocol/TStruct.cs src/Protocol/TBinaryProtocol.cs src/Server/TThreadedServer.cs src/Server/TThreadPoolServer.cs src/Server/TSimpleServer.cs src/Server/TServer.cs src/Transport/TBufferedTransport.cs src/Transport/TTransport.cs src/Transport/TSocket.cs src/Transport/TTransportException.cs src/Transport/TStreamTransport.cs src/Transport/TServerTransport.cs src/Transport/TServerSocket.cs src/Transport/TTransportFactory.cs src/TProcessor.cs src/TApplicationException.cs /out:Thrift.dll /target:library /langversion:linq
error CS1617: Invalid option `linq' for /langversion. It must be either `ISO-1' or `Default'
Compilation failed: 1 error(s), 0 warnings
{noformat}
I have never touched csharp to be honest, so not sure what this is about. I'm guessing it's etch-specific as well.
I'd like to say we should just drop etch support, but unfortunately Amie Street (and i'm guessing some others) are still deploying on it, so it's a blocker for adopting this deb.
-Todd
> Debian packaging for thrift
> ---------------------------
>
> Key: THRIFT-71
> URL: https://issues.apache.org/jira/browse/THRIFT-71
> Project: Thrift
> Issue Type: Improvement
> Environment: debian stable (etch); probably will work on lenny, but untested
> Reporter: Eric Anderson
> Priority: Minor
> Attachments: debian-packaging.patch, thrift-71.patch, thrift-71_v2.patch, thrift-71_v3.patch, thrift-71_v4.patch, thrift-71_v5.patch
>
>
> We're using thrift on Debian, so I wanted to have a package for easier
> installation by other users.
> Attached is a patch to add packaging for debian to the
> thrift-20080411p1 release. It includes two bug fixes to make the
> tests work reliably: 1) adding /usr/share/java/commons-lang.jar to the
> search path for the java tests, and 2) sleeping 1 second after
> starting the server for the python tests. If the patch is accepted,
> the maintainer should probably be set to the thrift mailing list,
> rather than the example mailing list address I used.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (THRIFT-71) Debian packaging for thrift
Posted by "Eric Anderson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/THRIFT-71?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Eric Anderson updated THRIFT-71:
--------------------------------
Attachment: debian-packaging.patch
> Debian packaging for thrift
> ---------------------------
>
> Key: THRIFT-71
> URL: https://issues.apache.org/jira/browse/THRIFT-71
> Project: Thrift
> Issue Type: Improvement
> Environment: debian stable (etch); probably will work on lenny, but untested
> Reporter: Eric Anderson
> Attachments: debian-packaging.patch
>
>
> We're using thrift on Debian, so I wanted to have a package for easier
> installation by other users.
> Attached is a patch to add packaging for debian to the
> thrift-20080411p1 release. It includes two bug fixes to make the
> tests work reliably: 1) adding /usr/share/java/commons-lang.jar to the
> search path for the java tests, and 2) sleeping 1 second after
> starting the server for the python tests. If the patch is accepted,
> the maintainer should probably be set to the thrift mailing list,
> rather than the example mailing list address I used.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (THRIFT-71) Debian packaging for thrift
Posted by "Michael Greene (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/THRIFT-71?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12661005#action_12661005 ]
Michael Greene commented on THRIFT-71:
--------------------------------------
There is also Esteve's Debian/Ubuntu work at https://launchpad.net/~esteve-fernandez/+archive?field.name_filter=thrift&field.status_filter=published which I'm partial to myself, since it breaks down the libraries properly. I can't really complain about the lack of C#, for the difficulty of Mono packaging on Ubuntu.
> Debian packaging for thrift
> ---------------------------
>
> Key: THRIFT-71
> URL: https://issues.apache.org/jira/browse/THRIFT-71
> Project: Thrift
> Issue Type: Improvement
> Environment: debian stable (etch); probably will work on lenny, but untested
> Reporter: Eric Anderson
> Priority: Minor
> Attachments: debian-packaging.patch
>
>
> We're using thrift on Debian, so I wanted to have a package for easier
> installation by other users.
> Attached is a patch to add packaging for debian to the
> thrift-20080411p1 release. It includes two bug fixes to make the
> tests work reliably: 1) adding /usr/share/java/commons-lang.jar to the
> search path for the java tests, and 2) sleeping 1 second after
> starting the server for the python tests. If the patch is accepted,
> the maintainer should probably be set to the thrift mailing list,
> rather than the example mailing list address I used.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (THRIFT-71) Debian packaging for thrift
Posted by "Esteve Fernandez (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/THRIFT-71?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12672340#action_12672340 ]
Esteve Fernandez commented on THRIFT-71:
----------------------------------------
Todd: I forgot to mention, that you'll need to apply THRIFT-309 first, as Thrift doesn't build with .NET 2.0 runtimes (like Mono 1.2.6)
> Debian packaging for thrift
> ---------------------------
>
> Key: THRIFT-71
> URL: https://issues.apache.org/jira/browse/THRIFT-71
> Project: Thrift
> Issue Type: Improvement
> Environment: debian stable (etch); probably will work on lenny, but untested
> Reporter: Eric Anderson
> Priority: Minor
> Attachments: debian-packaging.patch, thrift-71.patch, thrift-71_v2.patch, thrift-71_v3.patch, thrift-71_v4.patch
>
>
> We're using thrift on Debian, so I wanted to have a package for easier
> installation by other users.
> Attached is a patch to add packaging for debian to the
> thrift-20080411p1 release. It includes two bug fixes to make the
> tests work reliably: 1) adding /usr/share/java/commons-lang.jar to the
> search path for the java tests, and 2) sleeping 1 second after
> starting the server for the python tests. If the patch is accepted,
> the maintainer should probably be set to the thrift mailing list,
> rather than the example mailing list address I used.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (THRIFT-71) Debian packaging for thrift
Posted by "Alexander Shigin (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/THRIFT-71?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12688164#action_12688164 ]
Alexander Shigin commented on THRIFT-71:
----------------------------------------
I do believe license file should be changed to Apache one.
> Debian packaging for thrift
> ---------------------------
>
> Key: THRIFT-71
> URL: https://issues.apache.org/jira/browse/THRIFT-71
> Project: Thrift
> Issue Type: Improvement
> Environment: debian stable (etch); probably will work on lenny, but untested
> Reporter: Eric Anderson
> Priority: Minor
> Attachments: debian-packaging.patch, thrift-71.patch, thrift-71_v2.patch, thrift-71_v3.patch, thrift-71_v4.patch, thrift-71_v5.patch, thrift-71_v6.patch
>
>
> We're using thrift on Debian, so I wanted to have a package for easier
> installation by other users.
> Attached is a patch to add packaging for debian to the
> thrift-20080411p1 release. It includes two bug fixes to make the
> tests work reliably: 1) adding /usr/share/java/commons-lang.jar to the
> search path for the java tests, and 2) sleeping 1 second after
> starting the server for the python tests. If the patch is accepted,
> the maintainer should probably be set to the thrift mailing list,
> rather than the example mailing list address I used.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (THRIFT-71) Debian packaging for thrift
Posted by "Esteve Fernandez (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/THRIFT-71?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Esteve Fernandez updated THRIFT-71:
-----------------------------------
Attachment: thrift-71_v4.patch
Reenabled support for C# thanks to THRIFT-309
> Debian packaging for thrift
> ---------------------------
>
> Key: THRIFT-71
> URL: https://issues.apache.org/jira/browse/THRIFT-71
> Project: Thrift
> Issue Type: Improvement
> Environment: debian stable (etch); probably will work on lenny, but untested
> Reporter: Eric Anderson
> Priority: Minor
> Attachments: debian-packaging.patch, thrift-71.patch, thrift-71_v2.patch, thrift-71_v3.patch, thrift-71_v4.patch
>
>
> We're using thrift on Debian, so I wanted to have a package for easier
> installation by other users.
> Attached is a patch to add packaging for debian to the
> thrift-20080411p1 release. It includes two bug fixes to make the
> tests work reliably: 1) adding /usr/share/java/commons-lang.jar to the
> search path for the java tests, and 2) sleeping 1 second after
> starting the server for the python tests. If the patch is accepted,
> the maintainer should probably be set to the thrift mailing list,
> rather than the example mailing list address I used.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (THRIFT-71) Debian packaging for thrift
Posted by "Esteve Fernandez (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/THRIFT-71?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12671449#action_12671449 ]
Esteve Fernandez commented on THRIFT-71:
----------------------------------------
Thanks to Michael (THRIFT-309), my patch has support for C# again, but it still lacks support for the Perl library. Anyway, the rest of the top-tier languages is supported. Any chance of being accepted anytime soon?
> Debian packaging for thrift
> ---------------------------
>
> Key: THRIFT-71
> URL: https://issues.apache.org/jira/browse/THRIFT-71
> Project: Thrift
> Issue Type: Improvement
> Environment: debian stable (etch); probably will work on lenny, but untested
> Reporter: Eric Anderson
> Priority: Minor
> Attachments: debian-packaging.patch, thrift-71.patch, thrift-71_v2.patch, thrift-71_v3.patch, thrift-71_v4.patch
>
>
> We're using thrift on Debian, so I wanted to have a package for easier
> installation by other users.
> Attached is a patch to add packaging for debian to the
> thrift-20080411p1 release. It includes two bug fixes to make the
> tests work reliably: 1) adding /usr/share/java/commons-lang.jar to the
> search path for the java tests, and 2) sleeping 1 second after
> starting the server for the python tests. If the patch is accepted,
> the maintainer should probably be set to the thrift mailing list,
> rather than the example mailing list address I used.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (THRIFT-71) Debian packaging for thrift
Posted by "Esteve Fernandez (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/THRIFT-71?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12664084#action_12664084 ]
Esteve Fernandez commented on THRIFT-71:
----------------------------------------
The debian directory still resides at the top level in my patch, and I think it's where it should live. It's standard and makes life easier to packagers and builders. For example, we use Launchpad to build our packages, and it expects the debian directory to be at the top level.
> Debian packaging for thrift
> ---------------------------
>
> Key: THRIFT-71
> URL: https://issues.apache.org/jira/browse/THRIFT-71
> Project: Thrift
> Issue Type: Improvement
> Environment: debian stable (etch); probably will work on lenny, but untested
> Reporter: Eric Anderson
> Priority: Minor
> Attachments: debian-packaging.patch, thrift-71.patch
>
>
> We're using thrift on Debian, so I wanted to have a package for easier
> installation by other users.
> Attached is a patch to add packaging for debian to the
> thrift-20080411p1 release. It includes two bug fixes to make the
> tests work reliably: 1) adding /usr/share/java/commons-lang.jar to the
> search path for the java tests, and 2) sleeping 1 second after
> starting the server for the python tests. If the patch is accepted,
> the maintainer should probably be set to the thrift mailing list,
> rather than the example mailing list address I used.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (THRIFT-71) Debian packaging for thrift
Posted by "kert (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/THRIFT-71?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12849525#action_12849525 ]
kert commented on THRIFT-71:
----------------------------
How does this fit with http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=524135 ? Has there been an upload to mentors.debian.net yet ?
> Debian packaging for thrift
> ---------------------------
>
> Key: THRIFT-71
> URL: https://issues.apache.org/jira/browse/THRIFT-71
> Project: Thrift
> Issue Type: Improvement
> Environment: debian stable (etch); probably will work on lenny, but untested
> Reporter: Eric Anderson
> Priority: Minor
> Attachments: debian-packaging.patch, thrift-71.patch, thrift-71_v2.patch, thrift-71_v3.patch, thrift-71_v4.patch, thrift-71_v5.patch, thrift-71_v6.patch
>
>
> We're using thrift on Debian, so I wanted to have a package for easier
> installation by other users.
> Attached is a patch to add packaging for debian to the
> thrift-20080411p1 release. It includes two bug fixes to make the
> tests work reliably: 1) adding /usr/share/java/commons-lang.jar to the
> search path for the java tests, and 2) sleeping 1 second after
> starting the server for the python tests. If the patch is accepted,
> the maintainer should probably be set to the thrift mailing list,
> rather than the example mailing list address I used.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (THRIFT-71) Debian packaging for thrift
Posted by "Esteve Fernandez (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/THRIFT-71?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Esteve Fernandez updated THRIFT-71:
-----------------------------------
Attachment: thrift-71_v3.patch
Fixed erlang package.
> Debian packaging for thrift
> ---------------------------
>
> Key: THRIFT-71
> URL: https://issues.apache.org/jira/browse/THRIFT-71
> Project: Thrift
> Issue Type: Improvement
> Environment: debian stable (etch); probably will work on lenny, but untested
> Reporter: Eric Anderson
> Priority: Minor
> Attachments: debian-packaging.patch, thrift-71.patch, thrift-71_v2.patch, thrift-71_v3.patch
>
>
> We're using thrift on Debian, so I wanted to have a package for easier
> installation by other users.
> Attached is a patch to add packaging for debian to the
> thrift-20080411p1 release. It includes two bug fixes to make the
> tests work reliably: 1) adding /usr/share/java/commons-lang.jar to the
> search path for the java tests, and 2) sleeping 1 second after
> starting the server for the python tests. If the patch is accepted,
> the maintainer should probably be set to the thrift mailing list,
> rather than the example mailing list address I used.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (THRIFT-71) Debian packaging for thrift
Posted by "Eric Anderson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/THRIFT-71?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Eric Anderson updated THRIFT-71:
--------------------------------
Attachment: (was: debian-packaging.patch)
> Debian packaging for thrift
> ---------------------------
>
> Key: THRIFT-71
> URL: https://issues.apache.org/jira/browse/THRIFT-71
> Project: Thrift
> Issue Type: Improvement
> Environment: debian stable (etch); probably will work on lenny, but untested
> Reporter: Eric Anderson
> Priority: Minor
> Attachments: debian-packaging.patch
>
>
> We're using thrift on Debian, so I wanted to have a package for easier
> installation by other users.
> Attached is a patch to add packaging for debian to the
> thrift-20080411p1 release. It includes two bug fixes to make the
> tests work reliably: 1) adding /usr/share/java/commons-lang.jar to the
> search path for the java tests, and 2) sleeping 1 second after
> starting the server for the python tests. If the patch is accepted,
> the maintainer should probably be set to the thrift mailing list,
> rather than the example mailing list address I used.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (THRIFT-71) Debian packaging for thrift
Posted by "Roger Meier (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/THRIFT-71?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12912282#action_12912282 ]
Roger Meier commented on THRIFT-71:
-----------------------------------
please commit this!
I would like to merge Eric Evans patches from http://git.debian.org/?p=collab-maint/thrift.git with latest patch [^thrift-71_v7.patch] hopefully before 0.5 release, but we need a starting point within repo.
The important thing is, that we can at least *deploy Thrift compiler as Debian package* with each release, just as we do with win32 Thrift Compiler or Maven.
On Question for me is:
how do we get the VERSION define from config.h to relevant files for each release?
e.g. lib/csharp/ThriftMSBuildTask/Properties/AssemblyInfo.cs
debian/changelog has to be edited manually for each release, but the rest should be fully automated.
> Debian packaging for thrift
> ---------------------------
>
> Key: THRIFT-71
> URL: https://issues.apache.org/jira/browse/THRIFT-71
> Project: Thrift
> Issue Type: Improvement
> Environment: debian stable (etch); probably will work on lenny, but untested
> Reporter: Eric Anderson
> Priority: Minor
> Attachments: debian-packaging.patch, thrift-71.patch, thrift-71_v2.patch, thrift-71_v3.patch, thrift-71_v4.patch, thrift-71_v5.patch, thrift-71_v6.patch, thrift-71_v7.patch
>
>
> We're using thrift on Debian, so I wanted to have a package for easier
> installation by other users.
> Attached is a patch to add packaging for debian to the
> thrift-20080411p1 release. It includes two bug fixes to make the
> tests work reliably: 1) adding /usr/share/java/commons-lang.jar to the
> search path for the java tests, and 2) sleeping 1 second after
> starting the server for the python tests. If the patch is accepted,
> the maintainer should probably be set to the thrift mailing list,
> rather than the example mailing list address I used.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (THRIFT-71) Debian packaging for thrift
Posted by "Akira Kitada (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/THRIFT-71?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12923496#action_12923496 ]
Akira Kitada commented on THRIFT-71:
------------------------------------
Isn't fb303 included in this package or should it be separate 'fb303' 'python-fb303' etc?
> Debian packaging for thrift
> ---------------------------
>
> Key: THRIFT-71
> URL: https://issues.apache.org/jira/browse/THRIFT-71
> Project: Thrift
> Issue Type: Improvement
> Environment: debian stable (etch); probably will work on lenny, but untested
> Reporter: Eric Anderson
> Priority: Minor
> Attachments: debian-packaging.patch, thrift-71.patch, thrift-71_v2.patch, thrift-71_v3.patch, thrift-71_v4.patch, thrift-71_v5.patch, thrift-71_v6.patch, thrift-71_v7.patch, THRIFT-71_v8_0.5.0.patch
>
>
> We're using thrift on Debian, so I wanted to have a package for easier
> installation by other users.
> Attached is a patch to add packaging for debian to the
> thrift-20080411p1 release. It includes two bug fixes to make the
> tests work reliably: 1) adding /usr/share/java/commons-lang.jar to the
> search path for the java tests, and 2) sleeping 1 second after
> starting the server for the python tests. If the patch is accepted,
> the maintainer should probably be set to the thrift mailing list,
> rather than the example mailing list address I used.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (THRIFT-71) Debian packaging for thrift
Posted by "Eric Evans (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/THRIFT-71?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12849722#action_12849722 ]
Eric Evans commented on THRIFT-71:
----------------------------------
I filed that ITP but haven't done anything with it in quite some time. Esteve and I were going to collaborate and merge our efforts but that never went anywhere either. I think if we're being honest, this issue isn't going anywhere and could safely be closed. Sorry.
> Debian packaging for thrift
> ---------------------------
>
> Key: THRIFT-71
> URL: https://issues.apache.org/jira/browse/THRIFT-71
> Project: Thrift
> Issue Type: Improvement
> Environment: debian stable (etch); probably will work on lenny, but untested
> Reporter: Eric Anderson
> Priority: Minor
> Attachments: debian-packaging.patch, thrift-71.patch, thrift-71_v2.patch, thrift-71_v3.patch, thrift-71_v4.patch, thrift-71_v5.patch, thrift-71_v6.patch
>
>
> We're using thrift on Debian, so I wanted to have a package for easier
> installation by other users.
> Attached is a patch to add packaging for debian to the
> thrift-20080411p1 release. It includes two bug fixes to make the
> tests work reliably: 1) adding /usr/share/java/commons-lang.jar to the
> search path for the java tests, and 2) sleeping 1 second after
> starting the server for the python tests. If the patch is accepted,
> the maintainer should probably be set to the thrift mailing list,
> rather than the example mailing list address I used.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (THRIFT-71) Debian packaging for thrift
Posted by "Todd Lipcon (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/THRIFT-71?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12706268#action_12706268 ]
Todd Lipcon commented on THRIFT-71:
-----------------------------------
FYI my branch is in the public repo at:
http://thrift-rpc.org/?p=thrift.git;a=shortlog;h=refs/heads/pri/tlipcon/cloudera_deb
> Debian packaging for thrift
> ---------------------------
>
> Key: THRIFT-71
> URL: https://issues.apache.org/jira/browse/THRIFT-71
> Project: Thrift
> Issue Type: Improvement
> Environment: debian stable (etch); probably will work on lenny, but untested
> Reporter: Eric Anderson
> Priority: Minor
> Attachments: debian-packaging.patch, thrift-71.patch, thrift-71_v2.patch, thrift-71_v3.patch, thrift-71_v4.patch, thrift-71_v5.patch, thrift-71_v6.patch
>
>
> We're using thrift on Debian, so I wanted to have a package for easier
> installation by other users.
> Attached is a patch to add packaging for debian to the
> thrift-20080411p1 release. It includes two bug fixes to make the
> tests work reliably: 1) adding /usr/share/java/commons-lang.jar to the
> search path for the java tests, and 2) sleeping 1 second after
> starting the server for the python tests. If the patch is accepted,
> the maintainer should probably be set to the thrift mailing list,
> rather than the example mailing list address I used.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (THRIFT-71) Debian packaging for thrift
Posted by "Bryan Duxbury (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/THRIFT-71?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12902088#action_12902088 ]
Bryan Duxbury commented on THRIFT-71:
-------------------------------------
I am mostly in favor of just doing *something* at this point. As long as adding the patch doesn't get in the way of anything we do today, then I'm fine with us committing what we have.
> Debian packaging for thrift
> ---------------------------
>
> Key: THRIFT-71
> URL: https://issues.apache.org/jira/browse/THRIFT-71
> Project: Thrift
> Issue Type: Improvement
> Environment: debian stable (etch); probably will work on lenny, but untested
> Reporter: Eric Anderson
> Priority: Minor
> Attachments: debian-packaging.patch, thrift-71.patch, thrift-71_v2.patch, thrift-71_v3.patch, thrift-71_v4.patch, thrift-71_v5.patch, thrift-71_v6.patch, thrift-71_v7.patch
>
>
> We're using thrift on Debian, so I wanted to have a package for easier
> installation by other users.
> Attached is a patch to add packaging for debian to the
> thrift-20080411p1 release. It includes two bug fixes to make the
> tests work reliably: 1) adding /usr/share/java/commons-lang.jar to the
> search path for the java tests, and 2) sleeping 1 second after
> starting the server for the python tests. If the patch is accepted,
> the maintainer should probably be set to the thrift mailing list,
> rather than the example mailing list address I used.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (THRIFT-71) Debian packaging for thrift
Posted by "Roger Meier (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/THRIFT-71?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Roger Meier updated THRIFT-71:
------------------------------
Attachment: THRIFT-71_v8_0.5.0.patch
just added [^THRIFT-71_v8_0.5.0.patch], result can be tested by adding the following lines to _/etc/apt/sources.list.d/thrift.list_ on a Debian based GNU/Linux
{code}
deb http://people.apache.org/~roger/dist/thrift/0.5.0/debian stable contrib
deb-src http://people.apache.org/~roger/dist/thrift/0.5.0/debian stable contrib
{code}
right now, I tested only the thrift-compiler package...other tests are welcome!
versioning, package description text, etc. will be harmonized across all distributions (Python, Debian, Maven, Windows, etc.) via THRIFT-6
@Esteve:
* Can we change the maintainer address from your to thrift-dev@incubator.apache.org?
* Could you agree if we change Debian package License from BSD to Apache 2.0 ?
I'm ready to change little things and then commit this, so please VOTE now!
> Debian packaging for thrift
> ---------------------------
>
> Key: THRIFT-71
> URL: https://issues.apache.org/jira/browse/THRIFT-71
> Project: Thrift
> Issue Type: Improvement
> Environment: debian stable (etch); probably will work on lenny, but untested
> Reporter: Eric Anderson
> Priority: Minor
> Attachments: debian-packaging.patch, thrift-71.patch, thrift-71_v2.patch, thrift-71_v3.patch, thrift-71_v4.patch, thrift-71_v5.patch, thrift-71_v6.patch, thrift-71_v7.patch, THRIFT-71_v8_0.5.0.patch
>
>
> We're using thrift on Debian, so I wanted to have a package for easier
> installation by other users.
> Attached is a patch to add packaging for debian to the
> thrift-20080411p1 release. It includes two bug fixes to make the
> tests work reliably: 1) adding /usr/share/java/commons-lang.jar to the
> search path for the java tests, and 2) sleeping 1 second after
> starting the server for the python tests. If the patch is accepted,
> the maintainer should probably be set to the thrift mailing list,
> rather than the example mailing list address I used.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (THRIFT-71) Debian packaging for thrift
Posted by "Eric Anderson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/THRIFT-71?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Eric Anderson updated THRIFT-71:
--------------------------------
Attachment: debian-packaging.patch
version 2 of the patch; moves the debian directory under contrib, adds a README that explains how to build the package.
> Debian packaging for thrift
> ---------------------------
>
> Key: THRIFT-71
> URL: https://issues.apache.org/jira/browse/THRIFT-71
> Project: Thrift
> Issue Type: Improvement
> Environment: debian stable (etch); probably will work on lenny, but untested
> Reporter: Eric Anderson
> Priority: Minor
> Attachments: debian-packaging.patch
>
>
> We're using thrift on Debian, so I wanted to have a package for easier
> installation by other users.
> Attached is a patch to add packaging for debian to the
> thrift-20080411p1 release. It includes two bug fixes to make the
> tests work reliably: 1) adding /usr/share/java/commons-lang.jar to the
> search path for the java tests, and 2) sleeping 1 second after
> starting the server for the python tests. If the patch is accepted,
> the maintainer should probably be set to the thrift mailing list,
> rather than the example mailing list address I used.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Issue Comment Edited: (THRIFT-71) Debian packaging for
thrift
Posted by "Esteve Fernandez (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/THRIFT-71?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12672353#action_12672353 ]
esteve edited comment on THRIFT-71 at 2/10/09 10:41 AM:
------------------------------------------------------------------
The python-all-dbg* stuff should be optional. We could simply have two separate debian/control files, one which depends on it and another one that doesn't, it could be part of a "release" make target.. if we ever make a release ;-)
As for the C# part, I'm not sure if etch could build it after all. It ships with Mono 1.2.2, which IMHO is too old to support /lang:linq, but I don't really know though, I'm no C# expert. Michael is the person to ask :-) Anyway, could you install mono-gmcs from etch-backports and try to build Thrift?
was (Author: esteve):
The python-all-dbg* stuff should be optional. We could simply have two separate debian/control files, one which depends on it and another one that doesn't, it could be part of a "release" make target.. if we ever make a release ;-)
As for the C# part, I'm not sure if etch could build it after all. It ships with Mono 1.2.2, which IMHO is too old to /lang:linq, but I don't really know though, I'm no C# expert. Michael is the person to ask :-) Anyway, could you install mono-gmcs from etch-backports and try to build Thrift?
> Debian packaging for thrift
> ---------------------------
>
> Key: THRIFT-71
> URL: https://issues.apache.org/jira/browse/THRIFT-71
> Project: Thrift
> Issue Type: Improvement
> Environment: debian stable (etch); probably will work on lenny, but untested
> Reporter: Eric Anderson
> Priority: Minor
> Attachments: debian-packaging.patch, thrift-71.patch, thrift-71_v2.patch, thrift-71_v3.patch, thrift-71_v4.patch, thrift-71_v5.patch
>
>
> We're using thrift on Debian, so I wanted to have a package for easier
> installation by other users.
> Attached is a patch to add packaging for debian to the
> thrift-20080411p1 release. It includes two bug fixes to make the
> tests work reliably: 1) adding /usr/share/java/commons-lang.jar to the
> search path for the java tests, and 2) sleeping 1 second after
> starting the server for the python tests. If the patch is accepted,
> the maintainer should probably be set to the thrift mailing list,
> rather than the example mailing list address I used.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (THRIFT-71) Debian packaging for thrift
Posted by "Roger Meier (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/THRIFT-71?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12902058#action_12902058 ]
Roger Meier commented on THRIFT-71:
-----------------------------------
I'm not really happy with these answers ... why?
Did you had a look on that mentioned rpm spec file? -> super outdated, could be removed from my perspective.
Why do we need debian as a top folder here?
- many years ago people decided to do so
- building packages is straight forward, no folder moving before building -> e.g. Hudson CI just builds the packages fully automated
- maintenance is simple, no requirement to move or copy folders before preparing a patch or commit changes
- similar to the pom.xml for maven
- many projects are doing the same => provide ready to use packages and having a debian folder within root
- nobody would like to create and maintain patches within the Debian project as long es we are within incubator
As you see within that issue, people would like to have Debian packages for Thrift. This would make it *super-easy* to get started and become familiar with Thrift. I do not believe, that all the people like to do the "./bootstrap.sh; ./configure; make" thing, just to have a quick look or to get started. ... People like to have a solution for their problem, verify if Thrift fits and just us it afterwards.
*I still believe that this project is at Apache to become more popular, mature and widely used*.
Some more questions to consider before you decide or vote on that issue:
* How do you deploy Thrift to the users within your employer?
* Should each user build the libraries by himself?
* Should they use trunk versions and report bug's related to version ??trunk whatever?? instead of version 0.4.1?
* How many time do they spend on such tasks?
* Fully automated or many manual steps to build and deploy?
>From my perspective *the question* look's like:
*A) We don't like to have that folder as a top folder.*
*B) People should be able to use Thrift as easy and fast as possible.*
If you think nobody maintains that patch...
now this patch has version 7 and there are many people here ready to maintain that directory.
The same for me, I'm ready to maintain the Debian support for Thrift, setup CI as I did already at home and contribute to the test framework, Java Script language support, etc.
So please go for *answer B* and commit that patch ;-)
> Debian packaging for thrift
> ---------------------------
>
> Key: THRIFT-71
> URL: https://issues.apache.org/jira/browse/THRIFT-71
> Project: Thrift
> Issue Type: Improvement
> Environment: debian stable (etch); probably will work on lenny, but untested
> Reporter: Eric Anderson
> Priority: Minor
> Attachments: debian-packaging.patch, thrift-71.patch, thrift-71_v2.patch, thrift-71_v3.patch, thrift-71_v4.patch, thrift-71_v5.patch, thrift-71_v6.patch, thrift-71_v7.patch
>
>
> We're using thrift on Debian, so I wanted to have a package for easier
> installation by other users.
> Attached is a patch to add packaging for debian to the
> thrift-20080411p1 release. It includes two bug fixes to make the
> tests work reliably: 1) adding /usr/share/java/commons-lang.jar to the
> search path for the java tests, and 2) sleeping 1 second after
> starting the server for the python tests. If the patch is accepted,
> the maintainer should probably be set to the thrift mailing list,
> rather than the example mailing list address I used.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (THRIFT-71) Debian packaging for thrift
Posted by "Roger Meier (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/THRIFT-71?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Roger Meier updated THRIFT-71:
------------------------------
Attachment: thrift-71_v7.patch
thrift-71_v7.patch is for 0.4.0 release
see http://www.bufferoverflow.ch/drupal/thrift-debian for buildlog, sources.list and ready to use packages.
please commit this patch or tell what's wrong with it.
many people use Debian or one of its derivatives and all of them will like Thrift Debian packages!
> Debian packaging for thrift
> ---------------------------
>
> Key: THRIFT-71
> URL: https://issues.apache.org/jira/browse/THRIFT-71
> Project: Thrift
> Issue Type: Improvement
> Environment: debian stable (etch); probably will work on lenny, but untested
> Reporter: Eric Anderson
> Priority: Minor
> Attachments: debian-packaging.patch, thrift-71.patch, thrift-71_v2.patch, thrift-71_v3.patch, thrift-71_v4.patch, thrift-71_v5.patch, thrift-71_v6.patch, thrift-71_v7.patch
>
>
> We're using thrift on Debian, so I wanted to have a package for easier
> installation by other users.
> Attached is a patch to add packaging for debian to the
> thrift-20080411p1 release. It includes two bug fixes to make the
> tests work reliably: 1) adding /usr/share/java/commons-lang.jar to the
> search path for the java tests, and 2) sleeping 1 second after
> starting the server for the python tests. If the patch is accepted,
> the maintainer should probably be set to the thrift mailing list,
> rather than the example mailing list address I used.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (THRIFT-71) Debian packaging for thrift
Posted by "Esteve Fernandez (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/THRIFT-71?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12672334#action_12672334 ]
Esteve Fernandez commented on THRIFT-71:
----------------------------------------
_Looks like libthrift-cil is supposed to be libthrift-cli (typo)_
No, it's not. See e.g libevolution3.0-cil or libnunit2.2-cil
_Should openjdk-6-jdk be a build-depend or just java6-sdk or maybe just java-compiler?_
I chose openjdk-6-jdk because java6-sdk is just a virtual package, but I guess openjdk-6-jdk | java6-sdk is more elegant. However, java-compiler is not enough to compile Thrift, since the latter depends on a JDK library (e.g. jikes wouldn't be able to compile Thrift unless the complete Java library was installed), and it's also a virtual package.
_Why depend on erlang-nox instead of erlang-base or just erlang?_
Because if we depend on erlang, dpkg and apt-get will pull erlang-x11 as well, which isn't actually required. It doesn't explicitly depend on erlang-base as it's already a dependency of erlang-nox
_Should we include the examples in the docs package?_
Sure, I didn't create a package for documentation as it's not particularly complete, but we could simply package examples for the time being.
_I haven't had a chance to actually try building it, but I'll give that a go later today and report back if I run into any issues. I've got etch and lenny at my disposal and can give both a shot._
Although it's not the real thing (Debian), the Thrift packages build cleanly in Ubuntu Hardy and Intrepid, we regularly publish snapshots at our Launchpad PPA.
> Debian packaging for thrift
> ---------------------------
>
> Key: THRIFT-71
> URL: https://issues.apache.org/jira/browse/THRIFT-71
> Project: Thrift
> Issue Type: Improvement
> Environment: debian stable (etch); probably will work on lenny, but untested
> Reporter: Eric Anderson
> Priority: Minor
> Attachments: debian-packaging.patch, thrift-71.patch, thrift-71_v2.patch, thrift-71_v3.patch, thrift-71_v4.patch
>
>
> We're using thrift on Debian, so I wanted to have a package for easier
> installation by other users.
> Attached is a patch to add packaging for debian to the
> thrift-20080411p1 release. It includes two bug fixes to make the
> tests work reliably: 1) adding /usr/share/java/commons-lang.jar to the
> search path for the java tests, and 2) sleeping 1 second after
> starting the server for the python tests. If the patch is accepted,
> the maintainer should probably be set to the thrift mailing list,
> rather than the example mailing list address I used.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (THRIFT-71) Debian packaging for thrift
Posted by "David Reiss (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/THRIFT-71?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12919400#action_12919400 ]
David Reiss commented on THRIFT-71:
-----------------------------------
I vote -1 to putting a debian-specific directory at the top level of the Thrift source tree. If everyone else is against me on this, I'll give in, but it seems like bad practice to clutter up the top level of our tree with system-specific stuff.
> Debian packaging for thrift
> ---------------------------
>
> Key: THRIFT-71
> URL: https://issues.apache.org/jira/browse/THRIFT-71
> Project: Thrift
> Issue Type: Improvement
> Environment: debian stable (etch); probably will work on lenny, but untested
> Reporter: Eric Anderson
> Priority: Minor
> Attachments: debian-packaging.patch, thrift-71.patch, thrift-71_v2.patch, thrift-71_v3.patch, thrift-71_v4.patch, thrift-71_v5.patch, thrift-71_v6.patch, thrift-71_v7.patch, THRIFT-71_v8_0.5.0.patch
>
>
> We're using thrift on Debian, so I wanted to have a package for easier
> installation by other users.
> Attached is a patch to add packaging for debian to the
> thrift-20080411p1 release. It includes two bug fixes to make the
> tests work reliably: 1) adding /usr/share/java/commons-lang.jar to the
> search path for the java tests, and 2) sleeping 1 second after
> starting the server for the python tests. If the patch is accepted,
> the maintainer should probably be set to the thrift mailing list,
> rather than the example mailing list address I used.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (THRIFT-71) Debian packaging for thrift
Posted by "Eric Anderson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/THRIFT-71?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Eric Anderson updated THRIFT-71:
--------------------------------
Priority: Minor (was: Major)
> Debian packaging for thrift
> ---------------------------
>
> Key: THRIFT-71
> URL: https://issues.apache.org/jira/browse/THRIFT-71
> Project: Thrift
> Issue Type: Improvement
> Environment: debian stable (etch); probably will work on lenny, but untested
> Reporter: Eric Anderson
> Priority: Minor
> Attachments: debian-packaging.patch
>
>
> We're using thrift on Debian, so I wanted to have a package for easier
> installation by other users.
> Attached is a patch to add packaging for debian to the
> thrift-20080411p1 release. It includes two bug fixes to make the
> tests work reliably: 1) adding /usr/share/java/commons-lang.jar to the
> search path for the java tests, and 2) sleeping 1 second after
> starting the server for the python tests. If the patch is accepted,
> the maintainer should probably be set to the thrift mailing list,
> rather than the example mailing list address I used.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (THRIFT-71) Debian packaging for thrift
Posted by "David Reiss (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/THRIFT-71?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12615371#action_12615371 ]
David Reiss commented on THRIFT-71:
-----------------------------------
I'm fine with having this under contrib. I'd still like Todd to compare it to what he did. Also, the non-debian-related diffs in this patch should be separate issues.
> Debian packaging for thrift
> ---------------------------
>
> Key: THRIFT-71
> URL: https://issues.apache.org/jira/browse/THRIFT-71
> Project: Thrift
> Issue Type: Improvement
> Environment: debian stable (etch); probably will work on lenny, but untested
> Reporter: Eric Anderson
> Priority: Minor
> Attachments: debian-packaging.patch
>
>
> We're using thrift on Debian, so I wanted to have a package for easier
> installation by other users.
> Attached is a patch to add packaging for debian to the
> thrift-20080411p1 release. It includes two bug fixes to make the
> tests work reliably: 1) adding /usr/share/java/commons-lang.jar to the
> search path for the java tests, and 2) sleeping 1 second after
> starting the server for the python tests. If the patch is accepted,
> the maintainer should probably be set to the thrift mailing list,
> rather than the example mailing list address I used.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (THRIFT-71) Debian packaging for thrift
Posted by "Todd Lipcon (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/THRIFT-71?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12672328#action_12672328 ]
Todd Lipcon commented on THRIFT-71:
-----------------------------------
Here are a couple notes:
- Looks like libthrift-cil is supposed to be libthrift-cli (typo)
- Should openjdk-6-jdk be a build-depend or just java6-sdk or maybe just java-compiler?
- Why depend on erlang-nox instead of erlang-base or just erlang?
- Should we include the examples in the docs package?
I haven't had a chance to actually try building it, but I'll give that a go later today and report back if I run into any issues. I've got etch and lenny at my disposal and can give both a shot.
-Todd
> Debian packaging for thrift
> ---------------------------
>
> Key: THRIFT-71
> URL: https://issues.apache.org/jira/browse/THRIFT-71
> Project: Thrift
> Issue Type: Improvement
> Environment: debian stable (etch); probably will work on lenny, but untested
> Reporter: Eric Anderson
> Priority: Minor
> Attachments: debian-packaging.patch, thrift-71.patch, thrift-71_v2.patch, thrift-71_v3.patch, thrift-71_v4.patch
>
>
> We're using thrift on Debian, so I wanted to have a package for easier
> installation by other users.
> Attached is a patch to add packaging for debian to the
> thrift-20080411p1 release. It includes two bug fixes to make the
> tests work reliably: 1) adding /usr/share/java/commons-lang.jar to the
> search path for the java tests, and 2) sleeping 1 second after
> starting the server for the python tests. If the patch is accepted,
> the maintainer should probably be set to the thrift mailing list,
> rather than the example mailing list address I used.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.