You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2019/12/05 00:49:16 UTC
[GitHub] [incubator-superset] codecov-io edited a comment on issue #8748:
[fix] Fixing time controls when switching datasource types
codecov-io edited a comment on issue #8748: [fix] Fixing time controls when switching datasource types
URL: https://github.com/apache/incubator-superset/pull/8748#issuecomment-561915037
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/8748?src=pr&el=h1) Report
> Merging [#8748](https://codecov.io/gh/apache/incubator-superset/pull/8748?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/c74bb6cb9b240b43198165709ee8043c527aae97?src=pr&el=desc) will **decrease** coverage by `0.03%`.
> The diff coverage is `0%`.
[](https://codecov.io/gh/apache/incubator-superset/pull/8748?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #8748 +/- ##
==========================================
- Coverage 65.87% 65.84% -0.04%
==========================================
Files 483 483
Lines 24123 24161 +38
Branches 2767 2771 +4
==========================================
+ Hits 15892 15908 +16
- Misses 8055 8075 +20
- Partials 176 178 +2
```
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/8748?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...rset/assets/src/explore/reducers/exploreReducer.js](https://codecov.io/gh/apache/incubator-superset/pull/8748/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYXNzZXRzL3NyYy9leHBsb3JlL3JlZHVjZXJzL2V4cGxvcmVSZWR1Y2VyLmpz) | `25.92% <0%> (-7.41%)` | :arrow_down: |
| [superset/models/sql\_lab.py](https://codecov.io/gh/apache/incubator-superset/pull/8748/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL3NxbF9sYWIucHk=) | `90.99% <0%> (-3.41%)` | :arrow_down: |
| [superset/assets/src/SqlLab/actions/sqlLab.js](https://codecov.io/gh/apache/incubator-superset/pull/8748/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYXNzZXRzL3NyYy9TcWxMYWIvYWN0aW9ucy9zcWxMYWIuanM=) | `61.96% <0%> (-0.28%)` | :arrow_down: |
| [superset/db\_engine\_specs/presto.py](https://codecov.io/gh/apache/incubator-superset/pull/8748/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3ByZXN0by5weQ==) | `22.48% <0%> (-0.11%)` | :arrow_down: |
| [...rset/assets/src/SqlLab/reducers/getInitialState.js](https://codecov.io/gh/apache/incubator-superset/pull/8748/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYXNzZXRzL3NyYy9TcWxMYWIvcmVkdWNlcnMvZ2V0SW5pdGlhbFN0YXRlLmpz) | `0% <0%> (ø)` | :arrow_up: |
| [.../src/explore/components/controls/SelectControl.jsx](https://codecov.io/gh/apache/incubator-superset/pull/8748/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYXNzZXRzL3NyYy9leHBsb3JlL2NvbXBvbmVudHMvY29udHJvbHMvU2VsZWN0Q29udHJvbC5qc3g=) | `83.52% <0%> (ø)` | :arrow_up: |
| [superset/viz.py](https://codecov.io/gh/apache/incubator-superset/pull/8748/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdml6LnB5) | `71.52% <0%> (+0.01%)` | :arrow_up: |
| [superset/config.py](https://codecov.io/gh/apache/incubator-superset/pull/8748/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29uZmlnLnB5) | `89.95% <0%> (+0.04%)` | :arrow_up: |
| [...re/components/controls/TimeSeriesColumnControl.jsx](https://codecov.io/gh/apache/incubator-superset/pull/8748/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYXNzZXRzL3NyYy9leHBsb3JlL2NvbXBvbmVudHMvY29udHJvbHMvVGltZVNlcmllc0NvbHVtbkNvbnRyb2wuanN4) | `57.4% <0%> (+0.8%)` | :arrow_up: |
| [superset/views/datasource.py](https://codecov.io/gh/apache/incubator-superset/pull/8748/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvZGF0YXNvdXJjZS5weQ==) | `96.15% <0%> (+1.03%)` | :arrow_up: |
| ... and [1 more](https://codecov.io/gh/apache/incubator-superset/pull/8748/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/8748?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/8748?src=pr&el=footer). Last update [c74bb6c...7359ce8](https://codecov.io/gh/apache/incubator-superset/pull/8748?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org