You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cordova.apache.org by BigstickCarpet <gi...@git.apache.org> on 2014/12/11 20:30:59 UTC
[GitHub] cordova-plugin-dialogs pull request: Added support for the new "br...
GitHub user BigstickCarpet opened a pull request:
https://github.com/apache/cordova-plugin-dialogs/pull/46
Added support for the new "browser" platform in Cordova 4
The new browser platform in Cordova 4 is awesome. And now this plugin is awesome because it supports it. :)
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/BigstickCarpet/cordova-plugin-dialogs master
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/cordova-plugin-dialogs/pull/46.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #46
----
commit 5a193c8947761618713e0d6874ad966ffcef62d4
Author: James Messinger <ja...@gmail.com>
Date: 2014-12-11T19:25:22Z
Added support for the new "browser" platform in Cordova 4
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-plugin-dialogs pull request: Added support for the new "br...
Posted by BigstickCarpet <gi...@git.apache.org>.
Github user BigstickCarpet commented on the pull request:
https://github.com/apache/cordova-plugin-dialogs/pull/46#issuecomment-66696186
Ok. I'll fill out an iCLA and send it in later today.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-plugin-dialogs pull request: Added support for the new "br...
Posted by daserge <gi...@git.apache.org>.
Github user daserge commented on the pull request:
https://github.com/apache/cordova-plugin-dialogs/pull/46#issuecomment-66686970
Here is [the corresponding JIRA issue](https://issues.apache.org/jira/browse/CB-7955)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-plugin-dialogs pull request: Added support for the new "br...
Posted by kamrik <gi...@git.apache.org>.
Github user kamrik commented on a diff in the pull request:
https://github.com/apache/cordova-plugin-dialogs/pull/46#discussion_r21702976
--- Diff: www/browser/notification.js ---
@@ -0,0 +1,94 @@
+// Platform: browser
+window.navigator.notification = window.navigator.notification || {};
+
+module.exports.alert = window.navigator.notification.alert = function(message, callback) {
+ // `notification.alert` executes asynchronously
+ setTimeout(function() {
+ window.alert(message);
--- End diff --
I think this will block all of js execution until the dialog is dismissed?
This shouldn't be an issue for many cases, but it will result in a different behavior compared to android implementation where it's completely async. Actually I was working on an async implementation of this for browser. So I would be glad if this goes in and then I'll add my part on top.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-plugin-dialogs pull request: Added support for the new "br...
Posted by BigstickCarpet <gi...@git.apache.org>.
Github user BigstickCarpet commented on the pull request:
https://github.com/apache/cordova-plugin-dialogs/pull/46#issuecomment-66826408
@kamrik I just got an email confirming that my iCLA is now on file.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-plugin-dialogs pull request: Added support for the new "br...
Posted by BigstickCarpet <gi...@git.apache.org>.
Github user BigstickCarpet commented on a diff in the pull request:
https://github.com/apache/cordova-plugin-dialogs/pull/46#discussion_r21704134
--- Diff: www/browser/notification.js ---
@@ -0,0 +1,94 @@
+// Platform: browser
+window.navigator.notification = window.navigator.notification || {};
+
+module.exports.alert = window.navigator.notification.alert = function(message, callback) {
+ // `notification.alert` executes asynchronously
+ setTimeout(function() {
+ window.alert(message);
--- End diff --
You're correct that all JavaScript code is blocked while the alert is displayed. But the `setTimeout` at least keeps things as consistent as possible by displaying the alert asynchronously, so the calling code runs in the correct order
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-plugin-dialogs pull request: Added support for the new "br...
Posted by kamrik <gi...@git.apache.org>.
Github user kamrik commented on the pull request:
https://github.com/apache/cordova-plugin-dialogs/pull/46#issuecomment-66686534
James, did you sign the Apache CLA? I don't see you on the list yet. Apache requires this.
http://people.apache.org/committer-index.html
http://cordova.apache.org/#contribute
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-plugin-dialogs pull request: Added support for the new "br...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/cordova-plugin-dialogs/pull/46
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-plugin-dialogs pull request: Added support for the new "br...
Posted by kamrik <gi...@git.apache.org>.
Github user kamrik commented on the pull request:
https://github.com/apache/cordova-plugin-dialogs/pull/46#issuecomment-66841786
Cool, I see you on the list now http://people.apache.org/committer-index.html
I'll get back to this over the weekend or early next week.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org