You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@cloudstack.apache.org by GitBox <gi...@apache.org> on 2021/09/29 06:16:27 UTC

[GitHub] [cloudstack] utchoang commented on a change in pull request #5526: UI - Fixes modal width by device screen

utchoang commented on a change in pull request #5526:
URL: https://github.com/apache/cloudstack/pull/5526#discussion_r718184183



##########
File path: ui/src/views/AutogenView.vue
##########
@@ -1524,13 +1527,18 @@ export default {
       } else {
         callback()
       }
+    },
+    setModalWidthByScreen () {
+      const screenWidth = window.innerWidth
+      if (screenWidth <= 768) {
+        this.modalWidth = '450px'

Review comment:
       No, currently I only hard fix the width for ipad, tablet screens and below. Do you feel it is ok or do you need to follow the percentage of the screen?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org