You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@struts.apache.org by Craig McClanahan <cr...@gmail.com> on 2004/07/23 19:52:17 UTC
Re: r3990 - trunk/src/share/org/apache/struts/taglib/html
On Thu, 22 Jul 2004 15:34:52 -0500, niallp@wush.net <ni...@wush.net> wrote:
> Author: niallp
> Date: 2004-07-22 15:34:51 -0500 (Thu, 22 Jul 2004)
> New Revision: 3990
>
> Modified:
> trunk/src/share/org/apache/struts/taglib/html/FormTag.java
> Log:
>
> Modified: trunk/src/share/org/apache/struts/taglib/html/FormTag.java
>
Niall,
The diff for this commit looks like it replaced the entire file
(probably a line ending difference or something, which we need to
figure out), and there's no comment in the log about what actually
changed. So, what actually changed? :-)
Craig
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
For additional commands, e-mail: dev-help@struts.apache.org
RE: r3990 - trunk/src/share/org/apache/struts/taglib/html
Posted by Martin Cooper <ma...@apache.org>.
> -----Original Message-----
> From: Niall Pemberton [mailto:niall.pemberton@blueyonder.co.uk]
> Sent: Friday, July 23, 2004 6:17 PM
> To: Struts Developers List
> Subject: Re: r3990 - trunk/src/share/org/apache/struts/taglib/html
>
>
> Sorry about the comment - was my first subversion commit. I'm using
> TortoiseSVN under windows - theres a "Minimum Logsize in chars" option in
> the "settings" which defaults to 0 - so it didn't stop me committing a
> change without a log message :(
>
> All I did was drop the current FormTag file version from my local CVS
> (version 1.61) on top of the one I checked out from subversion (which was
> the CVS 1.59 version) and committ it.
That's the problem. The CVS and SVN line ends are obviously configured
differently, so when you dropped the CVS one over the SVN one, you
inadvertently changed all of the line ends from what was previously checked
in to SVN.
I'm not yet familiar enough with SVN to know if that's something that needs
repo config or client config (or just care with the source files ;).
--
Martin Cooper
>
> So the changes were those in versions 1.60 and 1.61 that I recently
> committed to CVS. The diffs for the two versions in CVS look fine.
>
>
> Niall
>
> ----- Original Message -----
> From: "Craig McClanahan" <cr...@gmail.com>
> To: "Struts Developers List" <de...@struts.apache.org>
> Sent: Friday, July 23, 2004 6:52 PM
> Subject: Re: r3990 - trunk/src/share/org/apache/struts/taglib/html
>
>
> > On Thu, 22 Jul 2004 15:34:52 -0500, niallp@wush.net <ni...@wush.net>
> wrote:
> > > Author: niallp
> > > Date: 2004-07-22 15:34:51 -0500 (Thu, 22 Jul 2004)
> > > New Revision: 3990
> > >
> > > Modified:
> > > trunk/src/share/org/apache/struts/taglib/html/FormTag.java
> > > Log:
> > >
> > > Modified: trunk/src/share/org/apache/struts/taglib/html/FormTag.java
> > >
> >
> > Niall,
> >
> > The diff for this commit looks like it replaced the entire file
> > (probably a line ending difference or something, which we need to
> > figure out), and there's no comment in the log about what actually
> > changed. So, what actually changed? :-)
> >
> > Craig
> >
> > ---------------------------------------------------------------------
> > To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
> > For additional commands, e-mail: dev-help@struts.apache.org
> >
> >
> >
>
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
> For additional commands, e-mail: dev-help@struts.apache.org
>
>
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
For additional commands, e-mail: dev-help@struts.apache.org
Re: r3990 - trunk/src/share/org/apache/struts/taglib/html
Posted by Niall Pemberton <ni...@blueyonder.co.uk>.
Sorry about the comment - was my first subversion commit. I'm using
TortoiseSVN under windows - theres a "Minimum Logsize in chars" option in
the "settings" which defaults to 0 - so it didn't stop me committing a
change without a log message :(
All I did was drop the current FormTag file version from my local CVS
(version 1.61) on top of the one I checked out from subversion (which was
the CVS 1.59 version) and committ it.
So the changes were those in versions 1.60 and 1.61 that I recently
committed to CVS. The diffs for the two versions in CVS look fine.
Niall
----- Original Message -----
From: "Craig McClanahan" <cr...@gmail.com>
To: "Struts Developers List" <de...@struts.apache.org>
Sent: Friday, July 23, 2004 6:52 PM
Subject: Re: r3990 - trunk/src/share/org/apache/struts/taglib/html
> On Thu, 22 Jul 2004 15:34:52 -0500, niallp@wush.net <ni...@wush.net>
wrote:
> > Author: niallp
> > Date: 2004-07-22 15:34:51 -0500 (Thu, 22 Jul 2004)
> > New Revision: 3990
> >
> > Modified:
> > trunk/src/share/org/apache/struts/taglib/html/FormTag.java
> > Log:
> >
> > Modified: trunk/src/share/org/apache/struts/taglib/html/FormTag.java
> >
>
> Niall,
>
> The diff for this commit looks like it replaced the entire file
> (probably a line ending difference or something, which we need to
> figure out), and there's no comment in the log about what actually
> changed. So, what actually changed? :-)
>
> Craig
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
> For additional commands, e-mail: dev-help@struts.apache.org
>
>
>
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
For additional commands, e-mail: dev-help@struts.apache.org