You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2019/05/09 20:57:34 UTC

[GitHub] [airflow] potiuk commented on a change in pull request #5263: [AIRFLOW-4490] dag_run.conf should be an empty dictionary by default instead of None

potiuk commented on a change in pull request #5263: [AIRFLOW-4490] dag_run.conf should be an empty dictionary by default instead of None
URL: https://github.com/apache/airflow/pull/5263#discussion_r282662706
 
 

 ##########
 File path: airflow/models/dagrun.py
 ##########
 @@ -54,7 +54,7 @@ class DagRun(Base, LoggingMixin):
     _state = Column('state', String(50), default=State.RUNNING)
     run_id = Column(String(ID_LEN))
     external_trigger = Column(Boolean, default=True)
-    conf = Column(PickleType)
+    conf = Column(PickleType, default={})
 
 Review comment:
   I think it would be great to add a test case covering this empty dict behavior.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services