[GitHub] [buildstream] cs-shadow commented on pull request #1441: Improve CI setup for pre-merge checks

[GitBox <gi...@apache.org>]

cs-shadow commented on pull request #1441:
URL: https://github.com/apache/buildstream/pull/1441#issuecomment-759417558


   > Will this approach help us run multiple parallel containers for the sake of the remote execution tests ?
   
   Indeed. Compose supports bringing up multiple services, have dependencies across them etc so it should be reasonably straightforward to add remote executetion tests. In fact, the old remote execution tests already were using such a compose file: https://gitlab.com/BuildStream/buildstream/-/blob/master/.gitlab-ci/buildgrid-remote-execution.yml
   
   > Overall it looks good, but I think we should update the merge.yml and release.yml workflows to build the docs this way also.
   
   Thanks! I'll fix this and fix a couple of other reamining TODOs later today.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org