[jira] Commented: (WICKET-364) Use an uniform behavior for the expiration page

["Jean-Baptiste Quenot (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/WICKET-364?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12478831 ] 

Jean-Baptiste Quenot commented on WICKET-364:
---------------------------------------------

Fixed in 1.x, thanks for your patch!

> Use an uniform behavior for the expiration page
> -----------------------------------------------
>
>                 Key: WICKET-364
>                 URL: https://issues.apache.org/jira/browse/WICKET-364
>             Project: Wicket
>          Issue Type: Bug
>          Components: wicket
>    Affects Versions: 1.3
>            Reporter: Gregory Maes
>         Assigned To: Jean-Baptiste Quenot
>             Fix For: 1.3
>
>         Attachments: wicket-364.patch
>
>
> The expiration page does not behave the same according to whether we are in ajax mode or not. 
> In case of ajax mode, we get a EmptyRequestTarget in the 'resolve' method of the WebRequestCycleProcessor class. Thus, the ajax response is empty and we get a failure which is muted by default (no window.wicketGlobalFailureHandler defined) while parsing the response in wicket-ajax.js.
> In case of a non-bookmarkablepage request, we get a ExpiredPageClassRequestTarget in the 'resolveRenderedPage' method of the AbstractRequestCycleProcessor class. Thus, we have the correct behavior with a redirection to the expired page.
> Why not gathering those 2 behaviors throwing a PageExpiredException which would be catched in the 'step' method of the RequestCycle class? Then, the processor  would respond with a redirection to the expired page in both case.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.