You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cloudberry.apache.org by "yjhjstz (via GitHub)" <gi...@apache.org> on 2025/10/20 19:04:37 UTC

[PR] ORCA: skip MVCC system columns for standalone AO tables [cloudberry]

yjhjstz opened a new pull request, #1409:
URL: https://github.com/apache/cloudberry/pull/1409

   Fix ORCA fallback error when querying AO tables with multiple DISTINCT aggregates:
     "Invalid system target list found for AO table"
   
   AO tables don't support MVCC system columns (xmin, xmax, cmin, cmax). Skip these columns when building metadata for standalone AO tables, but preserve them for partitioned tables to maintain column mapping consistency.
   
   
   Fixes #ISSUE_Number
   
   ### What does this PR do?
   <!-- Brief overview of the changes, including any major features or fixes -->
   
   ### Type of Change
   - [ ] Bug fix (non-breaking change)
   - [ ] New feature (non-breaking change)
   - [ ] Breaking change (fix or feature with breaking changes)
   - [ ] Documentation update
   
   ### Breaking Changes
   <!-- Remove if not applicable. If yes, explain impact and migration path -->
   
   ### Test Plan
   <!-- How did you test these changes? -->
   - [ ] Unit tests added/updated
   - [ ] Integration tests added/updated
   - [ ] Passed `make installcheck`
   - [ ] Passed `make -C src/test installcheck-cbdb-parallel`
   
   ### Impact
   <!-- Remove sections that don't apply -->
   **Performance:**
   <!-- Any performance implications? -->
   
   **User-facing changes:**
   <!-- Any changes visible to users? -->
   
   **Dependencies:**
   <!-- New dependencies or version changes? -->
   
   ### Checklist
   - [ ] Followed [contribution guide](https://cloudberry.apache.org/contribute/code)
   - [ ] Added/updated documentation
   - [ ] Reviewed code for security implications
   - [ ] Requested review from [cloudberry committers](https://github.com/orgs/apache/teams/cloudberry-committers)
   
   ### Additional Context
   <!-- Any other information that would help reviewers? Remove if none -->
   
   ### CI Skip Instructions
   <!--
   To skip CI builds, add the appropriate CI skip identifier to your PR title.
   The identifier must:
   - Be in square brackets []
   - Include the word "ci" and either "skip" or "no"
   - Only use for documentation-only changes or when absolutely necessary
   -->
   
   ---
   <!-- Join our community:
   - Mailing list: [dev@cloudberry.apache.org](https://lists.apache.org/list.html?dev@cloudberry.apache.org) (subscribe: dev-subscribe@cloudberry.apache.org)
   - Discussions: https://github.com/apache/cloudberry/discussions -->
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudberry.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cloudberry.apache.org
For additional commands, e-mail: commits-help@cloudberry.apache.org


Re: [PR] ORCA: skip MVCC system columns for standalone AO tables [cloudberry]

Posted by "yjhjstz (via GitHub)" <gi...@apache.org>.
yjhjstz commented on code in PR #1409:
URL: https://github.com/apache/cloudberry/pull/1409#discussion_r2449111609


##########
src/backend/gpopt/translate/CTranslatorRelcacheToDXL.cpp:
##########
@@ -862,13 +862,30 @@ CTranslatorRelcacheToDXL::RetrieveRelDistributionOpFamilies(CMemoryPool *mp,
 void
 CTranslatorRelcacheToDXL::AddSystemColumns(CMemoryPool *mp,
 										   CMDColumnArray *mdcol_array,
-										   Relation /*rel*/)
+										   Relation rel)
 {
+	// Get storage type to determine which system columns are supported
+	IMDRelation::Erelstoragetype rel_storage_type = RetrieveRelStorageType(rel);
+	BOOL is_standalone_ao_table = ((rel_storage_type == IMDRelation::ErelstorageAppendOnlyRows ||
+						rel_storage_type == IMDRelation::ErelstorageAppendOnlyCols)) &&
+						rel->rd_rel->relkind != RELKIND_PARTITIONED_TABLE &&
+						!rel->rd_rel->relispartition;

Review Comment:
   not support, add check ErelstoragePAX.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudberry.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cloudberry.apache.org
For additional commands, e-mail: commits-help@cloudberry.apache.org


Re: [PR] ORCA: skip MVCC system columns for standalone AO tables [cloudberry]

Posted by "my-ship-it (via GitHub)" <gi...@apache.org>.
my-ship-it merged PR #1409:
URL: https://github.com/apache/cloudberry/pull/1409


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudberry.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cloudberry.apache.org
For additional commands, e-mail: commits-help@cloudberry.apache.org


Re: [PR] ORCA: skip MVCC system columns for standalone AO tables [cloudberry]

Posted by "yjhjstz (via GitHub)" <gi...@apache.org>.
yjhjstz commented on code in PR #1409:
URL: https://github.com/apache/cloudberry/pull/1409#discussion_r2448505610


##########
src/backend/gpopt/translate/CTranslatorRelcacheToDXL.cpp:
##########
@@ -862,13 +862,30 @@ CTranslatorRelcacheToDXL::RetrieveRelDistributionOpFamilies(CMemoryPool *mp,
 void
 CTranslatorRelcacheToDXL::AddSystemColumns(CMemoryPool *mp,
 										   CMDColumnArray *mdcol_array,
-										   Relation /*rel*/)
+										   Relation rel)
 {
+	// Get storage type to determine which system columns are supported
+	IMDRelation::Erelstoragetype rel_storage_type = RetrieveRelStorageType(rel);
+	BOOL is_standalone_ao_table = ((rel_storage_type == IMDRelation::ErelstorageAppendOnlyRows ||
+						rel_storage_type == IMDRelation::ErelstorageAppendOnlyCols)) &&
+						rel->rd_rel->relkind != RELKIND_PARTITIONED_TABLE &&
+						!rel->rd_rel->relispartition;

Review Comment:
   not supported.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudberry.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cloudberry.apache.org
For additional commands, e-mail: commits-help@cloudberry.apache.org


Re: [PR] ORCA: skip MVCC system columns for standalone AO tables [cloudberry]

Posted by "my-ship-it (via GitHub)" <gi...@apache.org>.
my-ship-it commented on code in PR #1409:
URL: https://github.com/apache/cloudberry/pull/1409#discussion_r2446941932


##########
src/backend/gpopt/translate/CTranslatorRelcacheToDXL.cpp:
##########
@@ -862,13 +862,30 @@ CTranslatorRelcacheToDXL::RetrieveRelDistributionOpFamilies(CMemoryPool *mp,
 void
 CTranslatorRelcacheToDXL::AddSystemColumns(CMemoryPool *mp,
 										   CMDColumnArray *mdcol_array,
-										   Relation /*rel*/)
+										   Relation rel)
 {
+	// Get storage type to determine which system columns are supported
+	IMDRelation::Erelstoragetype rel_storage_type = RetrieveRelStorageType(rel);
+	BOOL is_standalone_ao_table = ((rel_storage_type == IMDRelation::ErelstorageAppendOnlyRows ||
+						rel_storage_type == IMDRelation::ErelstorageAppendOnlyCols)) &&
+						rel->rd_rel->relkind != RELKIND_PARTITIONED_TABLE &&
+						!rel->rd_rel->relispartition;

Review Comment:
   How about partitioned table?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudberry.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cloudberry.apache.org
For additional commands, e-mail: commits-help@cloudberry.apache.org


Re: [PR] ORCA: skip MVCC system columns for standalone AO tables [cloudberry]

Posted by "yjhjstz (via GitHub)" <gi...@apache.org>.
yjhjstz commented on code in PR #1409:
URL: https://github.com/apache/cloudberry/pull/1409#discussion_r2448505610


##########
src/backend/gpopt/translate/CTranslatorRelcacheToDXL.cpp:
##########
@@ -862,13 +862,30 @@ CTranslatorRelcacheToDXL::RetrieveRelDistributionOpFamilies(CMemoryPool *mp,
 void
 CTranslatorRelcacheToDXL::AddSystemColumns(CMemoryPool *mp,
 										   CMDColumnArray *mdcol_array,
-										   Relation /*rel*/)
+										   Relation rel)
 {
+	// Get storage type to determine which system columns are supported
+	IMDRelation::Erelstoragetype rel_storage_type = RetrieveRelStorageType(rel);
+	BOOL is_standalone_ao_table = ((rel_storage_type == IMDRelation::ErelstorageAppendOnlyRows ||
+						rel_storage_type == IMDRelation::ErelstorageAppendOnlyCols)) &&
+						rel->rd_rel->relkind != RELKIND_PARTITIONED_TABLE &&
+						!rel->rd_rel->relispartition;

Review Comment:
   not supported.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudberry.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cloudberry.apache.org
For additional commands, e-mail: commits-help@cloudberry.apache.org