You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@guacamole.apache.org by necouchman <gi...@git.apache.org> on 2018/03/15 10:59:18 UTC
[GitHub] guacamole-server pull request #160: GUACAMOLE-30: Implement systemd script f...
GitHub user necouchman opened a pull request:
https://github.com/apache/guacamole-server/pull/160
GUACAMOLE-30: Implement systemd script for guacd
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/necouchman/guacamole-server jira/30
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/guacamole-server/pull/160.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #160
----
commit 77cac3b30d25dc38e8e5da63f49834c8c567ee5e
Author: Nick Couchman <vn...@...>
Date: 2018-03-15T10:52:41Z
GUACAMOLE-30: Implement systemd script for guacd
----
---
[GitHub] guacamole-server pull request #160: GUACAMOLE-30: Implement systemd startup ...
Posted by mike-jumper <gi...@git.apache.org>.
Github user mike-jumper commented on a diff in the pull request:
https://github.com/apache/guacamole-server/pull/160#discussion_r175202657
--- Diff: src/guacd/systemd/guacd.service.in ---
@@ -0,0 +1,11 @@
+[Unit]
+Description=Guacamole Server
+Documentation=man:guacd(8)
+
+[Service]
+User=daemon
+ExecStart=@sbindir@/guacd -f
--- End diff --
Is this the generally-accepted best practice? Relying on systemd to handle the daemonization for the process, management of any PID file, etc.?
---
[GitHub] guacamole-server pull request #160: GUACAMOLE-30: Implement systemd startup ...
Posted by necouchman <gi...@git.apache.org>.
Github user necouchman commented on a diff in the pull request:
https://github.com/apache/guacamole-server/pull/160#discussion_r175213905
--- Diff: src/guacd/systemd/guacd.service.in ---
@@ -0,0 +1,11 @@
+[Unit]
--- End diff --
Added.
---
[GitHub] guacamole-server pull request #160: GUACAMOLE-30: Implement systemd startup ...
Posted by necouchman <gi...@git.apache.org>.
Github user necouchman commented on a diff in the pull request:
https://github.com/apache/guacamole-server/pull/160#discussion_r175207725
--- Diff: src/guacd/systemd/guacd.service.in ---
@@ -0,0 +1,11 @@
+[Unit]
+Description=Guacamole Server
+Documentation=man:guacd(8)
+
+[Service]
+User=daemon
+ExecStart=@sbindir@/guacd -f
--- End diff --
Yes - most of what I've seen in systemd unit files is that you put the process in foreground mode and allow systemd to manage it. I can't cite a source that says it, just my anecdotal experience.
---
[GitHub] guacamole-server pull request #160: GUACAMOLE-30: Implement systemd startup ...
Posted by mike-jumper <gi...@git.apache.org>.
Github user mike-jumper commented on a diff in the pull request:
https://github.com/apache/guacamole-server/pull/160#discussion_r175201377
--- Diff: src/guacd/systemd/guacd.service.in ---
@@ -0,0 +1,11 @@
+[Unit]
--- End diff --
Do systemd unit files support comments? Assuming they do, this new file should include the usual license boilerplate.
---
[GitHub] guacamole-server pull request #160: GUACAMOLE-30: Implement systemd startup ...
Posted by necouchman <gi...@git.apache.org>.
Github user necouchman commented on a diff in the pull request:
https://github.com/apache/guacamole-server/pull/160#discussion_r175207766
--- Diff: src/guacd/systemd/guacd.service.in ---
@@ -0,0 +1,11 @@
+[Unit]
--- End diff --
Probably so...will add it.
---
[GitHub] guacamole-server pull request #160: GUACAMOLE-30: Implement systemd startup ...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/guacamole-server/pull/160
---
[GitHub] guacamole-server pull request #160: GUACAMOLE-30: Implement systemd startup ...
Posted by mike-jumper <gi...@git.apache.org>.
Github user mike-jumper commented on a diff in the pull request:
https://github.com/apache/guacamole-server/pull/160#discussion_r175249402
--- Diff: src/guacd/systemd/guacd.service.in ---
@@ -0,0 +1,11 @@
+[Unit]
+Description=Guacamole Server
+Documentation=man:guacd(8)
+
+[Service]
+User=daemon
+ExecStart=@sbindir@/guacd -f
--- End diff --
Googling around a bit, definitely seems the way of things for systemd: http://www.mikeperham.com/2014/09/22/dont-daemonize-your-daemons/
---