You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by "nija-at (via GitHub)" <gi...@apache.org> on 2023/07/04 07:41:27 UTC
[GitHub] [spark] nija-at opened a new pull request, #41846: [SPARK-44291][CONNECT] Fix incorrect default schema for agnostic encoder
nija-at opened a new pull request, #41846:
URL: https://github.com/apache/spark/pull/41846
### What changes were proposed in this pull request?
This is because the default schema configured in catalyst encoder is
set incorrectly. Update this to the correct value.
### Why are the changes needed?
The `range()` query returns a result with one column named "id".
However, when the underlying schema is queried, it returns the schema
to contain one column named "value".
This is a bug and is different from the behaviour in other places,
including pyspark.
### Does this PR introduce _any_ user-facing change?
Yes. It fixes the bug for incorrect column names returned for a
range query.
### How was this patch tested?
Tests attached.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] hvanhovell closed pull request #41846: [SPARK-44291][SPARK-43416][CONNECT] Fix incorrect schema for range query
Posted by "hvanhovell (via GitHub)" <gi...@apache.org>.
hvanhovell closed pull request #41846: [SPARK-44291][SPARK-43416][CONNECT] Fix incorrect schema for range query
URL: https://github.com/apache/spark/pull/41846
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] hvanhovell commented on pull request #41846: [SPARK-44291][SPARK-43416][CONNECT] Fix incorrect schema for range query
Posted by "hvanhovell (via GitHub)" <gi...@apache.org>.
hvanhovell commented on PR #41846:
URL: https://github.com/apache/spark/pull/41846#issuecomment-1622323839
Merging.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org