[jira] [Commented] (ACCUMULO-3854) [findbugs] AsyncSpanReceiver synchronizes a concurrent data structure

["Josh Elser (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/ACCUMULO-3854?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14561286#comment-14561286 ] 

Josh Elser commented on ACCUMULO-3854:
--------------------------------------

ZooTraceClient does it too in 1.7.x

> [findbugs] AsyncSpanReceiver synchronizes a concurrent data structure
> ---------------------------------------------------------------------
>
>                 Key: ACCUMULO-3854
>                 URL: https://issues.apache.org/jira/browse/ACCUMULO-3854
>             Project: Accumulo
>          Issue Type: Bug
>    Affects Versions: 1.5.0, 1.5.1, 1.5.2, 1.6.0, 1.6.1, 1.6.2, 1.7.0
>            Reporter: Josh Elser
>            Priority: Minor
>              Labels: findbugs
>             Fix For: 1.8.0, 1.7.1
>
>
> Noticed this one playing around with ACCUMULO-3853
> If the type of {{sendQueue}} is switched to the concrete ConcurrentLinkedQueue instead of AbstractQueue, findbugs will catch this as an error because we synchronize on a concurrent data structure.
> {code}
> -  protected final AbstractQueue<RemoteSpan> sendQueue = new ConcurrentLinkedQueue<RemoteSpan>();
> +  protected final ConcurrentLinkedQueue<RemoteSpan> sendQueue = new ConcurrentLinkedQueue<RemoteSpan>();
> {code}
> Should trigger some findbugs warnings from the Maven build.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)