[GitHub] [arrow] nealrichardson commented on a change in pull request #12489: ARROW-15692: [Dev] Update release scripts to use default branch

[GitBox <gi...@apache.org>]

nealrichardson commented on a change in pull request #12489:
URL: https://github.com/apache/arrow/pull/12489#discussion_r817028190



##########
File path: dev/release/post-05-ruby.sh
##########
@@ -32,14 +32,16 @@ version=$1
 archive_name=apache-arrow-${version}
 tar_gz=${archive_name}.tar.gz
 
+source "${SOURCE_DIR}/git-vars.sh"
+
 echo "NOTE: We should release RubyGems after Homebrew and MSYS2 packages are updated!!!"
 
 echo "Checking Homebrew package..."
 homebrew_version=$(
   curl \
     --fail \
     --no-progress-meter \
-    https://raw.githubusercontent.com/Homebrew/homebrew-core/master/Formula/apache-arrow-glib.rb | \
+    https://raw.githubusercontent.com/Homebrew/homebrew-core/${DEFAULT_BRANCH}/Formula/apache-arrow-glib.rb | \

Review comment:
       Shouldn't change this one since their default branch won't necessarily be ours (and anyway if they were to change, the github http server will redirect fine)
   
   ```suggestion
       https://raw.githubusercontent.com/Homebrew/homebrew-core/master/Formula/apache-arrow-glib.rb | \
   ```




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org