You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Alexander Rukletsov <ru...@gmail.com> on 2017/12/22 13:42:03 UTC
Review Request 64807: Removed redundant `struct` prefix in
"linux/ns.cpp".
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64807/
-----------------------------------------------------------
Review request for mesos, Benjamin Bannier and Michael Park.
Repository: mesos
Description
-------
See summary.
Diffs
-----
src/linux/ns.cpp 5e2df1ed56432c6c1bfa04a31dba7f9f547d6139
Diff: https://reviews.apache.org/r/64807/diff/1/
Testing
-------
make check on various Linux distros
Thanks,
Alexander Rukletsov
Re: Review Request 64807: Removed redundant `struct` prefix in
"linux/ns.cpp".
Posted by Mesos Reviewbot Windows <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64807/#review194435
-----------------------------------------------------------
FAIL: Failed to apply the dependent review: 64686.
Failed command: `python.exe .\support\apply-reviews.py -n -r 64686`
All the build artifacts available at: http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/64807
Relevant logs:
- [apply-review-64686-stderr.log](http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/64807/logs/apply-review-64686-stderr.log):
```
Traceback (most recent call last):
File ".\support\apply-reviews.py", line 434, in <module>
main()
File ".\support\apply-reviews.py", line 429, in main
reviewboard(options)
File ".\support\apply-reviews.py", line 419, in reviewboard
apply_review(options)
File ".\support\apply-reviews.py", line 160, in apply_review
commit_patch(options)
File ".\support\apply-reviews.py", line 271, in commit_patch
message.write(data['message'])
UnicodeEncodeError: 'ascii' codec can't encode character u'\u201c' in position 143: ordinal not in range(128)
```
- Mesos Reviewbot Windows
On Dec. 22, 2017, 8:42 a.m., Alexander Rukletsov wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/64807/
> -----------------------------------------------------------
>
> (Updated Dec. 22, 2017, 8:42 a.m.)
>
>
> Review request for mesos, Benjamin Bannier and Michael Park.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> See summary.
>
>
> Diffs
> -----
>
> src/linux/ns.cpp 5e2df1ed56432c6c1bfa04a31dba7f9f547d6139
>
>
> Diff: https://reviews.apache.org/r/64807/diff/1/
>
>
> Testing
> -------
>
> make check on various Linux distros
>
>
> Thanks,
>
> Alexander Rukletsov
>
>
Re: Review Request 64807: Removed redundant `struct` prefix in
"linux/ns.cpp".
Posted by Alexander Rukletsov <ru...@gmail.com>.
> On Dec. 22, 2017, 2:29 p.m., Benjamin Bannier wrote:
> > src/linux/ns.cpp
> > Line 184 (original), 184 (patched)
> > <https://reviews.apache.org/r/64807/diff/1/?file=1926498#file1926498line184>
> >
> > Kill this `struct` as well?
Not sure we can do this. There is also `stat()` POSIX function.
- Alexander
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64807/#review194428
-----------------------------------------------------------
On Dec. 22, 2017, 1:42 p.m., Alexander Rukletsov wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/64807/
> -----------------------------------------------------------
>
> (Updated Dec. 22, 2017, 1:42 p.m.)
>
>
> Review request for mesos, Benjamin Bannier and Michael Park.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> See summary.
>
>
> Diffs
> -----
>
> src/linux/ns.cpp 5e2df1ed56432c6c1bfa04a31dba7f9f547d6139
>
>
> Diff: https://reviews.apache.org/r/64807/diff/1/
>
>
> Testing
> -------
>
> make check on various Linux distros
>
>
> Thanks,
>
> Alexander Rukletsov
>
>
Re: Review Request 64807: Removed redundant `struct` prefix in
"linux/ns.cpp".
Posted by Benjamin Bannier <be...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64807/#review194428
-----------------------------------------------------------
Fix it, then Ship it!
src/linux/ns.cpp
Line 184 (original), 184 (patched)
<https://reviews.apache.org/r/64807/#comment273195>
Kill this `struct` as well?
- Benjamin Bannier
On Dec. 22, 2017, 2:42 p.m., Alexander Rukletsov wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/64807/
> -----------------------------------------------------------
>
> (Updated Dec. 22, 2017, 2:42 p.m.)
>
>
> Review request for mesos, Benjamin Bannier and Michael Park.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> See summary.
>
>
> Diffs
> -----
>
> src/linux/ns.cpp 5e2df1ed56432c6c1bfa04a31dba7f9f547d6139
>
>
> Diff: https://reviews.apache.org/r/64807/diff/1/
>
>
> Testing
> -------
>
> make check on various Linux distros
>
>
> Thanks,
>
> Alexander Rukletsov
>
>